Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83772/?format=api
{ "id": 83772, "url": "http://patchwork.dpdk.org/api/patches/83772/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201105223602.5965-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201105223602.5965-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201105223602.5965-2-stephen@networkplumber.org", "date": "2020-11-05T22:35:57", "name": "[v9,1/6] eal: replace usage of blacklist/whitelist in enum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "652143fb69aab4c4dd4f16e802384a190a375b55", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201105223602.5965-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 13705, "url": "http://patchwork.dpdk.org/api/series/13705/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13705", "date": "2020-11-05T22:35:56", "name": "replace blacklist/whitelist with allow/block", "version": 9, "mbox": "http://patchwork.dpdk.org/series/13705/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/83772/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/83772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D38EA0521;\n\tThu, 5 Nov 2020 23:36:34 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2019629C6;\n\tThu, 5 Nov 2020 23:36:16 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 8E4FA137D\n for <dev@dpdk.org>; Thu, 5 Nov 2020 23:36:14 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id 62so2344620pgg.12\n for <dev@dpdk.org>; Thu, 05 Nov 2020 14:36:14 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id u5sm1026756pgj.28.2020.11.05.14.36.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 Nov 2020 14:36:10 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=zwXAYdSR0PegyLNlzdwjLJFaS4AjUpddhtWdSetsrtM=;\n b=W7jxLw4s+rYhlZf37sD47JqP5GcbCbMRpURB3zZnblYyc/2AGYjGACVwVXr823nfz5\n S5dmjjq7p3TulKOqAivFnXU4OadMjpVQgMxokFh+E5kVEu+0YqRtIb6QMlIYI+0X03pj\n sxhykp1Pu1Ep4DMhitCYVCed364jLOHBT1awnPrT3KSC6Npx+vnWpp3+EO6r0fXKfHyi\n sL6X87vjyeFxaJqB8KR6NeLmHrnsr0gwVFDHYHpNpiErPWOtWiWUu8MXTe5FK5EI7tP9\n ctNElDCT099Pc46uXvU3ud8mREoSy7yz3pzc8CkHDpveClzVQ6ykMcBppCz7AeSvLHC/\n A81w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=zwXAYdSR0PegyLNlzdwjLJFaS4AjUpddhtWdSetsrtM=;\n b=BXNWfJgAHPaSIpb1OsZidvaA7Ye789wkx5ZticXBcshrJnyo6SEs5aOsvvd/X67n13\n 2fJtBBlEYc5s2sbXb8PpOn98mfkV4R4tqBZBty8iBnRJqChHYd7AyuipnFoA5sSxvLJi\n g4pKIX7yaWSc/qrSnjIl4iVqzn1JFS2i75bl+ugNNF78ElgIIqZ1yVlHTpetvCkaG0Td\n xIOiKH8SfQhA0/8V/oLyql7W/Q4talR7fSSujCbu3Fti6Vghh1z5e7jHwDPQariY0R15\n 9675y0//RL2tVdp3IXMhyil9j6N3SilFjwuObGCq2WZefNxZr7rFIB89tdOt33DUVZTi\n NByA==", "X-Gm-Message-State": "AOAM530MaDSf+0Q0Nc6f2Idn6lYl29ucY1Jy4xp2XYD7QcjLOH2ur+ip\n hK+K2YM/w3Ii3Dd+mRyFDN1fSNbS1gOFyb+7", "X-Google-Smtp-Source": "\n ABdhPJyKSxzA9TNPRYCdHZyvbKqkGqowL3HsV5vzCNOkcdT+C1aMbgfxEuW7Vn2yWn3+eOu4RkCxqA==", "X-Received": "by 2002:a63:3403:: with SMTP id b3mr4429935pga.391.1604615772101;\n Thu, 05 Nov 2020 14:36:12 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Luca Boccassi <bluca@debian.org>, Gaetan Rivet <grive@u256.net>", "Date": "Thu, 5 Nov 2020 14:35:57 -0800", "Message-Id": "<20201105223602.5965-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201105223602.5965-1-stephen@networkplumber.org>", "References": "<20200922143202.8755-1-stephen@networkplumber.org>\n <20201105223602.5965-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist\n\tin enum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch renames the enum values in the EAL include files.\nAs a backward compatible temporary migration tool, define\na replacement mapping for old values.\n\nThe old names relating to blacklist and whitelist are replaced\nby block list and allow list, but applications may be using the\nolder compatibility macros. To help with conversion to new names\ncause a message when the compatibility names are used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Luca Boccassi <bluca@debian.org>\nAcked-by: Gaetan Rivet <grive@u256.net>\n---\n lib/librte_eal/common/eal_common_devargs.c | 14 +++++++-------\n lib/librte_eal/include/rte_bus.h | 10 ++++++++--\n lib/librte_eal/include/rte_dev.h | 10 ++++++++--\n lib/librte_eal/include/rte_devargs.h | 10 ++++++++--\n 4 files changed, 31 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 2123773ef840..fcf3d9a3ccb2 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -296,7 +296,7 @@ rte_devargs_insert(struct rte_devargs **da)\n \treturn 0;\n }\n \n-/* store a whitelist parameter for later parsing */\n+/* store in allowed list parameter for later parsing */\n int\n rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n {\n@@ -313,13 +313,13 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \t\tgoto fail;\n \tdevargs->type = devtype;\n \tbus = devargs->bus;\n-\tif (devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI)\n-\t\tdevargs->policy = RTE_DEV_BLACKLISTED;\n+\tif (devargs->type == RTE_DEVTYPE_BLOCKED)\n+\t\tdevargs->policy = RTE_DEV_BLOCKED;\n \tif (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) {\n-\t\tif (devargs->policy == RTE_DEV_WHITELISTED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_WHITELIST;\n-\t\telse if (devargs->policy == RTE_DEV_BLACKLISTED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_BLACKLIST;\n+\t\tif (devargs->policy == RTE_DEV_ALLOWED)\n+\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_ALLOWLIST;\n+\t\telse if (devargs->policy == RTE_DEV_BLOCKED)\n+\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_BLOCKLIST;\n \t}\n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\ndiff --git a/lib/librte_eal/include/rte_bus.h b/lib/librte_eal/include/rte_bus.h\nindex d3034d0edf77..80b154fb982c 100644\n--- a/lib/librte_eal/include/rte_bus.h\n+++ b/lib/librte_eal/include/rte_bus.h\n@@ -215,10 +215,16 @@ typedef int (*rte_bus_sigbus_handler_t)(const void *failure_addr);\n */\n enum rte_bus_scan_mode {\n \tRTE_BUS_SCAN_UNDEFINED,\n-\tRTE_BUS_SCAN_WHITELIST,\n-\tRTE_BUS_SCAN_BLACKLIST,\n+\tRTE_BUS_SCAN_ALLOWLIST,\n+\tRTE_BUS_SCAN_BLOCKLIST,\n };\n \n+/* Backwards compatibility will be removed */\n+#define RTE_BUS_SCAN_WHITELIST \\\n+\tRTE_DEPRECATED(RTE_BUS_SCAN_WHITELIST) RTE_BUS_SCAN_ALLOWLIST\n+#define RTE_BUS_SCAN_BLACKLIST \\\n+\tRTE_DEPRECATED(RTE_BUS_SCAN_BLACKLIST) RTE_BUS_SCAN_BLOCKLIST\n+\n /**\n * A structure used to configure bus operations.\n */\ndiff --git a/lib/librte_eal/include/rte_dev.h b/lib/librte_eal/include/rte_dev.h\nindex 81905b3ae35f..6dd72c11a14a 100644\n--- a/lib/librte_eal/include/rte_dev.h\n+++ b/lib/librte_eal/include/rte_dev.h\n@@ -52,10 +52,16 @@ typedef void (*rte_dev_event_cb_fn)(const char *device_name,\n * Device policies.\n */\n enum rte_dev_policy {\n-\tRTE_DEV_WHITELISTED,\n-\tRTE_DEV_BLACKLISTED,\n+\tRTE_DEV_ALLOWED,\n+\tRTE_DEV_BLOCKED,\n };\n \n+/* Backwards compatibility will be removed */\n+#define RTE_DEV_WHITELISTED \\\n+\tRTE_DEPRECATED(RTE_DEV_WHITELISTED) RTE_DEV_ALLOWED\n+#define RTE_DEV_BLACKLISTED \\\n+\tRTE_DEPRECATED(RTE_DEV_BLACKLISTED) RTE_DEV_BLOCKED\n+\n /**\n * A generic memory resource representation.\n */\ndiff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h\nindex 898efa0d667b..296f19324fae 100644\n--- a/lib/librte_eal/include/rte_devargs.h\n+++ b/lib/librte_eal/include/rte_devargs.h\n@@ -29,11 +29,17 @@ extern \"C\" {\n * Type of generic device\n */\n enum rte_devtype {\n-\tRTE_DEVTYPE_WHITELISTED_PCI,\n-\tRTE_DEVTYPE_BLACKLISTED_PCI,\n+\tRTE_DEVTYPE_ALLOWED,\n+\tRTE_DEVTYPE_BLOCKED,\n \tRTE_DEVTYPE_VIRTUAL,\n };\n \n+/* Backwards compatibility will be removed later */\n+#define RTE_DEVTYPE_WHITELISTED_PCI \\\n+\tRTE_DEPRECATED(RTE_DEVTYPE_WHITELISTED_PCI) RTE_DEVTYPE_ALLOWED\n+#define RTE_DEVTYPE_BLACKLISTED_PCI \\\n+\tRTE_DEPRECATED(RTE_DEVTYPE_BLACKLISTED_PCI) RTE_DEVTYPE_BLOCKED\n+\n /**\n * Structure that stores a device given by the user with its arguments\n *\n", "prefixes": [ "v9", "1/6" ] }