Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84035/?format=api
{ "id": 84035, "url": "http://patchwork.dpdk.org/api/patches/84035/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201112020006.739838-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201112020006.739838-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201112020006.739838-1-haiyue.wang@intel.com", "date": "2020-11-12T02:00:06", "name": "[v1] net/ixgbe: remove the redundant MAC flag check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "01af1ab020d67ebb24863f77a32db88948e73411", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201112020006.739838-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 13821, "url": "http://patchwork.dpdk.org/api/series/13821/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13821", "date": "2020-11-12T02:00:06", "name": "[v1] net/ixgbe: remove the redundant MAC flag check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/13821/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/84035/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/84035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 899B0A09DF;\n\tThu, 12 Nov 2020 03:14:23 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 713B75937;\n\tThu, 12 Nov 2020 03:14:21 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id A690F569B;\n Thu, 12 Nov 2020 03:14:18 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 18:14:12 -0800", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.27])\n by orsmga005.jf.intel.com with ESMTP; 11 Nov 2020 18:14:09 -0800" ], "IronPort-SDR": [ "\n AchGhiJg+f1tKz1jBJV4cr8f4cD4RbGYkP6L2pLDjTZekyh4oz9BBpMMtax7ra74SaBH0sf231\n dywetjXPk4pQ==", "\n FG5VJena1tLLNcROBV1bYZleVsYmyqZPUbrmEbi7ZE1fLJ47ATQq51nag0WrIEqCPOF0vhwcmM\n 8saeRsETa+YQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9802\"; a=\"170413847\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"170413847\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"542055782\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, qi.z.zhang@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, stable@dpdk.org,\n Jeff Guo <jia.guo@intel.com>, Wei Zhao <wei.zhao1@intel.com>,\n Beilei Xing <beilei.xing@intel.com>, Wei Dai <wei.dai@intel.com>,\n Wenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Thu, 12 Nov 2020 10:00:06 +0800", "Message-Id": "<20201112020006.739838-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the\nfirst error message \"Not supported by ethertype filter\" which is not so\nspecific, and keep the error message \"mac compare is unsupported\" which\naligns to the definition of RTE_ETHTYPE_FLAGS_MAC.\n\nFixes: eb3539fc8550 (\"net/ixgbe: parse ethertype filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ixgbe/ixgbe_flow.c | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex dff04c462c..39f6ed73f6 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev,\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Ixgbe doesn't support MAC address. */\n-\tif (filter->flags & RTE_ETHTYPE_FLAGS_MAC) {\n-\t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n-\t\trte_flow_error_set(error, EINVAL,\n-\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\tNULL, \"Not supported by ethertype filter\");\n-\t\treturn -rte_errno;\n-\t}\n-\n \tif (filter->queue >= dev->data->nb_rx_queues) {\n \t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n \t\trte_flow_error_set(error, EINVAL,\n", "prefixes": [ "v1" ] }