Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84821/?format=api
{ "id": 84821, "url": "http://patchwork.dpdk.org/api/patches/84821/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201208201134.47844-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201208201134.47844-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201208201134.47844-2-ajit.khaparde@broadcom.com", "date": "2020-12-08T20:11:18", "name": "[01/17] net/bnxt: fix RX rings in RSS redirection table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a87abcf7728b96d1b75901575cfb2cf7d6a0c580", "submitter": { "id": 501, "url": "http://patchwork.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201208201134.47844-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14211, "url": "http://patchwork.dpdk.org/api/series/14211/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14211", "date": "2020-12-08T20:11:17", "name": "fixes and refactoring changes for bnxt", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14211/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/84821/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/84821/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70C60A09E9;\n\tTue, 8 Dec 2020 21:12:06 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 80788C922;\n\tTue, 8 Dec 2020 21:11:45 +0100 (CET)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180]) by dpdk.org (Postfix) with ESMTP id 98B8FA3\n for <dev@dpdk.org>; Tue, 8 Dec 2020 21:11:42 +0100 (CET)", "by mail-pl1-f180.google.com with SMTP id x15so7557691pll.2\n for <dev@dpdk.org>; Tue, 08 Dec 2020 12:11:42 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.38\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 08 Dec 2020 12:11:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=nO7YXD+wpLvax3o8JJncR5AxdXEhH7JUi6HlOIpmbxU=;\n b=AW9OhXgwdRFeH0L5ruJATutQXCSDc1ULRRpteYOwXCRXpoh6AfGKW0c5TS1bgj1CKD\n 1i9tNXSNNSzFX1eEoC4B1Gl20bgErC1cJoTu2ir7qfbEMFxJlCvUmQMMrnpbHTviaU0C\n IqfRDlK4aPHRBwaAtoOF4bDi1gPbgzM/E1KJw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=nO7YXD+wpLvax3o8JJncR5AxdXEhH7JUi6HlOIpmbxU=;\n b=iqiqKLXc9a0tFBoBvVs373PgmddzIQbr7sl/CFnaorWXsN3I4Wr+SO4fXub9pQ8eSr\n 9iqYrcwXbL3KKVEVg4z3isCOeWrH2gSHsyh9gxsCSYKDexe/0TOZmbOLoZE4/JV+f4lw\n S0J7hzxWibzlqoPeRigNfx18Wo2xScBR0jHQ8txnhb9v3TJ6QHeyTka8vDUZH2kmtxgc\n V3fWrVVoxWoMMTE+WlxpDQasX/x/XfKS62nqzjohV98tEIzfgabLEuzvnJsN2Z7JxUMD\n zeY9fZ90faTwC4bHWtKFC47To33kRNY0P7/IlaCt+RYkxB6oon2ipE000c2B9m1Ra6np\n zEWw==", "X-Gm-Message-State": "AOAM530ARkNRzREw7009PpYFTasAKphu8bkQ2ASZu6OjSWw3L7+dO5qX\n bRWNmf1C7MJHchliu1qqv3MCifgrP6OcWdEEdYGwHXMRSVJiiL8Ck3VBkHf43pbzbWG1NggURr8\n FJiOBgGZSx2b3e2jkLnl86jZkTcVF0lCKX5N/xPIHh0Om/krQdvit2lEwshr8W9KKqQ==", "X-Google-Smtp-Source": "\n ABdhPJyHjxI+H/z1ji2dNFpemgVEvy9wuiwRi7/nZeUi9peGiHPUm2vEuuyBk/S8hfHceT3UWLuX4Q==", "X-Received": "by 2002:a17:902:eb0c:b029:db:c0d6:6289 with SMTP id\n l12-20020a170902eb0cb02900dbc0d66289mr3763004plb.12.1607458300093;\n Tue, 08 Dec 2020 12:11:40 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Samik Gupta <samik.gupta@broadcom.com>,\n\tstable@dpdk.org", "Date": "Tue, 8 Dec 2020 12:11:18 -0800", "Message-Id": "<20201208201134.47844-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "References": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 01/17] net/bnxt: fix RX rings in RSS redirection\n\ttable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Samik Gupta <samik.gupta@broadcom.com>\n\nThis commit introduces a limit on the number of RX rings included in\nthe RSS redirection table to a value no larger than the size supported\nby Thor as defined by BNXT_RSS_TBL_SIZE_THOR.\n\nFixes: d819382543f3 (\"net/bnxt: add RSS redirection table operations\")\nCc: stable@dpdk.org\n\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Samik Gupta <samik.gupta@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 15 +++++++++++++--\n 2 files changed, 14 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 90ced972c..9bd4f1da9 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -389,7 +389,7 @@ struct bnxt_coal {\n #define DBR_TYPE_NQ\t\t\t\t(0xaULL << 60)\n #define DBR_TYPE_NQ_ARM\t\t\t\t(0xbULL << 60)\n \n-#define BNXT_RSS_TBL_SIZE_THOR\t\t512\n+#define BNXT_RSS_TBL_SIZE_THOR\t\t512U\n #define BNXT_RSS_ENTRIES_PER_CTX_THOR\t64\n #define BNXT_MAX_RSS_CTXTS_THOR \\\n \t(BNXT_RSS_TBL_SIZE_THOR / BNXT_RSS_ENTRIES_PER_CTX_THOR)\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 81c8f8d79..c363c8427 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -207,12 +207,15 @@ int is_bnxt_in_error(struct bnxt *bp)\n \n static uint16_t bnxt_rss_ctxts(const struct bnxt *bp)\n {\n+\tunsigned int num_rss_rings = RTE_MIN(bp->rx_nr_rings,\n+\t\t\t\t\t BNXT_RSS_TBL_SIZE_THOR);\n+\n \tif (!BNXT_CHIP_THOR(bp))\n \t\treturn 1;\n \n-\treturn RTE_ALIGN_MUL_CEIL(bp->rx_nr_rings,\n+\treturn RTE_ALIGN_MUL_CEIL(num_rss_rings,\n \t\t\t\t BNXT_RSS_ENTRIES_PER_CTX_THOR) /\n-\t\t\t\t BNXT_RSS_ENTRIES_PER_CTX_THOR;\n+\t\t\t\t BNXT_RSS_ENTRIES_PER_CTX_THOR;\n }\n \n uint16_t bnxt_rss_hash_tbl_size(const struct bnxt *bp)\n@@ -424,6 +427,14 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id)\n \tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) {\n \t\tint j, nr_ctxs = bnxt_rss_ctxts(bp);\n \n+\t\tif (bp->rx_nr_rings > BNXT_RSS_TBL_SIZE_THOR) {\n+\t\t\tPMD_DRV_LOG(ERR, \"RxQ cnt %d > reta_size %d\\n\",\n+\t\t\t\t bp->rx_nr_rings, BNXT_RSS_TBL_SIZE_THOR);\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Only queues 0-%d will be in RSS table\\n\",\n+\t\t\t\t BNXT_RSS_TBL_SIZE_THOR - 1);\n+\t\t}\n+\n \t\trc = 0;\n \t\tfor (j = 0; j < nr_ctxs; j++) {\n \t\t\trc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, j);\n", "prefixes": [ "01/17" ] }