Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 84996,
    "url": "http://patchwork.dpdk.org/api/patches/84996/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dts/patch/20201211071250.26875-1-yanx.xia@intel.com/",
    "project": {
        "id": 3,
        "url": "http://patchwork.dpdk.org/api/projects/3/?format=api",
        "name": "DTS",
        "link_name": "dts",
        "list_id": "dts.dpdk.org",
        "list_email": "dts@dpdk.org",
        "web_url": "",
        "scm_url": "git://dpdk.org/tools/dts",
        "webscm_url": "http://git.dpdk.org/tools/dts/",
        "list_archive_url": "https://inbox.dpdk.org/dts",
        "list_archive_url_format": "https://inbox.dpdk.org/dts/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201211071250.26875-1-yanx.xia@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dts/20201211071250.26875-1-yanx.xia@intel.com",
    "date": "2020-12-11T07:12:50",
    "name": "[V1] framework:Fix run dts on python 3.8 SyntaxWarning",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "d9b86d125ff5f768288cf1b594fc1b09eeae7a82",
    "submitter": {
        "id": 2034,
        "url": "http://patchwork.dpdk.org/api/people/2034/?format=api",
        "name": "Yan Xia",
        "email": "yanx.xia@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dts/patch/20201211071250.26875-1-yanx.xia@intel.com/mbox/",
    "series": [
        {
            "id": 14250,
            "url": "http://patchwork.dpdk.org/api/series/14250/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=14250",
            "date": "2020-12-11T07:12:50",
            "name": "[V1] framework:Fix run dts on python 3.8 SyntaxWarning",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/14250/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/84996/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/84996/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dts-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4A59A04DB;\n\tFri, 11 Dec 2020 08:10:05 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 67719AC9A;\n\tFri, 11 Dec 2020 08:10:04 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 411D037B7\n for <dts@dpdk.org>; Fri, 11 Dec 2020 08:10:02 +0100 (CET)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2020 23:10:01 -0800",
            "from unknown (HELO localhost.localdomain) ([10.240.183.80])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2020 23:10:00 -0800"
        ],
        "IronPort-SDR": [
            "\n B4/fwX8uj7PaiKFM3pcT3AaRq0UACvTITncQoSdoJ2TW6EkYxjNew+a00EWRkLP9f6+irLjIBe\n tfGo1jgx47zA==",
            "\n C/sc/DGKtN1yGJ9QefLp5XfETA6S5dIKqRC3kZiuBQHV0YrgkBY1pPjXMIU78/yx7hX5iRMr75\n cElhFR7F2rPg=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9831\"; a=\"171826434\"",
            "E=Sophos;i=\"5.78,410,1599548400\"; d=\"scan'208\";a=\"171826434\"",
            "E=Sophos;i=\"5.78,410,1599548400\"; d=\"scan'208\";a=\"545099690\""
        ],
        "From": "Xia Yan <yanx.xia@intel.com>",
        "To": "dts@dpdk.org",
        "Cc": "Xia Yan <yanx.xia@intel.com>",
        "Date": "Fri, 11 Dec 2020 15:12:50 +0800",
        "Message-Id": "<20201211071250.26875-1-yanx.xia@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dts] [PATCH V1] framework:Fix run dts on python 3.8 SyntaxWarning",
        "X-BeenThere": "dts@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
        "List-Post": "<mailto:dts@dpdk.org>",
        "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dts-bounces@dpdk.org",
        "Sender": "\"dts\" <dts-bounces@dpdk.org>"
    },
    "content": "modify dut,logger,packet,project_dpdk,settings,tester and virt_resource\nunder the framework to run dts python 3.8 SyntaxWarning \n\nSigned-off-by: Xia Yan <yanx.xia@intel.com>\n---\n framework/dut.py           | 2 +-\n framework/logger.py        | 2 +-\n framework/packet.py        | 4 ++--\n framework/project_dpdk.py  | 4 ++--\n framework/settings.py      | 2 +-\n framework/tester.py        | 2 +-\n framework/virt_resource.py | 4 ++--\n 7 files changed, 10 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/framework/dut.py b/framework/dut.py\nindex dcf833b4..4c732ec9 100644\n--- a/framework/dut.py\n+++ b/framework/dut.py\n@@ -573,7 +573,7 @@ class Dut(Crb):\n         \"\"\"\n         Setup Freebsd hugepages.\n         \"\"\"\n-        if hugepages is -1:\n+        if hugepages == -1:\n             hugepages = 4096\n \n         num_buffers = hugepages / 1024\ndiff --git a/framework/logger.py b/framework/logger.py\nindex 4600c5fc..63e1d831 100644\n--- a/framework/logger.py\n+++ b/framework/logger.py\n@@ -465,7 +465,7 @@ class LogParser(object):\n \n     def __dict_log(self, lvl_name, msg):\n         tmp = {}\n-        if lvl_name is not '':\n+        if lvl_name != '':\n             tmp[lvl_name] = msg\n         return tmp\n \ndiff --git a/framework/packet.py b/framework/packet.py\nindex 7d974db0..1c325ff2 100644\n--- a/framework/packet.py\n+++ b/framework/packet.py\n@@ -209,7 +209,7 @@ class scapy(object):\n     def strip_vlan(self, element, p_index=0):\n         value = None\n \n-        if self.pkts[p_index].haslayer('Dot1Q') is 0:\n+        if self.pkts[p_index].haslayer('Dot1Q') == 0:\n             return None\n \n         if element == 'vlan':\n@@ -227,7 +227,7 @@ class scapy(object):\n     def strip_etag(self, element, p_index=0):\n         value = None\n \n-        if self.pkts[p_index].haslayer('Dot1BR') is 0:\n+        if self.pkts[p_index].haslayer('Dot1BR') == 0:\n             return None\n \n         if element == 'ECIDbase':\ndiff --git a/framework/project_dpdk.py b/framework/project_dpdk.py\nindex 259282f4..583fcd6c 100644\n--- a/framework/project_dpdk.py\n+++ b/framework/project_dpdk.py\n@@ -308,7 +308,7 @@ class DPDKdut(Dut):\n                 if 'i386' in cur_path:\n                     pkg_path = cur_path\n                     break\n-            assert(pkg_path is not ''), \"please make sure you env have the i386 pkg-config path\"\n+            assert(pkg_path != ''), \"please make sure you env have the i386 pkg-config path\"\n \n             self.send_expect(\"export CFLAGS=-m32\", \"# \")\n             self.send_expect(\"export PKG_CONFIG_LIBDIR=%s\" % pkg_path, \"# \")\n@@ -545,7 +545,7 @@ class DPDKdut(Dut):\n                 if 'i386' in cur_path:\n                     pkg_path = cur_path\n                     break\n-            assert(pkg_path is not ''), \"please make sure you env have the i386 pkg-config path\"\n+            assert(pkg_path != ''), \"please make sure you env have the i386 pkg-config path\"\n \n             self.send_expect(\"export CFLAGS=-m32\", \"# \", alt_session=True)\n             self.send_expect(\"export PKG_CONFIG_LIBDIR=%s\" % pkg_path, \"# \", alt_session=True)\ndiff --git a/framework/settings.py b/framework/settings.py\nindex 2b6a3ce3..c5edbb7a 100644\n--- a/framework/settings.py\n+++ b/framework/settings.py\n@@ -385,7 +385,7 @@ def accepted_nic(pci_id):\n     if pci_id not in list(NICS.values()):\n         return False\n \n-    if nic is 'any':\n+    if nic == 'any':\n         return True\n \n     else:\ndiff --git a/framework/tester.py b/framework/tester.py\nindex b2cbdb0d..ec233b8a 100644\n--- a/framework/tester.py\n+++ b/framework/tester.py\n@@ -354,7 +354,7 @@ class Tester(Crb):\n         try:\n             for port_info in self.ports_info:\n                 nic_type = port_info.get('type') \n-                if nic_type is not 'trex':\n+                if nic_type != 'trex':\n                     continue\n                 pci_bus = port_info.get('pci')\n                 port_inst = port_info.get('port')\ndiff --git a/framework/virt_resource.py b/framework/virt_resource.py\nindex 4356ee50..6ae2a28b 100644\n--- a/framework/virt_resource.py\n+++ b/framework/virt_resource.py\n@@ -83,7 +83,7 @@ class VirtResource(object):\n     def __port_on_socket(self, pci, socket):\n         for port in self.ports_info:\n             if port['pci'] == pci:\n-                if socket is -1:\n+                if socket == -1:\n                     return True\n \n                 if port['numa'] == socket:\n@@ -118,7 +118,7 @@ class VirtResource(object):\n     def __core_on_socket(self, core, socket):\n         for dut_core in self.dut.cores:\n             if int(dut_core['thread']) == core:\n-                if socket is -1:\n+                if socket == -1:\n                     return True\n \n                 if int(dut_core['socket']) == socket:\n",
    "prefixes": [
        "V1"
    ]
}