Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85330/?format=api
{ "id": 85330, "url": "http://patchwork.dpdk.org/api/patches/85330/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/40e9041c9824228b5a01e4c71762a34cc6d68ad9.1608213657.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<40e9041c9824228b5a01e4c71762a34cc6d68ad9.1608213657.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/40e9041c9824228b5a01e4c71762a34cc6d68ad9.1608213657.git.anatoly.burakov@intel.com", "date": "2020-12-17T14:05:34", "name": "[v12,04/11] eal: remove sync version of power monitor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b19ba32d9bff94cb4ba7f66d1482b05bbcec2592", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/40e9041c9824228b5a01e4c71762a34cc6d68ad9.1608213657.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 14349, "url": "http://patchwork.dpdk.org/api/series/14349/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14349", "date": "2020-12-17T14:05:30", "name": "Add PMD power management", "version": 12, "mbox": "http://patchwork.dpdk.org/series/14349/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/85330/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/85330/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8E37A09F6;\n\tThu, 17 Dec 2020 15:08:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF93CCA4B;\n\tThu, 17 Dec 2020 15:06:25 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 07C38CA24\n for <dev@dpdk.org>; Thu, 17 Dec 2020 15:06:17 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 06:05:52 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2020 06:05:49 -0800" ], "IronPort-SDR": [ "\n 6tDSHGvDAPOZuPs7UaD7ewHtDQoMhUUvjgyMZpOQM597kNbYmg/c9IlA0kXLcc14s1bhjeGQ2c\n gMOjO2cUMEqg==", "\n so8lHKcI1Plb6+kxtKEGRMCrZ3cPlW3POKpYD9bw2Q8YSwsaXyk1LPawnRrhPlivctQTiK0AEv\n O/ckwjqUxftg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9837\"; a=\"175398798\"", "E=Sophos;i=\"5.78,428,1599548400\"; d=\"scan'208\";a=\"175398798\"", "E=Sophos;i=\"5.78,428,1599548400\"; d=\"scan'208\";a=\"557887263\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Jan Viktorin <viktorin@rehivetech.com>,\n David Christensen <drc@linux.vnet.ibm.com>, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>, thomas@monjalon.net,\n gage.eads@intel.com, timothy.mcdaniel@intel.com, david.hunt@intel.com,\n chris.macnamara@intel.com", "Date": "Thu, 17 Dec 2020 14:05:34 +0000", "Message-Id": "\n <40e9041c9824228b5a01e4c71762a34cc6d68ad9.1608213657.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1608213657.git.anatoly.burakov@intel.com>", "<cover.1608213657.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1608213657.git.anatoly.burakov@intel.com>", "<1604315406-27669-1-git-send-email-liang.j.ma@intel.com>\n <cover.1608213657.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v12 04/11] eal: remove sync version of power\n\tmonitor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the \"sync\" version of power monitor intrinsic is supposed to\nbe used for purposes of waking up a sleeping core. However, there are\nbetter ways to achieve the same result, so remove the unneeded function.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n .../arm/include/rte_power_intrinsics.h | 12 -----\n .../include/generic/rte_power_intrinsics.h | 34 --------------\n .../ppc/include/rte_power_intrinsics.h | 12 -----\n lib/librte_eal/version.map | 1 -\n lib/librte_eal/x86/rte_power_intrinsics.c | 46 -------------------\n 5 files changed, 105 deletions(-)", "diff": "diff --git a/lib/librte_eal/arm/include/rte_power_intrinsics.h b/lib/librte_eal/arm/include/rte_power_intrinsics.h\nindex 76a5fa5234..27869251a8 100644\n--- a/lib/librte_eal/arm/include/rte_power_intrinsics.h\n+++ b/lib/librte_eal/arm/include/rte_power_intrinsics.h\n@@ -24,18 +24,6 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \tRTE_SET_USED(tsc_timestamp);\n }\n \n-/**\n- * This function is not supported on ARM.\n- */\n-void\n-rte_power_monitor_sync(const struct rte_power_monitor_cond *pmc,\n-\t\tconst uint64_t tsc_timestamp, rte_spinlock_t *lck)\n-{\n-\tRTE_SET_USED(pmc);\n-\tRTE_SET_USED(tsc_timestamp);\n-\tRTE_SET_USED(lck);\n-}\n-\n /**\n * This function is not supported on ARM.\n */\ndiff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h b/lib/librte_eal/include/generic/rte_power_intrinsics.h\nindex 00c670cb50..a6f1955996 100644\n--- a/lib/librte_eal/include/generic/rte_power_intrinsics.h\n+++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h\n@@ -57,40 +57,6 @@ __rte_experimental\n void rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \t\tconst uint64_t tsc_timestamp);\n \n-/**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n- * Monitor specific address for changes. This will cause the CPU to enter an\n- * architecture-defined optimized power state until either the specified\n- * memory address is written to, a certain TSC timestamp is reached, or other\n- * reasons cause the CPU to wake up.\n- *\n- * Additionally, an `expected` 64-bit value and 64-bit mask are provided. If\n- * mask is non-zero, the current value pointed to by the `p` pointer will be\n- * checked against the expected value, and if they match, the entering of\n- * optimized power state may be aborted.\n- *\n- * This call will also lock a spinlock on entering sleep, and release it on\n- * waking up the CPU.\n- *\n- * @warning It is responsibility of the user to check if this function is\n- * supported at runtime using `rte_cpu_get_intrinsics_support()` API call.\n- *\n- * @param pmc\n- * The monitoring condition structure.\n- * @param tsc_timestamp\n- * Maximum TSC timestamp to wait for. Note that the wait behavior is\n- * architecture-dependent.\n- * @param lck\n- * A spinlock that must be locked before entering the function, will be\n- * unlocked while the CPU is sleeping, and will be locked again once the CPU\n- * wakes up.\n- */\n-__rte_experimental\n-void rte_power_monitor_sync(const struct rte_power_monitor_cond *pmc,\n-\t\tconst uint64_t tsc_timestamp, rte_spinlock_t *lck);\n-\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice\ndiff --git a/lib/librte_eal/ppc/include/rte_power_intrinsics.h b/lib/librte_eal/ppc/include/rte_power_intrinsics.h\nindex cff0996770..248d1f4a23 100644\n--- a/lib/librte_eal/ppc/include/rte_power_intrinsics.h\n+++ b/lib/librte_eal/ppc/include/rte_power_intrinsics.h\n@@ -24,18 +24,6 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \tRTE_SET_USED(tsc_timestamp);\n }\n \n-/**\n- * This function is not supported on PPC64.\n- */\n-void\n-rte_power_monitor_sync(const struct rte_power_monitor_cond *pmc,\n-\t\tconst uint64_t tsc_timestamp, rte_spinlock_t *lck)\n-{\n-\tRTE_SET_USED(pmc);\n-\tRTE_SET_USED(tsc_timestamp);\n-\tRTE_SET_USED(lck);\n-}\n-\n /**\n * This function is not supported on PPC64.\n */\ndiff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map\nindex 31bf76ae81..20945b1efa 100644\n--- a/lib/librte_eal/version.map\n+++ b/lib/librte_eal/version.map\n@@ -406,7 +406,6 @@ EXPERIMENTAL {\n \n \t# added in 21.02\n \trte_power_monitor;\n-\trte_power_monitor_sync;\n \trte_power_pause;\n };\n \ndiff --git a/lib/librte_eal/x86/rte_power_intrinsics.c b/lib/librte_eal/x86/rte_power_intrinsics.c\nindex 3e224f5ac7..a9cd1afe9d 100644\n--- a/lib/librte_eal/x86/rte_power_intrinsics.c\n+++ b/lib/librte_eal/x86/rte_power_intrinsics.c\n@@ -67,52 +67,6 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \t\t\t \"a\"(tsc_l), \"d\"(tsc_h));\n }\n \n-/**\n- * This function uses UMONITOR/UMWAIT instructions and will enter C0.2 state.\n- * For more information about usage of these instructions, please refer to\n- * Intel(R) 64 and IA-32 Architectures Software Developer's Manual.\n- */\n-void\n-rte_power_monitor_sync(const struct rte_power_monitor_cond *pmc,\n-\t\tconst uint64_t tsc_timestamp, rte_spinlock_t *lck)\n-{\n-\tconst uint32_t tsc_l = (uint32_t)tsc_timestamp;\n-\tconst uint32_t tsc_h = (uint32_t)(tsc_timestamp >> 32);\n-\n-\t/* prevent user from running this instruction if it's not supported */\n-\tif (!wait_supported)\n-\t\treturn;\n-\n-\t/*\n-\t * we're using raw byte codes for now as only the newest compiler\n-\t * versions support this instruction natively.\n-\t */\n-\n-\t/* set address for UMONITOR */\n-\tasm volatile(\".byte 0xf3, 0x0f, 0xae, 0xf7;\"\n-\t\t\t:\n-\t\t\t: \"D\"(pmc->addr));\n-\n-\tif (pmc->mask) {\n-\t\tconst uint64_t cur_value = __get_umwait_val(\n-\t\t\t\tpmc->addr, pmc->data_sz);\n-\t\tconst uint64_t masked = cur_value & pmc->mask;\n-\n-\t\t/* if the masked value is already matching, abort */\n-\t\tif (masked == pmc->val)\n-\t\t\treturn;\n-\t}\n-\trte_spinlock_unlock(lck);\n-\n-\t/* execute UMWAIT */\n-\tasm volatile(\".byte 0xf2, 0x0f, 0xae, 0xf7;\"\n-\t\t\t: /* ignore rflags */\n-\t\t\t: \"D\"(0), /* enter C0.2 */\n-\t\t\t \"a\"(tsc_l), \"d\"(tsc_h));\n-\n-\trte_spinlock_lock(lck);\n-}\n-\n /**\n * This function uses TPAUSE instruction and will enter C0.2 state. For more\n * information about usage of this instruction, please refer to Intel(R) 64 and\n", "prefixes": [ "v12", "04/11" ] }