Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86453/?format=api
{ "id": 86453, "url": "http://patchwork.dpdk.org/api/patches/86453/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210113082805.5945-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210113082805.5945-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210113082805.5945-1-olivier.matz@6wind.com", "date": "2021-01-13T08:28:06", "name": "[v2] eal: fix errno on service cores init failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2334bf75b6c8604d31af820cf35ebdf0a8000509", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210113082805.5945-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 14684, "url": "http://patchwork.dpdk.org/api/series/14684/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14684", "date": "2021-01-13T08:28:06", "name": "[v2] eal: fix errno on service cores init failure", "version": 2, "mbox": "http://patchwork.dpdk.org/series/14684/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/86453/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/86453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2B190A04B5;\n\tWed, 13 Jan 2021 09:29:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AF27D140E7D;\n\tWed, 13 Jan 2021 09:29:20 +0100 (CET)", "from mail-wm1-f48.google.com (mail-wm1-f48.google.com\n [209.85.128.48])\n by mails.dpdk.org (Postfix) with ESMTP id 46D85140E74\n for <dev@dpdk.org>; Wed, 13 Jan 2021 09:29:19 +0100 (CET)", "by mail-wm1-f48.google.com with SMTP id y187so765513wmd.3\n for <dev@dpdk.org>; Wed, 13 Jan 2021 00:29:19 -0800 (PST)", "from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id d191sm1740926wmd.24.2021.01.13.00.29.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 13 Jan 2021 00:29:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=y1dd3JyjM2t2UuADfDBFZIvqFz50JPn941JptK8amGs=;\n b=QuBi003xmCaiwm2NV2bgI8Xkt8g/Gi0Uu3G7d2CI5i+g6yb2H+i0XXoG9oozB3NsMI\n 6bWYH8Vk2cwzVbwuPKTKG83B6dG+IRpdNMeX3zO6l1X0itF8mnGPSQk11oCmghBEugeQ\n 1W9UgBtmuAoHi00cBiHM7T2IExm0ENTV0/SZRekQXIOJs+w2R5aanveOxLeKhaCKqqew\n 6MhqrnacPD4TXlojVOedPAa3WJNcWhqXgyH7Cvzos3D/gl0XAYI++GsWPAp/wkjCL2Ug\n YTP2PfLg+bEe+IXHZ63o4BvmmHx8hiXx7jGUQzkaLjugTKYO305IaGeIhIpyHSO3DkTe\n nRxg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=y1dd3JyjM2t2UuADfDBFZIvqFz50JPn941JptK8amGs=;\n b=nT13u2exS/ctQb65oWJn/LBKDBU/HzG1YHpAyyt2G2Se0ZyX9x19tE6aP4QtAJIWCG\n cDWVM02JIonISaVxTcXgKkbt9EFWOLdtW4+yRj7xnqvNU7bPUtPuzfRdD6sHWS4vumVi\n BNTnJbbkESoCr/zsF1GqzWYqq8e2GbR8VGfm/Wzs7ZwondsWUBUQtNMzbHY4yWW5WGsN\n ka0VNg4Ukzvklyy+wmPGp6Yv/wuHf9SIPjrXAdncuV40jVjHwFfVvQlS84IOUtfGsKC4\n ZGG3aqRsN4FRtm3+0c24a/BIPz+7lR5WlGI1T+UjuX2d3XccHoy04t8kq6bDcbQNea5G\n g0lA==", "X-Gm-Message-State": "AOAM531z5WvNdWIhexxj4W17r/wjIil9nJmWFfzt/uIneS/o4m2B3aXE\n 9k5bsIvOIv35LCN3wu/QKJlUdqHYKVkGGw==", "X-Google-Smtp-Source": "\n ABdhPJx05U7cLZSmv0rUV+T5tqen09OSUlMz6AwfBPfdBqXo8vIGWYeGGjBOvza26LEBuFrqQ3I3jQ==", "X-Received": "by 2002:a1c:6383:: with SMTP id x125mr1044543wmb.46.1610526558701;\n Wed, 13 Jan 2021 00:29:18 -0800 (PST)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, harry.van.haaren@intel.com,\n jerin.jacob@caviumnetworks.com, stable@dpdk.org", "Date": "Wed, 13 Jan 2021 09:28:06 +0100", "Message-Id": "<20210113082805.5945-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201126142523.25198-1-olivier.matz@6wind.com>", "References": "<20201126142523.25198-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] eal: fix errno on service cores init failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when rte_service_init() fails at initialization, we\nsee the following message:\n\n Cannot init EAL: Exec format error\n\nThis error code does describe the real issue. Instead, use the error\ncode returned by the function.\n\nFixes: e39824500825 (\"service: initialize with EAL\")\nCc: stable@dpdk.org\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nAcked-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n\nv2\n* rebase on top of main branch\n* add same change for windows\n\n lib/librte_eal/freebsd/eal.c | 4 ++--\n lib/librte_eal/linux/eal.c | 4 ++--\n lib/librte_eal/windows/eal.c | 6 ++++--\n 3 files changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c\nindex d6ea023750..51478358c7 100644\n--- a/lib/librte_eal/freebsd/eal.c\n+++ b/lib/librte_eal/freebsd/eal.c\n@@ -906,7 +906,7 @@ rte_eal_init(int argc, char **argv)\n \tret = rte_service_init();\n \tif (ret) {\n \t\trte_eal_init_alert(\"rte_service_init() failed\");\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = -ret;\n \t\treturn -1;\n \t}\n \n@@ -922,7 +922,7 @@ rte_eal_init(int argc, char **argv)\n \t */\n \tret = rte_service_start_with_defaults();\n \tif (ret < 0 && ret != -ENOTSUP) {\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = -ret;\n \t\treturn -1;\n \t}\n \ndiff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c\nindex a4161be630..32b48c3de9 100644\n--- a/lib/librte_eal/linux/eal.c\n+++ b/lib/librte_eal/linux/eal.c\n@@ -1273,7 +1273,7 @@ rte_eal_init(int argc, char **argv)\n \tret = rte_service_init();\n \tif (ret) {\n \t\trte_eal_init_alert(\"rte_service_init() failed\");\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = -ret;\n \t\treturn -1;\n \t}\n \n@@ -1295,7 +1295,7 @@ rte_eal_init(int argc, char **argv)\n \t */\n \tret = rte_service_start_with_defaults();\n \tif (ret < 0 && ret != -ENOTSUP) {\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = -ret;\n \t\treturn -1;\n \t}\n \ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex 105549de1b..1e5f6576f0 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -264,6 +264,7 @@ rte_eal_init(int argc, char **argv)\n \tconst struct rte_config *config = rte_eal_get_configuration();\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n+\tint ret;\n \n \trte_eal_log_init(NULL, 0);\n \n@@ -387,9 +388,10 @@ rte_eal_init(int argc, char **argv)\n \t}\n \n \t/* Initialize services so drivers can register services during probe. */\n-\tif (rte_service_init()) {\n+\tret = rte_service_init();\n+\tif (ret) {\n \t\trte_eal_init_alert(\"rte_service_init() failed\");\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = -ret;\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "v2" ] }