Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86538/?format=api
{ "id": 86538, "url": "http://patchwork.dpdk.org/api/patches/86538/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210114070830.707550-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114070830.707550-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114070830.707550-2-feifei.wang2@arm.com", "date": "2021-01-14T07:08:26", "name": "[v1,1/5] app/eventdev: fix SMP barrier bugs for perf test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "06f8c7bee4988f367f1008dc115e5fff6a17cd4c", "submitter": { "id": 1771, "url": "http://patchwork.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210114070830.707550-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14718, "url": "http://patchwork.dpdk.org/api/series/14718/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14718", "date": "2021-01-14T07:08:25", "name": "refactor smp barriers in app/eventdev", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14718/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/86538/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/86538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82704A0A02;\n\tThu, 14 Jan 2021 08:09:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A511F140F3A;\n\tThu, 14 Jan 2021 08:09:07 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 48788140F35;\n Thu, 14 Jan 2021 08:09:06 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB23B1FB;\n Wed, 13 Jan 2021 23:09:05 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 257C63F719;\n Wed, 13 Jan 2021 23:09:02 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>", "Cc": "dev@dpdk.org, Honnappa.Nagarahalli@arm.com, nd@arm.com,\n Feifei Wang <feifei.wang2@arm.com>, stable@dpdk.org,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Thu, 14 Jan 2021 15:08:26 +0800", "Message-Id": "<20210114070830.707550-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210114070830.707550-1-feifei.wang2@arm.com>", "References": "<20210114070830.707550-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/5] app/eventdev: fix SMP barrier bugs for\n perf test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes RTE SMP barrier bugs for the perf test of eventdev.\n\nFor the \"perf_process_last_stage\" function, wmb after storing\nprocessed_pkts should be moved before it. This is because the worker\nlcore should ensure it has really finished data processing, e.g. event\nstored into buffers, before the shared variables \"w->processed_pkts\"are\nstored.\n\nFor the \"perf_process_last_stage_latency\", on the one hand, the wmb\nshould be moved before storing into \"w->processed_pkts\". The reason is\nthe same as above. But on the other hand, for \"w->latency\", wmb is\nunnecessary due to data dependency.\n\nFixes: 2369f73329f8 (\"app/testeventdev: add perf queue worker functions\")\nCc: jerinj@marvell.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test-eventdev/test_perf_common.h | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-eventdev/test_perf_common.h b/app/test-eventdev/test_perf_common.h\nindex ff9705df8..e7233e5a5 100644\n--- a/app/test-eventdev/test_perf_common.h\n+++ b/app/test-eventdev/test_perf_common.h\n@@ -97,8 +97,13 @@ perf_process_last_stage(struct rte_mempool *const pool,\n \t\tvoid *bufs[], int const buf_sz, uint8_t count)\n {\n \tbufs[count++] = ev->event_ptr;\n-\tw->processed_pkts++;\n+\n+\t/* wmb here ensures event_prt is stored before\n+\t * updating the number of processed packets\n+\t * for worker lcores\n+\t */\n \trte_smp_wmb();\n+\tw->processed_pkts++;\n \n \tif (unlikely(count == buf_sz)) {\n \t\tcount = 0;\n@@ -116,6 +121,12 @@ perf_process_last_stage_latency(struct rte_mempool *const pool,\n \tstruct perf_elt *const m = ev->event_ptr;\n \n \tbufs[count++] = ev->event_ptr;\n+\n+\t/* wmb here ensures event_prt is stored before\n+\t * updating the number of processed packets\n+\t * for worker lcores\n+\t */\n+\trte_smp_wmb();\n \tw->processed_pkts++;\n \n \tif (unlikely(count == buf_sz)) {\n@@ -127,7 +138,6 @@ perf_process_last_stage_latency(struct rte_mempool *const pool,\n \t}\n \n \tw->latency += latency;\n-\trte_smp_wmb();\n \treturn count;\n }\n \n", "prefixes": [ "v1", "1/5" ] }