Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86543/?format=api
{ "id": 86543, "url": "http://patchwork.dpdk.org/api/patches/86543/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210114070830.707550-6-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114070830.707550-6-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114070830.707550-6-feifei.wang2@arm.com", "date": "2021-01-14T07:08:30", "name": "[v1,5/5] app/eventdev: remove unnecessary barriers for order test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "24c09b80b3892b69b717c8be1f7593668d3a70be", "submitter": { "id": 1771, "url": "http://patchwork.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210114070830.707550-6-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14718, "url": "http://patchwork.dpdk.org/api/series/14718/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14718", "date": "2021-01-14T07:08:25", "name": "refactor smp barriers in app/eventdev", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14718/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/86543/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/86543/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 530C1A0A02;\n\tThu, 14 Jan 2021 08:10:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1EC6D140F41;\n\tThu, 14 Jan 2021 08:09:19 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 9F544140EB0\n for <dev@dpdk.org>; Thu, 14 Jan 2021 08:09:17 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 321451FB;\n Wed, 13 Jan 2021 23:09:17 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 05CA03F719;\n Wed, 13 Jan 2021 23:09:14 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>", "Cc": "dev@dpdk.org, Honnappa.Nagarahalli@arm.com, nd@arm.com,\n Feifei Wang <feifei.wang2@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Thu, 14 Jan 2021 15:08:30 +0800", "Message-Id": "<20210114070830.707550-6-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210114070830.707550-1-feifei.wang2@arm.com>", "References": "<20210114070830.707550-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers\n for order test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the wmb in order_process_stage_1 and order_process_stage_invalid in\nthe order test, they can be removed. This is because when the test results\nare wrong, the worker core writes 'true' to t->err. Then other worker\ncores, producer cores and the main core will load the 'error' index and\nstop testing. So, for the worker cores, no other storing operation needs\nto be guaranteed after this when errors happen.\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test-eventdev/test_order_common.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h\nindex 5ef840493..cd9d6009e 100644\n--- a/app/test-eventdev/test_order_common.h\n+++ b/app/test-eventdev/test_order_common.h\n@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order *const t,\n \t\t\tflow, *order_mbuf_seqn(t, ev->mbuf),\n \t\t\texpected_flow_seq[flow]);\n \t\tt->err = true;\n-\t\trte_smp_wmb();\n \t}\n \t/*\n \t * Events from an atomic flow of an event queue can be scheduled only to\n@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order *const t,\n {\n \tevt_err(\"invalid queue %d\", ev->queue_id);\n \tt->err = true;\n-\trte_smp_wmb();\n }\n \n #define ORDER_WORKER_INIT\\\n", "prefixes": [ "v1", "5/5" ] }