Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86636/?format=api
{ "id": 86636, "url": "http://patchwork.dpdk.org/api/patches/86636/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/bd5da27cc0e2a5d1355c33c945333702f4a456b8.1610636561.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<bd5da27cc0e2a5d1355c33c945333702f4a456b8.1610636561.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/bd5da27cc0e2a5d1355c33c945333702f4a456b8.1610636561.git.anatoly.burakov@intel.com", "date": "2021-01-14T15:02:45", "name": "fbarray: fix incorrect overlap check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c5137633f1ee36c58526e00a6db74542331a9504", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/bd5da27cc0e2a5d1355c33c945333702f4a456b8.1610636561.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 14757, "url": "http://patchwork.dpdk.org/api/series/14757/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14757", "date": "2021-01-14T15:02:45", "name": "fbarray: fix incorrect overlap check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14757/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/86636/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/86636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D60D0A0A02;\n\tThu, 14 Jan 2021 16:02:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B5A44141354;\n\tThu, 14 Jan 2021 16:02:49 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 44F7A141352;\n Thu, 14 Jan 2021 16:02:48 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 07:02:47 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.179])\n by orsmga008.jf.intel.com with ESMTP; 14 Jan 2021 07:02:46 -0800" ], "IronPort-SDR": [ "\n PqB4+tIqB3MAm2tSpVKWLKUaw+kVzX4iTIHIVTX+SqQzZH41p65z8ltkZY6uVnwInE/NXZJsV4\n TU3mxdzOomRw==", "\n S+6vGlYWxihEwAktGAE9qwVBm5Hhc7nwhlMHnt95KUpvaNeQxIADZ6nlKBQ4eyCYa+JkRST5MC\n TZSYvZ2Jv0Tw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9864\"; a=\"158154140\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"158154140\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"382293544\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Thu, 14 Jan 2021 15:02:45 +0000", "Message-Id": "\n <bd5da27cc0e2a5d1355c33c945333702f4a456b8.1610636561.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] fbarray: fix incorrect overlap check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we're attaching fbarrays in secondary processes, we check for\nwhether the intended memory address for the fbarray is already in use by\nsome other, local fbarray. However, the check for end-overlap (i.e. to\nsee if our memory area's end overlaps with some other fbarray) is\nincorrectly counting end offset as part of the overlap. Fix the check.\n\nFixes: 5b61c62cfd76 (\"fbarray: add internal tailq for mapped areas\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_fbarray.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c\nindex 1220e2bae9..d974f3dab7 100644\n--- a/lib/librte_eal/common/eal_common_fbarray.c\n+++ b/lib/librte_eal/common/eal_common_fbarray.c\n@@ -110,7 +110,7 @@ overlap(const struct mem_area *ma, const void *start, size_t len)\n \tif (start >= ma_start && start < ma_end)\n \t\treturn 1;\n \t/* end overlap? */\n-\tif (end >= ma_start && end < ma_end)\n+\tif (end > ma_start && end < ma_end)\n \t\treturn 1;\n \treturn 0;\n }\n", "prefixes": [] }