Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86657/?format=api
{ "id": 86657, "url": "http://patchwork.dpdk.org/api/patches/86657/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210115065708.43641-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210115065708.43641-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210115065708.43641-1-haiyue.wang@intel.com", "date": "2021-01-15T06:57:08", "name": "[v1] net/iavf: adjust the CRC statistics calculation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3b1486a664750f37c8586b36179a05c2766e7f69", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210115065708.43641-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 14772, "url": "http://patchwork.dpdk.org/api/series/14772/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14772", "date": "2021-01-15T06:57:08", "name": "[v1] net/iavf: adjust the CRC statistics calculation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14772/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/86657/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/86657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C285A0A02;\n\tFri, 15 Jan 2021 08:12:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 77376140D47;\n\tFri, 15 Jan 2021 08:12:56 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 5D645140D43\n for <dev@dpdk.org>; Fri, 15 Jan 2021 08:12:54 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 23:12:51 -0800", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.220])\n by fmsmga005.fm.intel.com with ESMTP; 14 Jan 2021 23:12:50 -0800" ], "IronPort-SDR": [ "\n 20z84nZPNxJ8lnCuWFuJOMPakiWO7VJ61crcz03lk4iat/85iAHqdUV/H+47OtBHh0NT1jyAI9\n 8R6kg/s7gCAQ==", "\n HOVpQcviM2U3/uVhOBbBI7BPWpUk7PC/Uz8R0s8Gf9Hyvvf9mDt/dianx1+Oylzjuv+D5xNCZX\n kC8lqec4QGwg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9864\"; a=\"175930978\"", "E=Sophos;i=\"5.79,348,1602572400\"; d=\"scan'208\";a=\"175930978\"", "E=Sophos;i=\"5.79,348,1602572400\"; d=\"scan'208\";a=\"572543884\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, qi.z.zhang@intel.com, qi.fu@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>", "Date": "Fri, 15 Jan 2021 14:57:08 +0800", "Message-Id": "<20210115065708.43641-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/iavf: adjust the CRC statistics\n calculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The AVF can support to enable / disable CRC strip, so it needs to adjust\nthe statistics calculation for ibytes according to offload setting.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex e22c62ed0..87e606273 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1413,6 +1413,9 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \tret = iavf_query_stats(adapter, &pstats);\n \tif (ret == 0) {\n+\t\tuint8_t crc_stats_len = (dev->data->dev_conf.rxmode.offloads &\n+\t\t\t\t\t DEV_RX_OFFLOAD_KEEP_CRC) ? 0 :\n+\t\t\t\t\t RTE_ETHER_CRC_LEN;\n \t\tiavf_update_stats(vsi, pstats);\n \t\tstats->ipackets = pstats->rx_unicast + pstats->rx_multicast +\n \t\t\t\tpstats->rx_broadcast - pstats->rx_discards;\n@@ -1421,7 +1424,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\tstats->imissed = pstats->rx_discards;\n \t\tstats->oerrors = pstats->tx_errors + pstats->tx_discards;\n \t\tstats->ibytes = pstats->rx_bytes;\n-\t\tstats->ibytes -= stats->ipackets * RTE_ETHER_CRC_LEN;\n+\t\tstats->ibytes -= stats->ipackets * crc_stats_len;\n \t\tstats->obytes = pstats->tx_bytes;\n \t} else {\n \t\tPMD_DRV_LOG(ERR, \"Get statistics failed\");\n", "prefixes": [ "v1" ] }