Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87106/?format=api
{ "id": 87106, "url": "http://patchwork.dpdk.org/api/patches/87106/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/b30c6a9b4ec553dd9d6fec5327885c47419a8906.1611335511.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b30c6a9b4ec553dd9d6fec5327885c47419a8906.1611335511.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b30c6a9b4ec553dd9d6fec5327885c47419a8906.1611335511.git.anatoly.burakov@intel.com", "date": "2021-01-22T17:12:15", "name": "[v20,2/4] eal: improve comments around power monitoring API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f2f777080d91f03326f875fadc8caa03fca8b4fa", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/b30c6a9b4ec553dd9d6fec5327885c47419a8906.1611335511.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 14908, "url": "http://patchwork.dpdk.org/api/series/14908/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14908", "date": "2021-01-22T17:12:13", "name": "Add PMD power management", "version": 20, "mbox": "http://patchwork.dpdk.org/series/14908/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87106/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/87106/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BCA92A0A0A;\n\tFri, 22 Jan 2021 18:12:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 477BF14105F;\n\tFri, 22 Jan 2021 18:12:29 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 262F8141045\n for <dev@dpdk.org>; Fri, 22 Jan 2021 18:12:22 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jan 2021 09:12:21 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.179])\n by orsmga005.jf.intel.com with ESMTP; 22 Jan 2021 09:12:20 -0800" ], "IronPort-SDR": [ "\n O/HSncM9WkZl1Y5sMhMhxfBl+i2hepsga9twqyqs5Mg17wvFFnsmmrW3bJHj7Z5I36oHL6C4nv\n z36Zkd7wF5og==", "\n AXxt5gAaV/fhKAfD3sMQB3LD5SMaV/SqFv0/1yYw+KuVZXw+Zf1khLCpK4nyNkF/09Db7GqlJL\n trHROkLUA0rA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9872\"; a=\"176901759\"", "E=Sophos;i=\"5.79,367,1602572400\"; d=\"scan'208\";a=\"176901759\"", "E=Sophos;i=\"5.79,367,1602572400\"; d=\"scan'208\";a=\"571191484\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net", "Date": "Fri, 22 Jan 2021 17:12:15 +0000", "Message-Id": "\n <b30c6a9b4ec553dd9d6fec5327885c47419a8906.1611335511.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1611335511.git.anatoly.burakov@intel.com>", "References": "<cover.1611143367.git.anatoly.burakov@intel.com>\n <cover.1611335511.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v20 2/4] eal: improve comments around power\n monitoring API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the API documentation is ambiguous as to what happens when\ncertain conditions are met. Document the behavior explicitly, as well as\nfix some typos and outdated comments.\n\nFixes: 6a17919b0e2a (\"eal: change power intrinsics API\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n .../include/generic/rte_power_intrinsics.h | 20 ++++++++++++-------\n 1 file changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h b/lib/librte_eal/include/generic/rte_power_intrinsics.h\nindex 5960c48c80..dddca3d41c 100644\n--- a/lib/librte_eal/include/generic/rte_power_intrinsics.h\n+++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h\n@@ -35,17 +35,20 @@ struct rte_power_monitor_cond {\n \n /**\n * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n *\n * Monitor specific address for changes. This will cause the CPU to enter an\n * architecture-defined optimized power state until either the specified\n * memory address is written to, a certain TSC timestamp is reached, or other\n * reasons cause the CPU to wake up.\n *\n- * Additionally, an `expected` 64-bit value and 64-bit mask are provided. If\n- * mask is non-zero, the current value pointed to by the `p` pointer will be\n- * checked against the expected value, and if they match, the entering of\n- * optimized power state may be aborted.\n+ * Additionally, an expected value (`pmc->val`), mask (`pmc->mask`), and data\n+ * size (`pmc->size`) are provided in the `pmc` power monitoring condition. If\n+ * the mask is non-zero, the current value pointed to by the `pmc->addr` pointer\n+ * will be read and compared against the expected value, and if they match, the\n+ * entering of optimized power state will be aborted. This is intended to\n+ * prevent the CPU from entering optimized power state and waiting on a write\n+ * that has already happened by the time this API is called.\n *\n * @warning It is responsibility of the user to check if this function is\n * supported at runtime using `rte_cpu_get_intrinsics_support()` API call.\n@@ -67,11 +70,14 @@ int rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \n /**\n * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n *\n * Wake up a specific lcore that is in a power optimized state and is monitoring\n * an address.\n *\n+ * @note It is safe to call this function if the lcore in question is not\n+ * sleeping. The function will have no effect.\n+ *\n * @note This function will *not* wake up a core that is in a power optimized\n * state due to calling `rte_power_pause`.\n *\n@@ -83,7 +89,7 @@ int rte_power_monitor_wakeup(const unsigned int lcore_id);\n \n /**\n * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n *\n * Enter an architecture-defined optimized power state until a certain TSC\n * timestamp is reached.\n", "prefixes": [ "v20", "2/4" ] }