Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87110/?format=api
{ "id": 87110, "url": "http://patchwork.dpdk.org/api/patches/87110/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210122175804.772207-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122175804.772207-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122175804.772207-1-thomas@monjalon.net", "date": "2021-01-22T17:58:04", "name": "[1/1] ethdev: fix handling of close failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5d278ace0d7f685373839bc1e121bfc60b79e2dd", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210122175804.772207-1-thomas@monjalon.net/mbox/", "series": [ { "id": 14910, "url": "http://patchwork.dpdk.org/api/series/14910/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14910", "date": "2021-01-22T17:58:04", "name": "[1/1] ethdev: fix handling of close failure", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14910/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87110/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/87110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C51D6A0A0A;\n\tFri, 22 Jan 2021 18:58:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 50CDC141090;\n\tFri, 22 Jan 2021 18:58:20 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 39AE814108E;\n Fri, 22 Jan 2021 18:58:19 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id CA37A5C011B;\n Fri, 22 Jan 2021 12:58:16 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Fri, 22 Jan 2021 12:58:16 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 48DF1108005F;\n Fri, 22 Jan 2021 12:58:15 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=fm3; bh=pOCg/nHE5FcmZfz6XqVFEQpRiV\n 3Aoqtachiy4Hf8LAI=; b=PMNomWygs4FQju3WUaJ4fDtfGbQCSc1hqAVwKkWbRq\n L6584hrPGiBgLQ1qiPJuJWDAlk1YdDcA8I477yqgB7oN+NbhACjRwirMZVANeIaa\n vFHqiNFeu5hkOhrAUpza/3j9gjeheQmNrrX5IazT3VCSsFKeAZqVccoXZow8LOV1\n Vw2GG3TixmxydtGSrU9IFk/1B6zeC2aZa8mFoPvnPOe+REmeEMXDJq7KQKAXeXLa\n zOHRlvramNV/wYXjFZK1fzAHKcyQ5l1tsn7Ih4ecwuXYCioo7HN7EBc3VRwfLi2k\n Fs1obHP0iV0OigTe20EG34XET6//bfIdA+IpdUFUr3yg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pOCg/nHE5FcmZfz6X\n qVFEQpRiV3Aoqtachiy4Hf8LAI=; b=hiAJ91aOOg85PZ7/5HBUEV+kgSvfNVUEl\n 2qfG19NcwqUQZFmQ35xmyqqQleaC8OIRB8P9r1soo+pHfmd5/G4R3d1nEYGDIdJD\n WWp9UJ3gq/I3v02t9W20C3dp9UVpRULpcsiTcUTW/zWUhxfp27J9yBY0tOVfvVoM\n WxjiZBR+k9hTRyeXXD4J9+/eogbc4YPHp6b0pxtiPmNW1zCJ9yT1AXLJ0jPnqWIe\n vQjNBlXdrW5j5Y5iHXcUSNf3AmCb52H1wT7HB3PqR1U+zKUhZtjspvMKfc5pk4Rz\n 2hIBX0vuuqJC9WGu5mBDaneZUSqVZsrTOWiqkUw4Y/okrVDkltQAQ==" ], "X-ME-Sender": "<xms:OBILYH-ELhjoKHyA9yAGCJ9U_ed50boHi4233jECunK6NUjPl-k_9g>\n <xme:OBILYDug4qU4_X2evmaHPCwyeMfM1foPJIAdquizJMjW-ORKmh1m0dGtmNzuPyRUR\n fXF2w5ikXQ-uq2VNg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudeigdduuddvucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu\n ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf\n grthhtvghrnhepvdelvdduhedvudduveeuvdevheegudelgeeigfejheduhedttdegudff\n jeeihffgnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiii\n gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn\n rdhnvght", "X-ME-Proxy": "<xmx:OBILYFCTNxVSK6F7jtWCkaq_oAn7JzYWE29JR-qIGLtOxdqd7x1ObQ>\n <xmx:OBILYDcFp2kWQiXVrl8r2El4OWWmba7IgTcItQYnTjX1OwivLzdhGg>\n <xmx:OBILYMNmxMcG7KYQVvNcVJ1S-Peee-hcTfWBHGlTWVmKsdum_YOMlw>\n <xmx:OBILYJqh1siY9s0j-ImsI5lr8QAVZZboQDQgyg1Q5PLTajofGZfTjg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Liron Himi <lironh@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 22 Jan 2021 18:58:04 +0100", "Message-Id": "<20210122175804.772207-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a failure happens when closing a port,\nit was unnecessarily failing again in the function eth_err(),\nbecause of a check against HW removal cause.\nIndeed there is a big chance the port is released at this point.\nGiven the port is in the middle (or at the end) of a close process,\nchecking the error cause by accessing the port is a non-sense.\nThe error check is replaced by a simple return in the close function.\n\nBugzilla ID: 624\nFixes: 8a5a0aad5d3e (\"ethdev: allow close function to return an error\")\nCc: stable@dpdk.org\n\nReported-by: Anatoly Burakov <anatoly.burakov@intel.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_ethdev/rte_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex daf5f24f7e..89455a432e 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1820,7 +1820,7 @@ rte_eth_dev_close(uint16_t port_id)\n \trte_ethdev_trace_close(port_id);\n \t*lasterr = rte_eth_dev_release_port(dev);\n \n-\treturn eth_err(port_id, firsterr);\n+\treturn firsterr;\n }\n \n int\n", "prefixes": [ "1/1" ] }