Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87169/?format=api
{ "id": 87169, "url": "http://patchwork.dpdk.org/api/patches/87169/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210125043054.4998-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210125043054.4998-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210125043054.4998-1-haiyue.wang@intel.com", "date": "2021-01-25T04:30:54", "name": "[v1] net/iavf: fix unsupported VLAN offload requested", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bdae7ed4800a7f1a3fd58592d9d7b36ad93f3c68", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210125043054.4998-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 14922, "url": "http://patchwork.dpdk.org/api/series/14922/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14922", "date": "2021-01-25T04:30:54", "name": "[v1] net/iavf: fix unsupported VLAN offload requested", "version": 1, "mbox": "http://patchwork.dpdk.org/series/14922/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87169/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/87169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6912CA052A;\n\tMon, 25 Jan 2021 05:47:02 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D3347140D34;\n\tMon, 25 Jan 2021 05:47:01 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 3EFBF140D29\n for <dev@dpdk.org>; Mon, 25 Jan 2021 05:46:59 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jan 2021 20:46:58 -0800", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.189])\n by orsmga008.jf.intel.com with ESMTP; 24 Jan 2021 20:46:56 -0800" ], "IronPort-SDR": [ "\n C/W3toGw9bk8uhGm99oPIsXwhz84IwmbaoOUrSj/X+xBOKJ2GWgI1bHiaf4M2l9SFAUxtuYT2m\n 6DA2FC9/WXdQ==", "\n LnfcVliFPcjWdO82vy9F2hhTaRVq8SdUhZRkv9CVQ/H/C5fZ/diat7zxuFIxPblIdVsAZYY/By\n g0a0iFdw5BqA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9874\"; a=\"166763069\"", "E=Sophos;i=\"5.79,372,1602572400\"; d=\"scan'208\";a=\"166763069\"", "E=Sophos;i=\"5.79,372,1602572400\"; d=\"scan'208\";a=\"387153260\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, qi.z.zhang@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>", "Date": "Mon, 25 Jan 2021 12:30:54 +0800", "Message-Id": "<20210125043054.4998-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/iavf: fix unsupported VLAN offload\n requested", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the underlying PF doesn't support a specific ethertype or the ability\nto toggle VLAN insertion and/or stripping, then the VF prevents sending\nan invalid message to the PF.\n\nFixes: 1c301e8c3cff (\"net/iavf: support new VLAN capabilities\")\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/iavf/iavf_vchnl.c | 36 ++++++++++++++++-------------------\n 1 file changed, 16 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex c82925eceb..9b8c4d113a 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -528,23 +528,21 @@ int\n iavf_config_vlan_strip_v2(struct iavf_adapter *adapter, bool enable)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_vlan_supported_caps *supported_caps;\n+\tstruct virtchnl_vlan_supported_caps *stripping_caps;\n \tstruct virtchnl_vlan_setting vlan_strip;\n \tstruct iavf_cmd_info args;\n-\tuint32_t stripping_caps;\n \tuint32_t *ethertype;\n \tint ret;\n \n-\tsupported_caps = &vf->vlan_v2_caps.offloads.stripping_support;\n-\tif (supported_caps->outer) {\n-\t\tstripping_caps = supported_caps->outer;\n+\tstripping_caps = &vf->vlan_v2_caps.offloads.stripping_support;\n+\n+\tif ((stripping_caps->outer & VIRTCHNL_VLAN_ETHERTYPE_8100) &&\n+\t (stripping_caps->outer & VIRTCHNL_VLAN_TOGGLE))\n \t\tethertype = &vlan_strip.outer_ethertype_setting;\n-\t} else {\n-\t\tstripping_caps = supported_caps->inner;\n+\telse if ((stripping_caps->inner & VIRTCHNL_VLAN_ETHERTYPE_8100) &&\n+\t\t (stripping_caps->inner & VIRTCHNL_VLAN_TOGGLE))\n \t\tethertype = &vlan_strip.inner_ethertype_setting;\n-\t}\n-\n-\tif (!(stripping_caps & VIRTCHNL_VLAN_ETHERTYPE_8100))\n+\telse\n \t\treturn -ENOTSUP;\n \n \tmemset(&vlan_strip, 0, sizeof(vlan_strip));\n@@ -570,23 +568,21 @@ int\n iavf_config_vlan_insert_v2(struct iavf_adapter *adapter, bool enable)\n {\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct virtchnl_vlan_supported_caps *supported_caps;\n+\tstruct virtchnl_vlan_supported_caps *insertion_caps;\n \tstruct virtchnl_vlan_setting vlan_insert;\n \tstruct iavf_cmd_info args;\n-\tuint32_t insertion_caps;\n \tuint32_t *ethertype;\n \tint ret;\n \n-\tsupported_caps = &vf->vlan_v2_caps.offloads.insertion_support;\n-\tif (supported_caps->outer) {\n-\t\tinsertion_caps = supported_caps->outer;\n+\tinsertion_caps = &vf->vlan_v2_caps.offloads.insertion_support;\n+\n+\tif ((insertion_caps->outer & VIRTCHNL_VLAN_ETHERTYPE_8100) &&\n+\t (insertion_caps->outer & VIRTCHNL_VLAN_TOGGLE))\n \t\tethertype = &vlan_insert.outer_ethertype_setting;\n-\t} else {\n-\t\tinsertion_caps = supported_caps->inner;\n+\telse if ((insertion_caps->inner & VIRTCHNL_VLAN_ETHERTYPE_8100) &&\n+\t\t (insertion_caps->inner & VIRTCHNL_VLAN_TOGGLE))\n \t\tethertype = &vlan_insert.inner_ethertype_setting;\n-\t}\n-\n-\tif (!(insertion_caps & VIRTCHNL_VLAN_ETHERTYPE_8100))\n+\telse\n \t\treturn -ENOTSUP;\n \n \tmemset(&vlan_insert, 0, sizeof(vlan_insert));\n", "prefixes": [ "v1" ] }