Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87564/?format=api
{ "id": 87564, "url": "http://patchwork.dpdk.org/api/patches/87564/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210129163909.35970-1-wanjunjie@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210129163909.35970-1-wanjunjie@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210129163909.35970-1-wanjunjie@bytedance.com", "date": "2021-01-29T16:39:09", "name": "vhost: avoid iotlb mempool allocation while IOMMU disabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4000637eedef28d93e644d64e265cb1fd381bb74", "submitter": { "id": 2089, "url": "http://patchwork.dpdk.org/api/people/2089/?format=api", "name": "Wan Junjie", "email": "wanjunjie@bytedance.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210129163909.35970-1-wanjunjie@bytedance.com/mbox/", "series": [ { "id": 15036, "url": "http://patchwork.dpdk.org/api/series/15036/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15036", "date": "2021-01-29T16:39:09", "name": "vhost: avoid iotlb mempool allocation while IOMMU disabled", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15036/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87564/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/87564/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F5A5A09E4;\n\tFri, 29 Jan 2021 18:01:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BA17B40696;\n\tFri, 29 Jan 2021 18:01:12 +0100 (CET)", "from mail-pg1-f171.google.com (mail-pg1-f171.google.com\n [209.85.215.171])\n by mails.dpdk.org (Postfix) with ESMTP id 499E440395\n for <dev@dpdk.org>; Fri, 29 Jan 2021 17:39:27 +0100 (CET)", "by mail-pg1-f171.google.com with SMTP id s23so5779859pgh.11\n for <dev@dpdk.org>; Fri, 29 Jan 2021 08:39:27 -0800 (PST)", "from C02Z10J4LVCK.lan ([139.177.225.245])\n by smtp.gmail.com with ESMTPSA id l1sm2946049pgt.26.2021.01.29.08.39.24\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 29 Jan 2021 08:39:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=lxrOnotwLj3Dc8d/K1KBATZ8KrSdid9NBw6A4KTg5KU=;\n b=oWFtE7WdIjGDahLg9ZoCxDOoRlr9Dz9yyQufH+FcL4FzQFOWVRJWiHk2S41WUDynMu\n FPd/tanPO/j4IN2+pvF55f9RUG3tDp7w/YKN1n+xeZUdWdyWVhlAlko/DXVePMc2F6tH\n 4KZd6Pjy+6xlyDlNf+htfHqvVMS5RDUe4fSKivYzm+lPaylseyqxuSbindhObjYsYz9q\n x++q/eirSh4ebCdslqdzeLm40ub41gyuxGTIPrVQ2LQFdB4htUOWeTUXNZKbn42DkyC8\n 58zTmv92hl0LN0QGGgxpuT1t+C2rG0+oK+JlRXYLHEbipO4le02z5phr9UFbGZ2DL7Om\n TQxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=lxrOnotwLj3Dc8d/K1KBATZ8KrSdid9NBw6A4KTg5KU=;\n b=VIiz+zfQpGaiDzj1h+pvd2PK1uXqX8XlegA5l/bbhPtS5PJcLP6bMi5X2CIroYmyJV\n D4ZIkuqpBag8m6hkltkPIIfslwos6n2iWGsxG9NQr1jtF5nKkqRY0wNHQLSGumUH5eAb\n bPbol+V5iQBHVXcVZShC3bVD36AjdFyvOqEExWL/Br9Y5Tn3x+bNwxiNgXI2QT5pxLz8\n 4BHo366VLWHiPqbBSEfOywRa3hnSyy2BEIDqjlVRNu99Y89ic8HSnRr4Ee1B/etD4BAe\n zsinE4sk3N+T8RS92k3P9Y9qOYImtaKA9QiuvWsLL2Lzk3gXgT/Y8RaQC6yoRRagQKCi\n Rflg==", "X-Gm-Message-State": "AOAM532/522JDGP5CZrhVOPJMSRnAOwVK1gv2KnzNH9nqYGX/RO5BlNa\n nSdkHVUXt4b+2spwnSzH6AmqoA==", "X-Google-Smtp-Source": "\n ABdhPJxb9xAX79fYk5/4odbsSpz2Jr5RfCXLj8rdyHJ7qNWV7BjD6FFwUbyj2lqDRmnt4lXYiO+C0Q==", "X-Received": "by 2002:a62:8c0e:0:b029:1b6:a234:3ef2 with SMTP id\n m14-20020a628c0e0000b02901b6a2343ef2mr5107539pfd.37.1611938367052;\n Fri, 29 Jan 2021 08:39:27 -0800 (PST)", "From": "Wan Junjie <wanjunjie@bytedance.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, Wan Junjie <wanjunjie@bytedance.com>,\n Peng He <hepeng.0320@bytedance.com>,\n Zhihong Wang <wangzhihong.wzh@bytedance.com>", "Date": "Sat, 30 Jan 2021 00:39:09 +0800", "Message-Id": "<20210129163909.35970-1-wanjunjie@bytedance.com>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 29 Jan 2021 18:01:11 +0100", "Subject": "[dpdk-dev] [PATCH] vhost: avoid iotlb mempool allocation while\n IOMMU disabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If vhost device's IOMMU feature is disabled, iotlb mempool allocation\nis unnecessary.\n\nReported-by: Peng He <hepeng.0320@bytedance.com>\nSigned-off-by: Wan Junjie <wanjunjie@bytedance.com>\nReviewed-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>\n---\n lib/librte_vhost/vhost.c | 6 ++++--\n lib/librte_vhost/vhost_user.c | 2 +-\n 2 files changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex efb136edd..00c5040e2 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -352,7 +352,8 @@ free_vq(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \t\tvhost_free_async_mem(vq);\n \t}\n \trte_free(vq->batch_copy_elems);\n-\trte_mempool_free(vq->iotlb_pool);\n+\tif (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))\n+\t\trte_mempool_free(vq->iotlb_pool);\n \trte_free(vq);\n }\n \n@@ -556,7 +557,8 @@ init_vring_queue(struct virtio_net *dev, uint32_t vring_idx)\n \tvq->callfd = VIRTIO_UNINITIALIZED_EVENTFD;\n \tvq->notif_enable = VIRTIO_UNINITIALIZED_NOTIF;\n \n-\tvhost_user_iotlb_init(dev, vring_idx);\n+\tif (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))\n+\t\tvhost_user_iotlb_init(dev, vring_idx);\n \t/* Backends are set to -1 indicating an inactive device. */\n \tvq->backend = -1;\n }\ndiff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex a60bb945a..d415607d7 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -575,7 +575,7 @@ numa_realloc(struct virtio_net *dev, int index)\n \tdev->virtqueue[index] = vq;\n \tvhost_devices[dev->vid] = dev;\n \n-\tif (old_vq != vq)\n+\tif (old_vq != vq && (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)))\n \t\tvhost_user_iotlb_init(dev, index);\n \n \treturn dev;\n", "prefixes": [] }