Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87681/?format=api
{ "id": 87681, "url": "http://patchwork.dpdk.org/api/patches/87681/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1612355037-48768-12-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1612355037-48768-12-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1612355037-48768-12-git-send-email-oulijun@huawei.com", "date": "2021-02-03T12:23:57", "name": "[11/11] net/hns3: add check for max pkt length of Rx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e3b9781c212595999eb36ae734f3bd89cba2c6ca", "submitter": { "id": 1675, "url": "http://patchwork.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1612355037-48768-12-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 15123, "url": "http://patchwork.dpdk.org/api/series/15123/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15123", "date": "2021-02-03T12:23:47", "name": "critical bugfixes for hns3", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15123/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87681/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/87681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64575A0A0E;\n\tWed, 3 Feb 2021 13:24:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 271C9240556;\n\tWed, 3 Feb 2021 13:24:32 +0100 (CET)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id 6E66A240549\n for <dev@dpdk.org>; Wed, 3 Feb 2021 13:24:29 +0100 (CET)", "from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DW1706dFbzjHDd;\n Wed, 3 Feb 2021 20:23:24 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 3 Feb 2021 20:24:24 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Wed, 3 Feb 2021 20:23:57 +0800", "Message-ID": "<1612355037-48768-12-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1612355037-48768-1-git-send-email-oulijun@huawei.com>", "References": "<1612355037-48768-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 11/11] net/hns3: add check for max pkt length of\n Rx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen jumbo frame is enabled, the MTU size needs to be modified\nbased on 'max_rx_pkt_len'. Driver needs to check the validity\nof 'max_rx_pkt_len'. And it should be in the range of\nHNS3_DEFAULT_FRAME_LEN and HNS3_MAX_FRAME_LEN. Otherwise, it may\ncause that the MTU size is inconsistent with jumbo frame offload.\n\nFixes: 19a3ca4c99cf (\"net/hns3: add start/stop and configure operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 19 +++++++++++++------\n drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++------\n 2 files changed, 26 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex a7ae8f8..dbd48de 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2343,6 +2343,7 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \tuint16_t nb_rx_q = dev->data->nb_rx_queues;\n \tuint16_t nb_tx_q = dev->data->nb_tx_queues;\n \tstruct rte_eth_rss_conf rss_conf;\n+\tuint32_t max_rx_pkt_len;\n \tuint16_t mtu;\n \tbool gro_en;\n \tint ret;\n@@ -2396,12 +2397,18 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \t * according to the maximum RX packet length.\n \t */\n \tif (conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\t/*\n-\t\t * Security of max_rx_pkt_len is guaranteed in dpdk frame.\n-\t\t * Maximum value of max_rx_pkt_len is HNS3_MAX_FRAME_LEN, so it\n-\t\t * can safely assign to \"uint16_t\" type variable.\n-\t\t */\n-\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(conf->rxmode.max_rx_pkt_len);\n+\t\tmax_rx_pkt_len = conf->rxmode.max_rx_pkt_len;\n+\t\tif (max_rx_pkt_len > HNS3_MAX_FRAME_LEN ||\n+\t\t max_rx_pkt_len <= HNS3_DEFAULT_FRAME_LEN) {\n+\t\t\thns3_err(hw, \"maximum Rx packet length must be greater \"\n+\t\t\t\t \"than %u and less than %u when jumbo frame enabled.\",\n+\t\t\t\t (uint16_t)HNS3_DEFAULT_FRAME_LEN,\n+\t\t\t\t (uint16_t)HNS3_MAX_FRAME_LEN);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto cfg_err;\n+\t\t}\n+\n+\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(max_rx_pkt_len);\n \t\tret = hns3_dev_mtu_set(dev, mtu);\n \t\tif (ret)\n \t\t\tgoto cfg_err;\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex a607bd3..3f9f328 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -778,6 +778,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)\n \tuint16_t nb_rx_q = dev->data->nb_rx_queues;\n \tuint16_t nb_tx_q = dev->data->nb_tx_queues;\n \tstruct rte_eth_rss_conf rss_conf;\n+\tuint32_t max_rx_pkt_len;\n \tuint16_t mtu;\n \tbool gro_en;\n \tint ret;\n@@ -825,12 +826,18 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)\n \t * according to the maximum RX packet length.\n \t */\n \tif (conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\t/*\n-\t\t * Security of max_rx_pkt_len is guaranteed in dpdk frame.\n-\t\t * Maximum value of max_rx_pkt_len is HNS3_MAX_FRAME_LEN, so it\n-\t\t * can safely assign to \"uint16_t\" type variable.\n-\t\t */\n-\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(conf->rxmode.max_rx_pkt_len);\n+\t\tmax_rx_pkt_len = conf->rxmode.max_rx_pkt_len;\n+\t\tif (max_rx_pkt_len > HNS3_MAX_FRAME_LEN ||\n+\t\t max_rx_pkt_len <= HNS3_DEFAULT_FRAME_LEN) {\n+\t\t\thns3_err(hw, \"maximum Rx packet length must be greater \"\n+\t\t\t\t \"than %u and less than %u when jumbo frame enabled.\",\n+\t\t\t\t (uint16_t)HNS3_DEFAULT_FRAME_LEN,\n+\t\t\t\t (uint16_t)HNS3_MAX_FRAME_LEN);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto cfg_err;\n+\t\t}\n+\n+\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(max_rx_pkt_len);\n \t\tret = hns3vf_dev_mtu_set(dev, mtu);\n \t\tif (ret)\n \t\t\tgoto cfg_err;\n", "prefixes": [ "11/11" ] }