Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 87792,
    "url": "http://patchwork.dpdk.org/api/patches/87792/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210205074758.28278-1-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210205074758.28278-1-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210205074758.28278-1-yong.liu@intel.com",
    "date": "2021-02-05T07:47:58",
    "name": "vhost: fix packed ring dequeue offloading",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "557197fb54e6c31807aea63afd6197ecec56e77e",
    "submitter": {
        "id": 17,
        "url": "http://patchwork.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patchwork.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210205074758.28278-1-yong.liu@intel.com/mbox/",
    "series": [
        {
            "id": 15181,
            "url": "http://patchwork.dpdk.org/api/series/15181/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15181",
            "date": "2021-02-05T07:47:58",
            "name": "vhost: fix packed ring dequeue offloading",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/15181/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/87792/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/87792/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6FCDA0524;\n\tFri,  5 Feb 2021 08:48:09 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4451140682;\n\tFri,  5 Feb 2021 08:48:09 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 2B6AE4067B;\n Fri,  5 Feb 2021 08:48:03 +0100 (CET)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Feb 2021 23:48:01 -0800",
            "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.108])\n by orsmga008.jf.intel.com with ESMTP; 04 Feb 2021 23:47:59 -0800"
        ],
        "IronPort-SDR": [
            "\n vTubzc/4u8NHqzHUGFgiDNkynPK927UnhPuthljaIWPfs1wLVcEWqNxw1hZfaY1eNujq6VH0/g\n TKwQpUp8jyew==",
            "\n QlRvjXtrQz2LAwY1xInxk77W45bTkODZh/S5U39KJiz+VorOQ2vgLL4NH/UAKZzbUuV7jBLw+T\n sjTmxOyFSFFg=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9885\"; a=\"177889825\"",
            "E=Sophos;i=\"5.81,154,1610438400\"; d=\"scan'208\";a=\"177889825\"",
            "E=Sophos;i=\"5.81,154,1610438400\"; d=\"scan'208\";a=\"393745759\""
        ],
        "X-ExtLoop1": "1",
        "From": "Marvin Liu <yong.liu@intel.com>",
        "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com",
        "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>,\n\tstable@dpdk.org",
        "Date": "Fri,  5 Feb 2021 15:47:58 +0800",
        "Message-Id": "<20210205074758.28278-1-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] vhost: fix packed ring dequeue offloading",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When vhost doing dequeue offloading, will parse ethernet and l3/l4\nheader of the packet. Then vhost will set corresponded value in mbuf\nattributes. Thus mean offloading action should after packet data copy.\n\nFixes: 75ed51697820 (\"vhost: add packed ring batch dequeue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>",
    "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 730b92e478..0a7d008a91 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -2267,7 +2267,6 @@ vhost_reserve_avail_batch_packed(struct virtio_net *dev,\n {\n \tbool wrap = vq->avail_wrap_counter;\n \tstruct vring_packed_desc *descs = vq->desc_packed;\n-\tstruct virtio_net_hdr *hdr;\n \tuint64_t lens[PACKED_BATCH_SIZE];\n \tuint64_t buf_lens[PACKED_BATCH_SIZE];\n \tuint32_t buf_offset = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n@@ -2324,13 +2323,6 @@ vhost_reserve_avail_batch_packed(struct virtio_net *dev,\n \t\tids[i] = descs[avail_idx + i].id;\n \t}\n \n-\tif (virtio_net_with_host_offload(dev)) {\n-\t\tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n-\t\t\thdr = (struct virtio_net_hdr *)(desc_addrs[i]);\n-\t\t\tvhost_dequeue_offload(hdr, pkts[i]);\n-\t\t}\n-\t}\n-\n \treturn 0;\n \n free_buf:\n@@ -2348,6 +2340,7 @@ virtio_dev_tx_batch_packed(struct virtio_net *dev,\n {\n \tuint16_t avail_idx = vq->last_avail_idx;\n \tuint32_t buf_offset = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n+\tstruct virtio_net_hdr *hdr;\n \tuintptr_t desc_addrs[PACKED_BATCH_SIZE];\n \tuint16_t ids[PACKED_BATCH_SIZE];\n \tuint16_t i;\n@@ -2364,6 +2357,13 @@ virtio_dev_tx_batch_packed(struct virtio_net *dev,\n \t\t\t   (void *)(uintptr_t)(desc_addrs[i] + buf_offset),\n \t\t\t   pkts[i]->pkt_len);\n \n+\tif (virtio_net_with_host_offload(dev)) {\n+\t\tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n+\t\t\thdr = (struct virtio_net_hdr *)(desc_addrs[i]);\n+\t\t\tvhost_dequeue_offload(hdr, pkts[i]);\n+\t\t}\n+\t}\n+\n \tif (virtio_net_is_inorder(dev))\n \t\tvhost_shadow_dequeue_batch_packed_inorder(vq,\n \t\t\tids[PACKED_BATCH_SIZE - 1]);\n",
    "prefixes": []
}