Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88168/?format=api
{ "id": 88168, "url": "http://patchwork.dpdk.org/api/patches/88168/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210224155553.26893-7-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210224155553.26893-7-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210224155553.26893-7-kalesh-anakkur.purayil@broadcom.com", "date": "2021-02-24T15:55:48", "name": "[06/11] net/bnxt: update to new version of backing store", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e7b00f7e6dde6dfc353cb29577419d090cb5022c", "submitter": { "id": 1479, "url": "http://patchwork.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210224155553.26893-7-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 15364, "url": "http://patchwork.dpdk.org/api/series/15364/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15364", "date": "2021-02-24T15:55:42", "name": "bnxt fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15364/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88168/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/88168/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1461CA054F;\n\tWed, 24 Feb 2021 16:34:29 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06029160851;\n\tWed, 24 Feb 2021 16:33:43 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.232.172])\n by mails.dpdk.org (Postfix) with ESMTP id 6911C16083E\n for <dev@dpdk.org>; Wed, 24 Feb 2021 16:33:41 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id ED5B280F0;\n Wed, 24 Feb 2021 07:33:39 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com ED5B280F0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1614180821;\n bh=+57zaOML9zRrbVscliV1tZe6gjj28OKXfeQB3BvobP0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=lYf6pu6IpHA8fsC20l0lWYm5xi1R3oiwlkQL7sU1jbBCS2OFyInAZcuoPI0BZGIFy\n 0DggGWN4/AGz1rfnmNdS52NptX5xhdqifVRZ4RvMagsTiEvWbjmIfxCVsjN08PC+ah\n bdQ1Btl4IITjg4Ld0Yg0hLvtit8nmFKxlhmDiF9o=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Wed, 24 Feb 2021 21:25:48 +0530", "Message-Id": "<20210224155553.26893-7-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20210224155553.26893-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20210224155553.26893-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 06/11] net/bnxt: update to new version of backing\n store", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\nUpdate HWRM headers to version 1.10.2.15\nwhich updates the backing store API for additional TQM rings.\nAdd support for 9th TQM ring using latest firmware interface.\nAlso make sure that we set only necessary bits in the enables\nfield in backing store request.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 16 ++++++++++++----\n drivers/net/bnxt/bnxt_ethdev.c | 11 +++++++++--\n drivers/net/bnxt/bnxt_hwrm.c | 36 +++++++++++++++++++++++++++++++++---\n 3 files changed, 54 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex b4370e5..bf3459e 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -390,9 +390,17 @@ struct bnxt_coal {\n #define BNXT_MAX_RSS_CTXTS_P5 \\\n \t(BNXT_RSS_TBL_SIZE_P5 / BNXT_RSS_ENTRIES_PER_CTX_P5)\n \n-#define BNXT_MAX_TC 8\n-#define BNXT_MAX_QUEUE 8\n-#define BNXT_MAX_TC_Q (BNXT_MAX_TC + 1)\n+#define BNXT_MAX_QUEUE\t\t\t8\n+#define BNXT_MAX_TQM_SP_RINGS\t\t1\n+#define BNXT_MAX_TQM_FP_LEGACY_RINGS\t8\n+#define BNXT_MAX_TQM_FP_RINGS\t\t9\n+#define BNXT_MAX_TQM_LEGACY_RINGS\t\\\n+\t(BNXT_MAX_TQM_SP_RINGS + BNXT_MAX_TQM_FP_LEGACY_RINGS)\n+#define BNXT_MAX_TQM_RINGS\t\t\\\n+\t(BNXT_MAX_TQM_SP_RINGS + BNXT_MAX_TQM_FP_RINGS)\n+#define BNXT_BACKING_STORE_CFG_LEGACY_LEN\t256\n+#define BNXT_BACKING_STORE_CFG_LEN\t\\\n+\tsizeof(struct hwrm_func_backing_store_cfg_input)\n #define BNXT_PAGE_SHFT 12\n #define BNXT_PAGE_SIZE (1 << BNXT_PAGE_SHFT)\n #define MAX_CTX_PAGES (BNXT_PAGE_SIZE / 8)\n@@ -461,7 +469,7 @@ struct bnxt_ctx_mem_info {\n \tstruct bnxt_ctx_pg_info cq_mem;\n \tstruct bnxt_ctx_pg_info vnic_mem;\n \tstruct bnxt_ctx_pg_info stat_mem;\n-\tstruct bnxt_ctx_pg_info *tqm_mem[BNXT_MAX_TC_Q];\n+\tstruct bnxt_ctx_pg_info *tqm_mem[BNXT_MAX_TQM_RINGS];\n };\n \n struct bnxt_ctx_mem_buf_info {\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 22c880c..17bda86 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4326,15 +4326,22 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)\n \tentries = clamp_t(uint32_t, entries, min,\n \t\t\t ctx->tqm_max_entries_per_ring);\n \tfor (i = 0, ena = 0; i < ctx->tqm_fp_rings_count + 1; i++) {\n+\t\t/* i=0 is for TQM_SP. i=1 to i=8 applies to RING0 to RING7.\n+\t\t * i > 8 is other ext rings.\n+\t\t */\n \t\tctx_pg = ctx->tqm_mem[i];\n \t\tctx_pg->entries = i ? entries : entries_sp;\n \t\tif (ctx->tqm_entry_size) {\n \t\t\tmem_size = ctx->tqm_entry_size * ctx_pg->entries;\n-\t\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"tqm_mem\", i);\n+\t\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size,\n+\t\t\t\t\t\t \"tqm_mem\", i);\n \t\t\tif (rc)\n \t\t\t\treturn rc;\n \t\t}\n-\t\tena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_SP << i;\n+\t\tif (i < BNXT_MAX_TQM_LEGACY_RINGS)\n+\t\t\tena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_SP << i;\n+\t\telse\n+\t\t\tena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_RING8;\n \t}\n \n \tena |= FUNC_BACKING_STORE_CFG_INPUT_DFLT_ENABLES;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex e11502c..fc47950 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -27,7 +27,7 @@\n #define HWRM_SPEC_CODE_1_8_3\t\t0x10803\n #define HWRM_VERSION_1_9_1\t\t0x10901\n #define HWRM_VERSION_1_9_2\t\t0x10903\n-\n+#define HWRM_VERSION_1_10_2_13\t\t0x10a020d\n struct bnxt_plcmodes_cfg {\n \tuint32_t\tflags;\n \tuint16_t\tjumbo_thresh;\n@@ -105,6 +105,11 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \n \ttimeout = bp->hwrm_cmd_timeout;\n \n+\t/* Update the message length for backing store config for new FW. */\n+\tif (bp->fw_ver >= HWRM_VERSION_1_10_2_13 &&\n+\t rte_cpu_to_le_16(req->req_type) == HWRM_FUNC_BACKING_STORE_CFG)\n+\t\tmsg_len = BNXT_BACKING_STORE_CFG_LEGACY_LEN;\n+\n \tif (bp->flags & BNXT_FLAG_SHORT_CMD ||\n \t msg_len > bp->max_req_len) {\n \t\tvoid *short_cmd_req = bp->hwrm_short_cmd_req_addr;\n@@ -5120,8 +5125,21 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt *bp)\n \tctx->tim_max_entries = rte_le_to_cpu_32(resp->tim_max_entries);\n \tctx->tqm_fp_rings_count = resp->tqm_fp_rings_count;\n \n-\tif (!ctx->tqm_fp_rings_count)\n-\t\tctx->tqm_fp_rings_count = bp->max_q;\n+\tctx->tqm_fp_rings_count = ctx->tqm_fp_rings_count ?\n+\t\t\t\t RTE_MIN(ctx->tqm_fp_rings_count,\n+\t\t\t\t\t BNXT_MAX_TQM_FP_LEGACY_RINGS) :\n+\t\t\t\t bp->max_q;\n+\n+\t/* Check if the ext ring count needs to be counted.\n+\t * Ext ring count is available only with new FW so we should not\n+\t * look at the field on older FW.\n+\t */\n+\tif (ctx->tqm_fp_rings_count == BNXT_MAX_TQM_FP_LEGACY_RINGS &&\n+\t bp->hwrm_max_ext_req_len >= BNXT_BACKING_STORE_CFG_LEN) {\n+\t\tctx->tqm_fp_rings_count += resp->tqm_fp_rings_count_ext;\n+\t\tctx->tqm_fp_rings_count = RTE_MIN(BNXT_MAX_TQM_FP_RINGS,\n+\t\t\t\t\t\t ctx->tqm_fp_rings_count);\n+\t}\n \n \ttqm_rings = ctx->tqm_fp_rings_count + 1;\n \n@@ -5232,6 +5250,18 @@ int bnxt_hwrm_func_backing_store_cfg(struct bnxt *bp, uint32_t enables)\n \t\tbnxt_hwrm_set_pg_attr(&ctx_pg->ring_mem, pg_attr, pg_dir);\n \t}\n \n+\tif (enables & HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_RING8) {\n+\t\t/* DPDK does not need to configure MRAV and TIM type.\n+\t\t * So we are skipping over MRAV and TIM. Skip to configure\n+\t\t * HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_RING8.\n+\t\t */\n+\t\tctx_pg = ctx->tqm_mem[BNXT_MAX_TQM_LEGACY_RINGS];\n+\t\treq.tqm_ring8_num_entries = rte_cpu_to_le_16(ctx_pg->entries);\n+\t\tbnxt_hwrm_set_pg_attr(&ctx_pg->ring_mem,\n+\t\t\t\t &req.tqm_ring8_pg_size_tqm_ring_lvl,\n+\t\t\t\t &req.tqm_ring8_page_dir);\n+\t}\n+\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \tHWRM_CHECK_RESULT();\n \tHWRM_UNLOCK();\n", "prefixes": [ "06/11" ] }