Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88170,
    "url": "http://patchwork.dpdk.org/api/patches/88170/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210224155553.26893-9-kalesh-anakkur.purayil@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210224155553.26893-9-kalesh-anakkur.purayil@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210224155553.26893-9-kalesh-anakkur.purayil@broadcom.com",
    "date": "2021-02-24T15:55:50",
    "name": "[08/11] net/bnxt: handle echo request async message",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fd7766e09f173b90dd251c90e0aba46f2b3932c5",
    "submitter": {
        "id": 1479,
        "url": "http://patchwork.dpdk.org/api/people/1479/?format=api",
        "name": "Kalesh A P",
        "email": "kalesh-anakkur.purayil@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patchwork.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210224155553.26893-9-kalesh-anakkur.purayil@broadcom.com/mbox/",
    "series": [
        {
            "id": 15364,
            "url": "http://patchwork.dpdk.org/api/series/15364/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15364",
            "date": "2021-02-24T15:55:42",
            "name": "bnxt fixes",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/15364/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/88170/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/88170/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5084A054F;\n\tWed, 24 Feb 2021 16:34:51 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6D28160878;\n\tWed, 24 Feb 2021 16:33:45 +0100 (CET)",
            "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.232.172])\n by mails.dpdk.org (Postfix) with ESMTP id 6F81316085D\n for <dev@dpdk.org>; Wed, 24 Feb 2021 16:33:44 +0100 (CET)",
            "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id F24E5828A;\n Wed, 24 Feb 2021 07:33:42 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com F24E5828A",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1614180824;\n bh=53CYlhSvDWuJmxwWkPeKUIvQmOPBDsG/BWHRfz/j8g8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=E2IuAMXb2or3eKe1YpaccyfWK3Du/thSQEZ46hlvgEImkBTGvDlEV4PopiVSooVUX\n +yRgluuj1FF5OCS1CIiVcs19aD2MhCeZSgmBu8JCHu8xzeW/J8kmzKydcut4JKAWtl\n DNjvGnbuUiwOJBEPVq6F+JRPymJQpFeHzuAy1EsQ=",
        "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com",
        "Date": "Wed, 24 Feb 2021 21:25:50 +0530",
        "Message-Id": "<20210224155553.26893-9-kalesh-anakkur.purayil@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1",
        "In-Reply-To": "<20210224155553.26893-1-kalesh-anakkur.purayil@broadcom.com>",
        "References": "<20210224155553.26893-1-kalesh-anakkur.purayil@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 08/11] net/bnxt: handle echo request async message",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThis is a new async message that the firmware can send to check if it\ncan communicate with the driver. This is an added error detection\nscheme that firmware can use if it suspects errors in the PCIe\ninterface. When the driver receives this async message, it will reply\nback echoing some data in the async message. If the firmware is not\ngetting the reply with the proper data after some retries, error\nrecovery will kick in.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c  | 11 +++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 22 ++++++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.h |  4 ++++\n 3 files changed, 37 insertions(+)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 20b4f92..2c7fd78 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -103,6 +103,7 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \tuint16_t port_id = bp->eth_dev->data->port_id;\n \tstruct bnxt_error_recovery_info *info;\n \tuint32_t event_data;\n+\tuint32_t echo_req_data1, echo_req_data2;\n \n \tswitch (event_id) {\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE:\n@@ -204,6 +205,16 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE:\n \t\tbnxt_process_default_vnic_change(bp, async_cmp);\n \t\tbreak;\n+\tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ECHO_REQUEST:\n+\t\techo_req_data1 = rte_le_to_cpu_32(async_cmp->event_data1);\n+\t\techo_req_data2 = rte_le_to_cpu_32(async_cmp->event_data2);\n+\t\tPMD_DRV_LOG(INFO,\n+\t\t\t    \"Port %u: Received fw echo request: data1 %#x data2 %#x\\n\",\n+\t\t\t    port_id, echo_req_data1, echo_req_data2);\n+\t\tif (bp->recovery_info)\n+\t\t\tbnxt_hwrm_fw_echo_reply(bp, echo_req_data1,\n+\t\t\t\t\t\techo_req_data2);\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(DEBUG, \"handle_async_event id = 0x%x\\n\", event_id);\n \t\tbreak;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 37fa78e..9142119 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -954,6 +954,9 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \t\treq.async_event_fwd[1] |=\n \t\trte_cpu_to_le_32(ASYNC_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE);\n \n+\treq.async_event_fwd[2] |=\n+\t\trte_cpu_to_le_32(ASYNC_CMPL_EVENT_ID_ECHO_REQUEST);\n+\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \n \tHWRM_CHECK_RESULT();\n@@ -5891,3 +5894,22 @@ int bnxt_hwrm_cfa_adv_flow_mgmt_qcaps(struct bnxt *bp)\n \n \treturn rc;\n }\n+\n+int bnxt_hwrm_fw_echo_reply(struct bnxt *bp, uint32_t echo_req_data1,\n+\t\t\t    uint32_t echo_req_data2)\n+{\n+\tstruct hwrm_func_echo_response_input req = {0};\n+\tstruct hwrm_func_echo_response_output *resp = bp->hwrm_cmd_resp_addr;\n+\tint rc;\n+\n+\tHWRM_PREP(&req, HWRM_FUNC_ECHO_RESPONSE, BNXT_USE_CHIMP_MB);\n+\treq.event_data1 = rte_cpu_to_le_32(echo_req_data1);\n+\treq.event_data2 = rte_cpu_to_le_32(echo_req_data2);\n+\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\n+\tHWRM_CHECK_RESULT();\n+\tHWRM_UNLOCK();\n+\n+\treturn rc;\n+}\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex 449cb91..c47c249 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -35,6 +35,8 @@ struct hwrm_func_qstats_output;\n \t(1 << (HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEBUG_NOTIFICATION - 32))\n #define\tASYNC_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE\t\\\n \t(1 << (HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE - 32))\n+#define\tASYNC_CMPL_EVENT_ID_ECHO_REQUEST\t\\\n+\t(1 << (HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ECHO_REQUEST - 64))\n \n #define HWRM_QUEUE_SERVICE_PROFILE_LOSSY \\\n \tHWRM_QUEUE_QPORTCFG_OUTPUT_QUEUE_ID0_SERVICE_PROFILE_LOSSY\n@@ -300,4 +302,6 @@ int bnxt_hwrm_first_vf_id_query(struct bnxt *bp, uint16_t fid,\n int bnxt_hwrm_cfa_pair_alloc(struct bnxt *bp, struct bnxt_representor *rep);\n int bnxt_hwrm_cfa_pair_free(struct bnxt *bp, struct bnxt_representor *rep);\n int bnxt_hwrm_cfa_adv_flow_mgmt_qcaps(struct bnxt *bp);\n+int bnxt_hwrm_fw_echo_reply(struct bnxt *bp, uint32_t echo_req_data1,\n+\t\t\t    uint32_t echo_req_data2);\n #endif\n",
    "prefixes": [
        "08/11"
    ]
}