Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88230/?format=api
{ "id": 88230, "url": "http://patchwork.dpdk.org/api/patches/88230/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210225152903.148347-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210225152903.148347-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210225152903.148347-3-bruce.richardson@intel.com", "date": "2021-02-25T15:29:02", "name": "[2/3] build: hide debug messages in non-developer mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b7720caf3fb44cf1d84c34544a3476b8b3a00585", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210225152903.148347-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15386, "url": "http://patchwork.dpdk.org/api/series/15386/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15386", "date": "2021-02-25T15:29:00", "name": "Add developer mode to DPDK build", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15386/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88230/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D74ADA034F;\n\tThu, 25 Feb 2021 16:29:28 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B674F1607FB;\n\tThu, 25 Feb 2021 16:29:23 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id E05D51607FB\n for <dev@dpdk.org>; Thu, 25 Feb 2021 16:29:20 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Feb 2021 07:29:20 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.204])\n by orsmga006.jf.intel.com with ESMTP; 25 Feb 2021 07:29:19 -0800" ], "IronPort-SDR": [ "\n WsEfflxxT9WY1oalIJJwQpxhYzhX5g38yVBtYo1aOTqj3X2Ba8xdduIO9CfBaIZypogRpFmzfM\n pJiViI2trLjA==", "\n MgCH+6tG3x+QJ2dcaz/KSc+uALeGC9DLhm/gZRvdqTD4CLwuiu7grnj4bO2SrLZIcDx2ionaTQ\n qBr3JDjvo6Xg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9905\"; a=\"249617662\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"249617662\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"367432368\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 25 Feb 2021 15:29:02 +0000", "Message-Id": "<20210225152903.148347-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210225152903.148347-1-bruce.richardson@intel.com>", "References": "<20210225152903.148347-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/3] build: hide debug messages in non-developer\n mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The messages about what components have what dependency names, and\ninformation about function versioning not being supported on windows are\nonly of interest to developers, so hide them when building in\nnon-developer mode.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 6 ++++--\n lib/meson.build | 10 ++++++----\n 2 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex fdf76120ac..b26051c21c 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -208,8 +208,10 @@ foreach subpath:subdirs\n \t\t\tset_variable('shared_@0@'.format(lib_name), shared_dep)\n \t\t\tset_variable('static_@0@'.format(lib_name), static_dep)\n \t\t\tdependency_name = ''.join(lib_name.split('rte_'))\n-\t\t\tmessage('drivers/@0@: Defining dependency \"@1@\"'.format(\n-\t\t\t\t\tdrv_path, dependency_name))\n+\t\t\tif developer_mode\n+\t\t\t\tmessage('drivers/@0@: Defining dependency \"@1@\"'.format(\n+\t\t\t\t\t\tdrv_path, dependency_name))\n+\t\t\tendif\n \t\tendif # build\n \tendforeach\n \ndiff --git a/lib/meson.build b/lib/meson.build\nindex 7712aa4977..b378050299 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -115,9 +115,9 @@ foreach l:libraries\n \t\t\tshared_dep = declare_dependency(include_directories: includes)\n \t\t\tstatic_dep = shared_dep\n \t\telse\n-\t\t\tif is_windows and use_function_versioning\n+\t\t\tif is_windows and use_function_versioning and developer_mode\n \t\t\t\tmessage('@0@: Function versioning is not supported by Windows.'\n-\t\t\t\t.format(name))\n+\t\t\t\t\t\t.format(name))\n \t\t\tendif\n \n \t\t\tif use_function_versioning\n@@ -206,7 +206,9 @@ foreach l:libraries\n \n \t\tset_variable('shared_rte_' + name, shared_dep)\n \t\tset_variable('static_rte_' + name, static_dep)\n-\t\tmessage('lib/@0@: Defining dependency \"@1@\"'.format(\n-\t\t\t\tdir_name, name))\n+\t\tif developer_mode\n+\t\t\tmessage('lib/@0@: Defining dependency \"@1@\"'.format(\n+\t\t\t\t\tdir_name, name))\n+\t\tendif\n \tendif # if build\n endforeach\n", "prefixes": [ "2/3" ] }