Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88231/?format=api
{ "id": 88231, "url": "http://patchwork.dpdk.org/api/patches/88231/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210225152903.148347-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210225152903.148347-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210225152903.148347-4-bruce.richardson@intel.com", "date": "2021-02-25T15:29:03", "name": "[3/3] build: limit symbol checks to developer mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a2bf6244be2e0a2cd0b97425efcc117dc4e2b7a0", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210225152903.148347-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15386, "url": "http://patchwork.dpdk.org/api/series/15386/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15386", "date": "2021-02-25T15:29:00", "name": "Add developer mode to DPDK build", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15386/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88231/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/88231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1CAEA034F;\n\tThu, 25 Feb 2021 16:29:35 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 056B4160884;\n\tThu, 25 Feb 2021 16:29:26 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id F417A40692\n for <dev@dpdk.org>; Thu, 25 Feb 2021 16:29:22 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Feb 2021 07:29:22 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.204])\n by orsmga006.jf.intel.com with ESMTP; 25 Feb 2021 07:29:21 -0800" ], "IronPort-SDR": [ "\n aDcjRomAwC79mCw2Vp3lksil0q2o8886FFU401Hr9+OyXplgYEIFsGNK3bJnbZFwXvTgJXMjT7\n qJc3/dteyaLQ==", "\n k8EEi/HenQXNl9quuYoOeUwDv5iqLUVZrSLYtA6VdOJRW7YqLnImsv0COhJ5AxYVqbXNRHhMlM\n v62mYebx8kRQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9905\"; a=\"249617674\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"249617674\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"367432377\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 25 Feb 2021 15:29:03 +0000", "Message-Id": "<20210225152903.148347-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210225152903.148347-1-bruce.richardson@intel.com>", "References": "<20210225152903.148347-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] build: limit symbol checks to developer mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The checking of symbols within each library and driver is only of\ninterest to developers, so limit to developer mode only.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 20 +++++++++++---------\n lib/meson.build | 2 +-\n 2 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex b26051c21c..54af1f132f 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -170,15 +170,17 @@ foreach subpath:subdirs\n \t\t\t\tendif\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n-\t\t\t\t# on unix systems check the output of the\n-\t\t\t\t# check-symbols.sh script, using it as a\n-\t\t\t\t# dependency of the .so build\n-\t\t\t\tlk_deps += custom_target(lib_name + '.sym_chk',\n-\t\t\t\t\tcommand: [check_symbols,\n-\t\t\t\t\t\tversion_map, '@INPUT@'],\n-\t\t\t\t\tcapture: true,\n-\t\t\t\t\tinput: static_lib,\n-\t\t\t\t\toutput: lib_name + '.sym_chk')\n+\t\t\t\tif developer_mode\n+\t\t\t\t\t# on unix systems check the output of the\n+\t\t\t\t\t# check-symbols.sh script, using it as a\n+\t\t\t\t\t# dependency of the .so build\n+\t\t\t\t\tlk_deps += custom_target(lib_name + '.sym_chk',\n+\t\t\t\t\t\tcommand: [check_symbols,\n+\t\t\t\t\t\t\tversion_map, '@INPUT@'],\n+\t\t\t\t\t\tcapture: true,\n+\t\t\t\t\t\tinput: static_lib,\n+\t\t\t\t\t\toutput: lib_name + '.sym_chk')\n+\t\t\t\tendif\n \t\t\tendif\n \n \t\t\tshared_lib = shared_library(lib_name,\ndiff --git a/lib/meson.build b/lib/meson.build\nindex b378050299..d003ad3dfe 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -173,7 +173,7 @@ foreach l:libraries\n \t\t\tendif\n \n \t\t\tlk_deps = [version_map, def_file, mingw_map]\n-\t\t\tif not is_windows\n+\t\t\tif developer_mode and not is_windows\n \t\t\t\t# on unix systems check the output of the\n \t\t\t\t# check-symbols.sh script, using it as a\n \t\t\t\t# dependency of the .so build\n", "prefixes": [ "3/3" ] }