Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88762/?format=api
{ "id": 88762, "url": "http://patchwork.dpdk.org/api/patches/88762/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210309233116.1934666-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210309233116.1934666-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210309233116.1934666-3-thomas@monjalon.net", "date": "2021-03-09T23:31:06", "name": "[02/11] eal: improve options usage text", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e9dd4e5fdea2f3595ca8cb76e6586e01ff6b33ca", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210309233116.1934666-3-thomas@monjalon.net/mbox/", "series": [ { "id": 15554, "url": "http://patchwork.dpdk.org/api/series/15554/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15554", "date": "2021-03-09T23:31:04", "name": "improve options help", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15554/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88762/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3A76A0567;\n\tWed, 10 Mar 2021 00:31:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5491522A556;\n\tWed, 10 Mar 2021 00:31:44 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C716B22A535\n for <dev@dpdk.org>; Wed, 10 Mar 2021 00:31:42 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id 794695C0094;\n Tue, 9 Mar 2021 18:31:42 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Tue, 09 Mar 2021 18:31:42 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id F1DC524005E;\n Tue, 9 Mar 2021 18:31:40 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=zFZQ/OVIs26CT\n S/5cSETH6uU4SwlQijreQHjhnc3KmM=; b=sZVqnKJJduhCMvFx9nE+3iS/onHQg\n saw4jS10VjqTKKAMJ0zfea0ocUID/bScmRzZQuBSrHpOfsYP7MJ/frVwD2zmczUq\n 8qAon5nrgX25KjzHy/2YvJ0q2YJgU0bQMxwpqc2utzsqdcggPkCecUiuL3Ioe3JU\n ov8adLBD1zkUsj6GAejHOsmD+TAJU3j9OBpinU6Sa2RR3RnTSUnsU96sZmTjPA8D\n eo6tIXRbU7oDOH0yEigCplCVrEW2bniP5Cf64DQ46TsZgZmIAKdqShKUJ6KsYYcn\n XdIiYTXtmMOlGNPZNNM7HNVACeMc31HRXT3Tfi12E0VYtW6s09KpwLOAQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=zFZQ/OVIs26CTS/5cSETH6uU4SwlQijreQHjhnc3KmM=; b=MVYeHYWb\n jZ76ev/2Elf2L24h5uTGD0mOJmZaq5jGgb602Pat0vA07SgWn663xGuu+RXYtWgz\n Wrl723b9vjkWkN5U3ilICLzLlnwB+2J27H49GlU0ZlmSDKAI9lgnEL6ncqoXxYep\n z0JVh11Aita7qgEPbuMsyPXSlRAvCg75XlSvLYJqxKEHCngGP8Xt/aqb+yZ3Lbo3\n BdopM8X12iKzvQAKFvJn1UeqRL2uSNcXyxpXVI3+rzNjJygU3tUUtVLLPFHb8Yns\n UxUqe4Yt920cnApd6Idb3HzpDbCANT/GvktCobRqpKqJMkhBsJ8b13FdZnjv/bLL\n 1DadJT/bLlMJVA==" ], "X-ME-Sender": "<xms:XQVIYNvnWtGrZU5_HmeFqfydrgQhCveyj8Vcmq8RHY1p81N2tz0hnQ>\n <xme:XQVIYGb7XOBynGbkggvNpSModiqf0XrcMLjazf53FQmENCgdT73c0H6NL0K4dCwx6\n FAUw51saOWzR9AOag>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgudejgecutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedt\n gfeutdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:XQVIYNqjoehBMxl4TG5C3g6Ze16efk4KikMV9PwuJYhtLHt1eb96qQ>\n <xmx:XQVIYL-MqyCWi8TBPXUezIv51PFM_-3js39PTFV1DPP7zDHEA78KJw>\n <xmx:XQVIYM-QkXohKNNk0w7D8jdVbj543_4yalwdE6ooOiulmA_LJYL7tg>\n <xmx:XgVIYMiw-w4jN63ApqkSWFrv8O_yqQmchw8xSATOJgKG2WdyqeUddw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Date": "Wed, 10 Mar 2021 00:31:06 +0100", "Message-Id": "<20210309233116.1934666-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210309233116.1934666-1-thomas@monjalon.net>", "References": "<20210309233116.1934666-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/11] eal: improve options usage text", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The description of the EAL options was printed before the application\ndescription provided via the hook.\nIt is better to let the application print the global syntax\nand describes the detail of the EAL options below.\n\nAlso, some useless lines are removed,\nand the alignment of few options is fixed.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_eal/common/eal_common_options.c | 11 +++++------\n lib/librte_eal/freebsd/eal.c | 8 ++++----\n lib/librte_eal/linux/eal.c | 12 ++++++------\n lib/librte_eal/windows/eal.c | 10 ++++------\n 4 files changed, 19 insertions(+), 22 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 622c7bc429..0635b0d4ce 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -2022,8 +2022,7 @@ rte_vect_set_max_simd_bitwidth(uint16_t bitwidth)\n void\n eal_common_usage(void)\n {\n-\tprintf(\"[options]\\n\\n\"\n-\t \"EAL common options:\\n\"\n+\tprintf(\"EAL common options:\\n\"\n \t \" -c COREMASK Hexadecimal bitmask of cores to run on\\n\"\n \t \" -l CORELIST List of cores to run on\\n\"\n \t \" The argument format is <c1>[-c2][,c3[-c4],...]\\n\"\n@@ -2053,7 +2052,7 @@ eal_common_usage(void)\n \t \" --\"OPT_VDEV\" Add a virtual device.\\n\"\n \t \" The argument format is <driver><id>[,key=val,...]\\n\"\n \t \" (ex: --vdev=net_pcap0,iface=eth2).\\n\"\n-\t \" --\"OPT_IOVA_MODE\" Set IOVA mode. 'pa' for IOVA_PA\\n\"\n+\t \" --\"OPT_IOVA_MODE\" Set IOVA mode. 'pa' for IOVA_PA\\n\"\n \t \" 'va' for IOVA_VA\\n\"\n \t \" -d LIB.so|DIR Add a driver or driver directory\\n\"\n \t \" (can be used multiple times)\\n\"\n@@ -2092,11 +2091,11 @@ eal_common_usage(void)\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \t \" -v Display version information on startup\\n\"\n \t \" -h, --help This help\\n\"\n-\t \" --\"OPT_IN_MEMORY\" Operate entirely in memory. This will\\n\"\n+\t \" --\"OPT_IN_MEMORY\" Operate entirely in memory. This will\\n\"\n \t \" disable secondary process support\\n\"\n \t \" --\"OPT_BASE_VIRTADDR\" Base virtual address\\n\"\n-\t \" --\"OPT_TELEMETRY\" Enable telemetry support (on by default)\\n\"\n-\t \" --\"OPT_NO_TELEMETRY\" Disable telemetry support\\n\"\n+\t \" --\"OPT_TELEMETRY\" Enable telemetry support (on by default)\\n\"\n+\t \" --\"OPT_NO_TELEMETRY\" Disable telemetry support\\n\"\n \t \" --\"OPT_FORCE_MAX_SIMD_BITWIDTH\" Force the max SIMD bitwidth\\n\"\n \t \"\\nEAL options for DEBUG use only:\\n\"\n \t \" --\"OPT_HUGE_UNLINK\" Unlink hugepage files after init\\n\"\ndiff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c\nindex afbbb1c523..f466616566 100644\n--- a/lib/librte_eal/freebsd/eal.c\n+++ b/lib/librte_eal/freebsd/eal.c\n@@ -421,13 +421,13 @@ eal_usage(const char *prgname)\n {\n \trte_usage_hook_t hook = eal_get_application_usage_hook();\n \n-\tprintf(\"\\nUsage: %s \", prgname);\n-\teal_common_usage();\n-\t/* Allow the application to print its usage message too if hook is set */\n \tif (hook) {\n-\t\tprintf(\"===== Application Usage =====\\n\\n\");\n+\t\t/* Print application usage through EAL options parsing. */\n \t\t(hook)(prgname);\n+\t\tprintf(\"\\n\");\n \t}\n+\n+\teal_common_usage();\n }\n \n static inline size_t\ndiff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c\nindex bc966150a5..7c1d296192 100644\n--- a/lib/librte_eal/linux/eal.c\n+++ b/lib/librte_eal/linux/eal.c\n@@ -534,7 +534,12 @@ eal_usage(const char *prgname)\n {\n \trte_usage_hook_t hook = eal_get_application_usage_hook();\n \n-\tprintf(\"\\nUsage: %s \", prgname);\n+\tif (hook) {\n+\t\t/* Print application usage through EAL options parsing. */\n+\t\t(hook)(prgname);\n+\t\tprintf(\"\\n\");\n+\t}\n+\n \teal_common_usage();\n \tprintf(\"EAL Linux options:\\n\"\n \t \" --\"OPT_SOCKET_MEM\" Memory to allocate on sockets (comma separated values)\\n\"\n@@ -548,11 +553,6 @@ eal_usage(const char *prgname)\n \t \" --\"OPT_SINGLE_FILE_SEGMENTS\" Put all hugepage memory in single files\\n\"\n \t \" --\"OPT_MATCH_ALLOCATIONS\" Free hugepages exactly as allocated\\n\"\n \t \"\\n\");\n-\t/* Allow the application to print its usage message too if hook is set */\n-\tif (hook) {\n-\t\tprintf(\"===== Application Usage =====\\n\\n\");\n-\t\t(hook)(prgname);\n-\t}\n }\n \n static int\ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex 2fc3d6141c..ec13ac1a9f 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -79,15 +79,13 @@ eal_usage(const char *prgname)\n {\n \trte_usage_hook_t hook = eal_get_application_usage_hook();\n \n-\tprintf(\"\\nUsage: %s \", prgname);\n-\teal_common_usage();\n-\t/* Allow the application to print its usage message too\n-\t * if hook is set\n-\t */\n \tif (hook) {\n-\t\tprintf(\"===== Application Usage =====\\n\\n\");\n+\t\t/* Print application usage through EAL options parsing. */\n \t\t(hook)(prgname);\n+\t\tprintf(\"\\n\");\n \t}\n+\n+\teal_common_usage();\n }\n \n /* Parse the arguments for --log-level only */\n", "prefixes": [ "02/11" ] }