Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88812,
    "url": "http://patchwork.dpdk.org/api/patches/88812/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1615358466-12761-1-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1615358466-12761-1-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1615358466-12761-1-git-send-email-roretzla@linux.microsoft.com",
    "date": "2021-03-10T06:41:06",
    "name": "librte_eal/common: fix return type of rte_bsf64",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "2d6026aa50a6c3a2ae77524c40b3f866412465e6",
    "submitter": {
        "id": 2077,
        "url": "http://patchwork.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1615358466-12761-1-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 15565,
            "url": "http://patchwork.dpdk.org/api/series/15565/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15565",
            "date": "2021-03-10T06:41:06",
            "name": "librte_eal/common: fix return type of rte_bsf64",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/15565/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/88812/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/88812/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C11D6A0567;\n\tWed, 10 Mar 2021 07:41:13 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B94822A2D6;\n\tWed, 10 Mar 2021 07:41:13 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 683544068C\n for <dev@dpdk.org>; Wed, 10 Mar 2021 07:41:12 +0100 (CET)",
            "from\n linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net\n (linux.microsoft.com [13.77.154.182])\n by linux.microsoft.com (Postfix) with ESMTPSA id 92F37208CF95;\n Tue,  9 Mar 2021 22:41:11 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 92F37208CF95",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1615358471;\n bh=vYh6fY5qZhghX/zByCnsZNtpzgUnVUjfh2pal7u12S8=;\n h=From:To:Cc:Subject:Date:From;\n b=h+pCRzS7nJFiA00D6+RdMAi0rFixEobPh1gPYG4MvzwTIGfilufaIV+ye9HTdNewL\n FqEbqSgX18HshQLS/uet6D7xUEi7w1oENudlLvrv77RkfI4Tz00wGzw6BMlZL/s96W\n Nlwx6j64HSreJvLtpYj3IOve2OxrnlQybP0x5r4Q=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "anatoly.burakov@intel.com",
        "Date": "Tue,  9 Mar 2021 22:41:06 -0800",
        "Message-Id": "<1615358466-12761-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "based on the original commit and the usage of rte_bsf64 it appears the\nfunction should always have returned uint32_t instead of int which is\nconsistent with the cast introduced in the return statement.\n\nFixes: 4e261f551986 (\"eal: add 64-bit bsf and 32-bit safe bsf\nfunctions\")\nCc: anatoly.burakov@intel.com\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/librte_eal/include/rte_common.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h\nindex 1b630baf1..5e70ee7a8 100644\n--- a/lib/librte_eal/include/rte_common.h\n+++ b/lib/librte_eal/include/rte_common.h\n@@ -679,7 +679,7 @@ rte_fls_u32(uint32_t x)\n  * @return\n  *     least significant set bit in the input parameter.\n  */\n-static inline int\n+static inline uint32_t\n rte_bsf64(uint64_t v)\n {\n \treturn (uint32_t)__builtin_ctzll(v);\n",
    "prefixes": []
}