Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88870/?format=api
{ "id": 88870, "url": "http://patchwork.dpdk.org/api/patches/88870/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210310135353.8429-2-wisamm@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210310135353.8429-2-wisamm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210310135353.8429-2-wisamm@nvidia.com", "date": "2021-03-10T13:53:47", "name": "[v3,1/7] app/flow-perf: start using more generic wrapper for cycles", "commit_ref": null, "pull_url": null, "state": "new", "archived": true, "hash": "8e2d3c24316a2a2f7fe4b735d06b63e94cd4e66e", "submitter": { "id": 1963, "url": "http://patchwork.dpdk.org/api/people/1963/?format=api", "name": "Wisam Monther", "email": "wisamm@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210310135353.8429-2-wisamm@nvidia.com/mbox/", "series": [ { "id": 15582, "url": "http://patchwork.dpdk.org/api/series/15582/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15582", "date": "2021-03-10T13:53:46", "name": "Enhancements and fixes for flow-perf", "version": 3, "mbox": "http://patchwork.dpdk.org/series/15582/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88870/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88870/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17480A0567;\n\tWed, 10 Mar 2021 14:54:16 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1A46522A55C;\n\tWed, 10 Mar 2021 14:54:14 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65])\n by mails.dpdk.org (Postfix) with ESMTP id B893222A536\n for <dev@dpdk.org>; Wed, 10 Mar 2021 14:54:12 +0100 (CET)", "from BN9PR03CA0799.namprd03.prod.outlook.com (2603:10b6:408:13f::24)\n by DM5PR12MB1275.namprd12.prod.outlook.com (2603:10b6:3:75::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar\n 2021 13:54:10 +0000", "from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:13f:cafe::7d) by BN9PR03CA0799.outlook.office365.com\n (2603:10b6:408:13f::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend\n Transport; Wed, 10 Mar 2021 13:54:10 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 13:54:10 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar\n 2021 13:54:08 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jCbTs1vdBzY6cH875rgLtk0oldyp1JE3cRrkmScVYztFR3ransaCq21dQgxHCC0YtMAxwa6xhkt+yVQZb4vGeFfmZnPvW/Bq6AfMgAbHdjqZwkMsyAyxo31ssHS4yY5t2Pha/eZyYwhk1XahdyXVFGtuValXVgXOtaN4iUuZWb7FwnKeb178AGmyw8l58YG0vo+tjE2giVwgBaJg0rEtwez+1sqQHt0fm6tjBk1TgCTjhBIFZIR5/cSzhs2g+lpTgfXptbqqVZQiyevmw2js4J8C7S592ai8udRBJpM2vo2suhv6youYbaYt3TnxqcdxJ6VSrSN3+dikWSmNkgFV3g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kHzuYpqhDFPLbS8TFa0kQ2R70un0RICthcjLlHQinYQ=;\n b=eymMdvCgjvPw8Op08sjuX6xioJ8pG0JJnnRXt1X6d2xczWzF6d0KBa5nwx7Foe2IcuoC7pGVNnpjON8ILfxlexG+ZkQZkXm4Tj503TpxMOrnqy0P1IDtTvP4j34IEWEWiM9rUj658lD+T11o2bXHvpohNVx/gXfAW8FP+QwFitWMIqWmnaRTRNja86fpvqX5F40j0IZwwM2Ut9vSHfIJCVb1PA3lo1KmbkYm3zemtsGJWHslMzrZRQ8pHIJ87OPHoDN91pjsoA/j7EdX1foUtWyuSiWeydtbO6/gwVOYdpV5Vy9ug6yrzQgaY3OtbV2JD0+Z5vfEc3u9r7XcONGntA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kHzuYpqhDFPLbS8TFa0kQ2R70un0RICthcjLlHQinYQ=;\n b=etrQWla9bltfW7W+SJ/KjmuZZz0PYLJIAXHW57XcXRrOkTdOOU0JXvfcdIrtfJrpOu3Wb9/rY0M2VCzowwvrzwPXQqtNAP4gUzAjAhHeBnu/XfCrCQ2rXYBbWN6b2hf+Fr51h83P71eSEaX63PH92TA1bh76MDHYnxFY/u6p/X32xuaeXJUzFYBAAiFKwKBNxB+RaLU6A+3PehB9802rTY20tr+H7TPMCM6V4L+TJ2NdR0Q0d7wO3SjJ0iOAjKmgVTL77w3CDA2cYggclKucFLFHs+m4o2CB8NLQalntCkfQb4LDrbGvn2kUt1kh5OJMpHp9hO4ZzVpVPBSKbR+sUQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Wisam Jaddo <wisamm@nvidia.com>", "To": "<arybchenko@solarflare.com>, <thomas@monjalon.net>, <akozyrev@nvidia.com>,\n <rasland@nvidia.com>, <dev@dpdk.org>", "Date": "Wed, 10 Mar 2021 15:53:47 +0200", "Message-ID": "<20210310135353.8429-2-wisamm@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210310135353.8429-1-wisamm@nvidia.com>", "References": "<20210310134858.8104-2-wisamm@nvidia.com>\n <20210310135353.8429-1-wisamm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "470d8db8-351c-45c7-e2c5-08d8e3cbfb2e", "X-MS-TrafficTypeDiagnostic": "DM5PR12MB1275:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <DM5PR12MB127524A82499C5C9E395CEF7A4919@DM5PR12MB1275.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1051;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ZL7mC9sMsuotw7BVZJb8UM+3Br0QiUpr5aD0QjRioEDLag79XTTsq7Pqz1VpXjhw2pyfa6pjlPirz7HzP/IFtKmbp+roysOdtTb7KR4LBT7aw+qO0mGotMAlMh0jXzylJHLWi8/aiNoTc4GM8SDItruJztjPKWmfpka371sBl6Uetnw/OhTnM34029Vn5VDseIadIncHBNAU6QhOpaUrqon4sV6Ck7RoFPeM9/rr1gYyHNvwkD3rrJGC1OIHtiH4w7KtglkXSE4qpdYz7Ql/nn7usaAi3Q84Vxuxj9esFalZ0eq9o6Uo4ywU0gp76VGVHfYykl8ni+mecR/Zb82BjNtwim7ff4Pw4/KjVst2B/Xe9u1j61m0tC/0LsGc4G4/Ry/htgmMn3L1IE0dqTHhPX+BZnPp8g1B7j9h+AYw5TSuqr6zdjv75Qo9+bDNOsTVCnzbNKXuQFsfaLQkgwPgV+GJdgyG5A7ykjeHdVG8ZWd6HwAcwlmkavHZmW4qi4HCsv0clqEWoQmJCZ28Xic3hOFPKH5aw0JyWL/jkIExEtao1d693HDDBHhMLm94Qj/ex6t0KQNLAT3wYP5LO8Yv9mvkRp2++Ia7yvwwQ9WB1RiM+gHjkovlURHdEuYKeiN4FbqOvRiiCl2ew0nW4vAttjtMPAfuLAva+BhfsnIGD8Hu1j+JQha8jOyCwtNnst67K0k6siBnYsCgYw1IkCJcjg==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(46966006)(36840700001)(7636003)(47076005)(2906002)(110136005)(36906005)(83380400001)(6286002)(316002)(186003)(55016002)(7696005)(16526019)(8936002)(8676002)(356005)(5660300002)(82310400003)(36756003)(34020700004)(82740400003)(70586007)(70206006)(1076003)(36860700001)(86362001)(426003)(478600001)(6666004)(26005)(2616005)(336012)(41533002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Mar 2021 13:54:10.3316 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 470d8db8-351c-45c7-e2c5-08d8e3cbfb2e", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT035.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR12MB1275", "Subject": "[dpdk-dev] [PATCH v3 1/7] app/flow-perf: start using more generic\n wrapper for cycles", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rdtsc() is x86 related, while this might fail for other archs,\nso it's better to use more generic API for cycles measurement.\n\nSigned-off-by: Wisam Jaddo <wisamm@nvidia.com>\n---\n app/test-flow-perf/main.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 99d0463456..8b5a11c15e 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -969,7 +969,7 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops)\n \tend_counter = (core_id + 1) * rules_count_per_core;\n \n \tcpu_time_used = 0;\n-\tstart_batch = rte_rdtsc();\n+\tstart_batch = rte_get_timer_cycles();\n \tfor (counter = start_counter; counter < end_counter; counter++) {\n \t\tif (ops == METER_CREATE)\n \t\t\tcreate_meter_rule(port_id, counter);\n@@ -984,10 +984,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops)\n \t\tif (!((counter + 1) % rules_batch)) {\n \t\t\trules_batch_idx = ((counter + 1) / rules_batch) - 1;\n \t\t\tcpu_time_per_batch[rules_batch_idx] =\n-\t\t\t\t((double)(rte_rdtsc() - start_batch))\n-\t\t\t\t/ rte_get_tsc_hz();\n+\t\t\t\t((double)(rte_get_timer_cycles() - start_batch))\n+\t\t\t\t/ rte_get_timer_hz();\n \t\t\tcpu_time_used += cpu_time_per_batch[rules_batch_idx];\n-\t\t\tstart_batch = rte_rdtsc();\n+\t\t\tstart_batch = rte_get_timer_cycles();\n \t\t}\n \t}\n \n@@ -1089,7 +1089,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)\n \tif (flow_group > 0 && core_id == 0)\n \t\trules_count_per_core++;\n \n-\tstart_batch = rte_rdtsc();\n+\tstart_batch = rte_get_timer_cycles();\n \tfor (i = 0; i < (uint32_t) rules_count_per_core; i++) {\n \t\tif (flows_list[i] == 0)\n \t\t\tbreak;\n@@ -1107,12 +1107,12 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)\n \t\t * for this batch.\n \t\t */\n \t\tif (!((i + 1) % rules_batch)) {\n-\t\t\tend_batch = rte_rdtsc();\n+\t\t\tend_batch = rte_get_timer_cycles();\n \t\t\tdelta = (double) (end_batch - start_batch);\n \t\t\trules_batch_idx = ((i + 1) / rules_batch) - 1;\n-\t\t\tcpu_time_per_batch[rules_batch_idx] = delta / rte_get_tsc_hz();\n+\t\t\tcpu_time_per_batch[rules_batch_idx] = delta / rte_get_timer_hz();\n \t\t\tcpu_time_used += cpu_time_per_batch[rules_batch_idx];\n-\t\t\tstart_batch = rte_rdtsc();\n+\t\t\tstart_batch = rte_get_timer_cycles();\n \t\t}\n \t}\n \n@@ -1185,7 +1185,7 @@ insert_flows(int port_id, uint8_t core_id)\n \t\tflows_list[flow_index++] = flow;\n \t}\n \n-\tstart_batch = rte_rdtsc();\n+\tstart_batch = rte_get_timer_cycles();\n \tfor (counter = start_counter; counter < end_counter; counter++) {\n \t\tflow = generate_flow(port_id, flow_group,\n \t\t\tflow_attrs, flow_items, flow_actions,\n@@ -1211,12 +1211,12 @@ insert_flows(int port_id, uint8_t core_id)\n \t\t * for this batch.\n \t\t */\n \t\tif (!((counter + 1) % rules_batch)) {\n-\t\t\tend_batch = rte_rdtsc();\n+\t\t\tend_batch = rte_get_timer_cycles();\n \t\t\tdelta = (double) (end_batch - start_batch);\n \t\t\trules_batch_idx = ((counter + 1) / rules_batch) - 1;\n-\t\t\tcpu_time_per_batch[rules_batch_idx] = delta / rte_get_tsc_hz();\n+\t\t\tcpu_time_per_batch[rules_batch_idx] = delta / rte_get_timer_hz();\n \t\t\tcpu_time_used += cpu_time_per_batch[rules_batch_idx];\n-\t\t\tstart_batch = rte_rdtsc();\n+\t\t\tstart_batch = rte_get_timer_cycles();\n \t\t}\n \t}\n \n", "prefixes": [ "v3", "1/7" ] }