Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88891/?format=api
{ "id": 88891, "url": "http://patchwork.dpdk.org/api/patches/88891/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210310172430.412405-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210310172430.412405-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210310172430.412405-3-bruce.richardson@intel.com", "date": "2021-03-10T17:24:28", "name": "[2/4] telemetry: make the legacy registration function internal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2d416853c1c2ebba142252178570bbbcdac14a51", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210310172430.412405-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15587, "url": "http://patchwork.dpdk.org/api/series/15587/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15587", "date": "2021-03-10T17:24:26", "name": "telemetry logging improvements and cleanup", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15587/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88891/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88891/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46BFDA056A;\n\tWed, 10 Mar 2021 18:24:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 32A8F22A3C2;\n\tWed, 10 Mar 2021 18:24:54 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id F1F6C22A3AC\n for <dev@dpdk.org>; Wed, 10 Mar 2021 18:24:51 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Mar 2021 09:24:47 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.188])\n by orsmga008.jf.intel.com with ESMTP; 10 Mar 2021 09:24:46 -0800" ], "IronPort-SDR": [ "\n 9dRGjqe47AfPtpJ6SKkiNg0l9qLLm/zV29A7qWdD3tB7TI34Qh7lnDJ2hCEqAAnDIK++vcVnS3\n f0PntnGYJGhw==", "\n dbRJQW43GY4ruCszICgtONrXr384unCGc9pPh4cpiY6VhqSb+Hp7dVGaxwxXD7CBfIq6Q4UrCy\n I1Lolh8oCfGQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9919\"; a=\"185164649\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"185164649\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"410271688\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>", "Date": "Wed, 10 Mar 2021 17:24:28 +0000", "Message-Id": "<20210310172430.412405-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210310172430.412405-1-bruce.richardson@intel.com>", "References": "<20210310172430.412405-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration\n function internal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function for registration of callbacks for legacy telemetry was\ndocumented as internal-only in the API documents, but marked as\nexperimental in the version.map file. Since this is an internal-only\nfunction, for consistency we update the version mapping to have it as\ninternal.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/rel_notes/release_21_05.rst | 5 +++++\n lib/librte_telemetry/rte_telemetry_legacy.h | 2 +-\n lib/librte_telemetry/version.map | 2 +-\n 3 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst\nindex 23f7f0bff9..1624f43d73 100644\n--- a/doc/guides/rel_notes/release_21_05.rst\n+++ b/doc/guides/rel_notes/release_21_05.rst\n@@ -117,6 +117,11 @@ ABI Changes\n \n * No ABI change that would break compatibility with 20.11.\n \n+* The experimental function ``rte_telemetry_legacy_register`` has been\n+ removed from the public API and is now an internal-only function. This\n+ function was already marked as internal in the API documentation for it,\n+ and was not for use by external applications.\n+\n \n Known Issues\n ------------\ndiff --git a/lib/librte_telemetry/rte_telemetry_legacy.h b/lib/librte_telemetry/rte_telemetry_legacy.h\nindex c83f9a8d90..fb44740186 100644\n--- a/lib/librte_telemetry/rte_telemetry_legacy.h\n+++ b/lib/librte_telemetry/rte_telemetry_legacy.h\n@@ -78,7 +78,7 @@ legacy_client_handler(void *sock_id);\n * @return\n * -ENOENT if max callbacks limit has been reached.\n */\n-__rte_experimental\n+__rte_internal\n int\n rte_telemetry_legacy_register(const char *cmd,\n \t\tenum rte_telemetry_legacy_data_req data_req,\ndiff --git a/lib/librte_telemetry/version.map b/lib/librte_telemetry/version.map\nindex ec0ebc1bec..bde80ce29b 100644\n--- a/lib/librte_telemetry/version.map\n+++ b/lib/librte_telemetry/version.map\n@@ -14,12 +14,12 @@ EXPERIMENTAL {\n \trte_tel_data_start_array;\n \trte_tel_data_start_dict;\n \trte_tel_data_string;\n-\trte_telemetry_legacy_register;\n \trte_telemetry_register_cmd;\n \n \tlocal: *;\n };\n \n INTERNAL {\n+\trte_telemetry_legacy_register;\n \trte_telemetry_init;\n };\n", "prefixes": [ "2/4" ] }