Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88893/?format=api
{ "id": 88893, "url": "http://patchwork.dpdk.org/api/patches/88893/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210310172430.412405-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210310172430.412405-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210310172430.412405-5-bruce.richardson@intel.com", "date": "2021-03-10T17:24:30", "name": "[4/4] telemetry: move init function to internal header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e87002d76fa1300652ac7fb9b71b98c627d5144e", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210310172430.412405-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15587, "url": "http://patchwork.dpdk.org/api/series/15587/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15587", "date": "2021-03-10T17:24:26", "name": "telemetry logging improvements and cleanup", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15587/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88893/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88893/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 37E06A056A;\n\tWed, 10 Mar 2021 18:25:11 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EDC8322A400;\n\tWed, 10 Mar 2021 18:24:56 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 7956640F35\n for <dev@dpdk.org>; Wed, 10 Mar 2021 18:24:53 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Mar 2021 09:24:53 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.188])\n by orsmga008.jf.intel.com with ESMTP; 10 Mar 2021 09:24:52 -0800" ], "IronPort-SDR": [ "\n GJ2MbEHFJCgMwIJXp1Dtk0aM2kuf5fMDQwQ5CJvDOzudn1zWes9WGFXeYa47P7pVS4CFXc7gD+\n NHES7XgPG1FA==", "\n EHAGuGzB7bLq6P4yPEWjnZloQW7A29bDFTMcqT2UGsposw65v3mEDLkIuomiir8FLEzXZodD/C\n lFlywQjgo3iw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9919\"; a=\"185164660\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"185164660\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"410271733\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>", "Date": "Wed, 10 Mar 2021 17:24:30 +0000", "Message-Id": "<20210310172430.412405-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210310172430.412405-1-bruce.richardson@intel.com>", "References": "<20210310172430.412405-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/4] telemetry: move init function to internal\n header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_telemetry_init() function is for EAL use only, so can be moved to\nthe internal header rather than being in the public one.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/freebsd/eal.c | 2 +-\n lib/librte_eal/linux/eal.c | 2 +-\n lib/librte_telemetry/rte_telemetry.h | 29 -----------------------\n lib/librte_telemetry/telemetry_internal.h | 29 +++++++++++++++++++++++\n 4 files changed, 31 insertions(+), 31 deletions(-)", "diff": "diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c\nindex b8a798bc7d..be02f70510 100644\n--- a/lib/librte_eal/freebsd/eal.c\n+++ b/lib/librte_eal/freebsd/eal.c\n@@ -42,7 +42,7 @@\n #include <rte_version.h>\n #include <rte_vfio.h>\n #include <malloc_heap.h>\n-#include <rte_telemetry.h>\n+#include <telemetry_internal.h>\n \n #include \"eal_private.h\"\n #include \"eal_thread.h\"\ndiff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c\nindex 23e3a32036..da2d6602a8 100644\n--- a/lib/librte_eal/linux/eal.c\n+++ b/lib/librte_eal/linux/eal.c\n@@ -49,8 +49,8 @@\n #include <rte_version.h>\n #include <malloc_heap.h>\n #include <rte_vfio.h>\n-#include <rte_telemetry.h>\n \n+#include <telemetry_internal.h>\n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n #include \"eal_internal_cfg.h\"\ndiff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h\nindex 2c3da3ab7f..334ea8ddd4 100644\n--- a/lib/librte_telemetry/rte_telemetry.h\n+++ b/lib/librte_telemetry/rte_telemetry.h\n@@ -292,35 +292,6 @@ __rte_experimental\n int\n rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help);\n \n-/**\n- * @internal\n- * Log function type, to allow passing as parameter if necessary\n- */\n-typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format, ...);\n-\n-/**\n- * @internal\n- * Initialize Telemetry.\n- *\n- * @param runtime_dir\n- * The runtime directory of DPDK.\n- * @param cpuset\n- * The CPU set to be used for setting the thread affinity.\n- * @param log_fn\n- * Function pointer to the rte_log function for logging use\n- * @param registered_logtype\n- * The registered log type to use for logging\n- *\n- * @return\n- * 0 on success.\n- * @return\n- * -1 on failure.\n- */\n-__rte_internal\n-int\n-rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype);\n-\n /**\n * Get a pointer to a container with memory allocated. The container is to be\n * used embedded within an existing telemetry dict/array.\ndiff --git a/lib/librte_telemetry/telemetry_internal.h b/lib/librte_telemetry/telemetry_internal.h\nindex ad076b9119..601f16cc96 100644\n--- a/lib/librte_telemetry/telemetry_internal.h\n+++ b/lib/librte_telemetry/telemetry_internal.h\n@@ -84,4 +84,33 @@ rte_telemetry_legacy_register(const char *cmd,\n \t\tenum rte_telemetry_legacy_data_req data_req,\n \t\ttelemetry_legacy_cb fn);\n \n+/**\n+ * @internal\n+ * Log function type, to allow passing as parameter if necessary\n+ */\n+typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format, ...);\n+\n+/**\n+ * @internal\n+ * Initialize Telemetry.\n+ *\n+ * @param runtime_dir\n+ * The runtime directory of DPDK.\n+ * @param cpuset\n+ * The CPU set to be used for setting the thread affinity.\n+ * @param log_fn\n+ * Function pointer to the rte_log function for logging use\n+ * @param registered_logtype\n+ * The registered log type to use for logging\n+ *\n+ * @return\n+ * 0 on success.\n+ * @return\n+ * -1 on failure.\n+ */\n+__rte_internal\n+int\n+rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,\n+\t\trte_log_fn log_fn, uint32_t registered_logtype);\n+\n #endif\n", "prefixes": [ "4/4" ] }