Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88997/?format=api
{ "id": 88997, "url": "http://patchwork.dpdk.org/api/patches/88997/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210312093143.28186-2-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210312093143.28186-2-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210312093143.28186-2-ivan.malov@oktetlabs.ru", "date": "2021-03-12T09:31:35", "name": "[02/10] ethdev: reuse header definition in flow pattern item VLAN", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1336e38c7463e7844ccf99fd0d2046fcdb5d69f0", "submitter": { "id": 869, "url": "http://patchwork.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210312093143.28186-2-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 15630, "url": "http://patchwork.dpdk.org/api/series/15630/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15630", "date": "2021-03-12T09:31:34", "name": "[01/10] ethdev: reuse header definition in flow pattern item ETH", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15630/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/88997/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/88997/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7431FA0547;\n\tFri, 12 Mar 2021 10:31:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7E44716084D;\n\tFri, 12 Mar 2021 10:31:51 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 593A01607ED\n for <dev@dpdk.org>; Fri, 12 Mar 2021 10:31:49 +0100 (CET)", "from localhost.localdomain (unknown [188.242.7.54])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0DC0D7F540;\n Fri, 12 Mar 2021 12:31:49 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0DC0D7F540", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1615541509;\n bh=FamZGMlRHqddOq750auHdvKrK0nFyaJ91v6ar4PfG5I=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=FO3mAx5PdHnKlleNux3a4UWkIeVSTJhiBql5ScjdM1kPvlacDWVeMaEtcS3VjJax3\n Nws8qYCmTBP0gD+A11XzENv6klZ9dO/jnCwYrVHugxVYwO5eu0G4vkOqxCsI5oIPve\n cA8Mah7QgbiAhagsAXrdpdyH4Dk2O5KBsCI2+NKE=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ori Kam <orika@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Fri, 12 Mar 2021 12:31:35 +0300", "Message-Id": "<20210312093143.28186-2-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210312093143.28186-1-ivan.malov@oktetlabs.ru>", "References": "<20210312093143.28186-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/10] ethdev: reuse header definition in flow\n pattern item VLAN", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "One ought to reuse existing header structs in flow items.\nThis particular item contains non-header fields, so it's\nimportant to keep the header fields in a separate struct.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n lib/librte_ethdev/rte_flow.h | 22 ++++++++++++++++------\n 1 file changed, 16 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex 96fd93ee1..b9b349669 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -778,13 +778,23 @@ static const struct rte_flow_item_eth rte_flow_item_eth_mask = {\n * If a @p VLAN item is present in the pattern, then only tagged packets will\n * match the pattern.\n * The field @p has_more_vlan can be used to match any type of tagged packets,\n- * instead of using the @p inner_type field.\n- * If the @p inner_type and @p has_more_vlan fields are not specified,\n+ * instead of using the @p eth_proto field of @p hdr.\n+ * If the @p eth_proto of @p hdr and @p has_more_vlan fields are not specified,\n * then any tagged packets will match the pattern.\n */\n+RTE_STD_C11\n struct rte_flow_item_vlan {\n-\trte_be16_t tci; /**< Tag control information. */\n-\trte_be16_t inner_type; /**< Inner EtherType or TPID. */\n+\tunion {\n+\t\tstruct {\n+\t\t\t/*\n+\t\t\t * These fields are retained for compatibility.\n+\t\t\t * Please switch to the new header field below.\n+\t\t\t */\n+\t\t\trte_be16_t tci; /**< Tag control information. */\n+\t\t\trte_be16_t inner_type; /**< Inner EtherType or TPID. */\n+\t\t};\n+\t\tstruct rte_vlan_hdr hdr;\n+\t};\n \tuint32_t has_more_vlan:1;\n \t/**< Packet header contains at least one more VLAN, after this VLAN. */\n \tuint32_t reserved:31; /**< Reserved, must be zero. */\n@@ -793,8 +803,8 @@ struct rte_flow_item_vlan {\n /** Default mask for RTE_FLOW_ITEM_TYPE_VLAN. */\n #ifndef __cplusplus\n static const struct rte_flow_item_vlan rte_flow_item_vlan_mask = {\n-\t.tci = RTE_BE16(0x0fff),\n-\t.inner_type = RTE_BE16(0x0000),\n+\t.hdr.vlan_tci = RTE_BE16(0x0fff),\n+\t.hdr.eth_proto = RTE_BE16(0x0000),\n };\n #endif\n \n", "prefixes": [ "02/10" ] }