Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89353/?format=api
{ "id": 89353, "url": "http://patchwork.dpdk.org/api/patches/89353/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1615969296-17021-4-git-send-email-wei.huang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1615969296-17021-4-git-send-email-wei.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1615969296-17021-4-git-send-email-wei.huang@intel.com", "date": "2021-03-17T08:21:35", "name": "[v1,3/4] raw/ifpga/base: assign unsigned value to length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f01e59efc0e7b310cee0a820c59595f4c1ea6c4a", "submitter": { "id": 2033, "url": "http://patchwork.dpdk.org/api/people/2033/?format=api", "name": "Wei Huang", "email": "wei.huang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1615969296-17021-4-git-send-email-wei.huang@intel.com/mbox/", "series": [ { "id": 15729, "url": "http://patchwork.dpdk.org/api/series/15729/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15729", "date": "2021-03-17T08:21:32", "name": "Fix coverity issues reported in DPDK-26380", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15729/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/89353/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/89353/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 61690A00C2;\n\tWed, 17 Mar 2021 09:21:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1D7C242B8E;\n\tWed, 17 Mar 2021 09:21:32 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 40D6F242B8B;\n Wed, 17 Mar 2021 09:21:30 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Mar 2021 01:21:29 -0700", "from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190])\n by fmsmga006.fm.intel.com with ESMTP; 17 Mar 2021 01:21:27 -0700" ], "IronPort-SDR": [ "\n rVX/O3pWNidfLNxoSrwkIwORbGzGEsmmTUFe+sy7SVRk6hcJddPvRCacxf1ISavePFzBBjXdxX\n DPtdBTjn/5FQ==", "\n ROmBbgwCiO1lJLvLzR+rT4aoPd/RAypzR3iF38C25g6ITYETI880ZDKvokqcmzOjc/OMMFxXn6\n xPHlNZ3LykuQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9925\"; a=\"274463935\"", "E=Sophos;i=\"5.81,255,1610438400\"; d=\"scan'208\";a=\"274463935\"", "E=Sophos;i=\"5.81,255,1610438400\"; d=\"scan'208\";a=\"602144384\"" ], "X-ExtLoop1": "1", "From": "Wei Huang <wei.huang@intel.com>", "To": "dev@dpdk.org,\n\trosen.xu@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "stable@dpdk.org, tianfei.zhang@intel.com, Wei Huang <wei.huang@intel.com>", "Date": "Wed, 17 Mar 2021 04:21:35 -0400", "Message-Id": "<1615969296-17021-4-git-send-email-wei.huang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1615969296-17021-1-git-send-email-wei.huang@intel.com>", "References": "<1615969296-17021-1-git-send-email-wei.huang@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 3/4] raw/ifpga/base: assign unsigned value to\n length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In fpga_update_flash(), \"smgr->rsu_length\" is passed to a\nparameter that cannot be negative. So return value of\nfunction \"lseek\" should be checked before being assigned\nto \"smgr->rsu_length\".\n\nCoverity issue: 367481\nFixes: 7a4f3993f269 (\"raw/ifpga: add FPGA RSU APIs\")\n\nSigned-off-by: Wei Huang <wei.huang@intel.com>\n---\n drivers/raw/ifpga/base/ifpga_fme_rsu.c | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/raw/ifpga/base/ifpga_fme_rsu.c b/drivers/raw/ifpga/base/ifpga_fme_rsu.c\nindex a4cb2f54ba..79ee37c282 100644\n--- a/drivers/raw/ifpga/base/ifpga_fme_rsu.c\n+++ b/drivers/raw/ifpga/base/ifpga_fme_rsu.c\n@@ -277,6 +277,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,\n \tstruct ifpga_sec_mgr *smgr = NULL;\n \tuint32_t rsu_stat = 0;\n \tint fd = -1;\n+\toff_t len = 0;\n \tstruct sigaction old_sigint_action;\n \tstruct sigaction sa;\n \ttime_t start;\n@@ -320,9 +321,21 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,\n \t\t\timage, strerror(errno));\n \t\treturn -EIO;\n \t}\n-\tsmgr->rsu_length = lseek(fd, 0, SEEK_END);\n+\tlen = lseek(fd, 0, SEEK_END);\n \tclose(fd);\n \n+\tif (len < 0) {\n+\t\tdev_err(smgr,\n+\t\t\t\"Failed to get file length of \\'%s\\' [e:%s]\\n\",\n+\t\t\timage, strerror(errno));\n+\t\treturn -EIO;\n+\t}\n+\tif (len == 0) {\n+\t\tdev_err(smgr, \"Length of file \\'%s\\' is invalid\\n\", image);\n+\t\treturn -EINVAL;\n+\t}\n+\tsmgr->rsu_length = len;\n+\n \tif (smgr->max10_dev->staging_area_size < smgr->rsu_length) {\n \t\tdev_err(dev, \"Size of staging area is small than image length \"\n \t\t\t\"[%u<%u]\\n\", smgr->max10_dev->staging_area_size,\n", "prefixes": [ "v1", "3/4" ] }