Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89965/?format=api
{ "id": 89965, "url": "http://patchwork.dpdk.org/api/patches/89965/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210328131222.16584-1-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210328131222.16584-1-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210328131222.16584-1-xuemingl@nvidia.com", "date": "2021-03-28T13:12:22", "name": "[v1] eal: update all buses default scan mode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "71b6862b6da652762a412c53b09661595fb8e73a", "submitter": { "id": 1904, "url": "http://patchwork.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210328131222.16584-1-xuemingl@nvidia.com/mbox/", "series": [ { "id": 15924, "url": "http://patchwork.dpdk.org/api/series/15924/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15924", "date": "2021-03-28T13:12:22", "name": "[v1] eal: update all buses default scan mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15924/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/89965/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/89965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1D9CDA034F;\n\tSun, 28 Mar 2021 15:13:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 80D1940042;\n\tSun, 28 Mar 2021 15:13:07 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 9CCF740040\n for <dev@dpdk.org>; Sun, 28 Mar 2021 15:13:05 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 28 Mar 2021 16:13:04 +0300", "from nvidia.com ([172.27.8.64])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 12SDD3jk019987;\n Sun, 28 Mar 2021 16:13:03 +0300" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "", "Cc": "dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Kinsella Ray <mdr@ashroe.eu>", "Date": "Sun, 28 Mar 2021 21:12:22 +0800", "Message-Id": "<20210328131222.16584-1-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210316124520.19726-1-xuemingl@nvidia.com>", "References": "<20210316124520.19726-1-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] eal: update all buses default scan mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When parsing EAL allowed or blocked device arguments, only device bus\nbeing parsed got default scan mode updated. If the devargs was vdev, PCI\nbus default scan mode not touched, all PCI bus devices will got probed\neven none appear in allowed list.\n\nThis patch update all buses default scan mode when parsing first\ndevargs.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n lib/librte_eal/common/eal_common_bus.c | 15 +++++++++++++++\n lib/librte_eal/common/eal_common_devargs.c | 13 +++++--------\n lib/librte_eal/common/eal_private.h | 8 ++++++++\n 3 files changed, 28 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c\nindex baa5b532af..d5818a456e 100644\n--- a/lib/librte_eal/common/eal_common_bus.c\n+++ b/lib/librte_eal/common/eal_common_bus.c\n@@ -277,3 +277,18 @@ rte_bus_sigbus_handler(const void *failure_addr)\n \n \treturn ret;\n }\n+\n+void\n+rte_bus_scan_mode_update(enum rte_bus_scan_mode mode)\n+{\n+\tstruct rte_bus *bus;\n+\tstatic bool mode_set;\n+\n+\tif (mode_set)\n+\t\treturn;\n+\tTAILQ_FOREACH(bus, &rte_bus_list, next) {\n+\t\tif (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED)\n+\t\t\tbus->conf.scan_mode = mode;\n+\t}\n+\tmode_set = true;\n+}\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex fcf3d9a3cc..3aedcb5c09 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -301,7 +301,6 @@ int\n rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n {\n \tstruct rte_devargs *devargs = NULL;\n-\tstruct rte_bus *bus = NULL;\n \tconst char *dev = devargs_str;\n \n \t/* use calloc instead of rte_zmalloc as it's called early at init */\n@@ -312,15 +311,13 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tif (rte_devargs_parse(devargs, dev))\n \t\tgoto fail;\n \tdevargs->type = devtype;\n-\tbus = devargs->bus;\n \tif (devargs->type == RTE_DEVTYPE_BLOCKED)\n \t\tdevargs->policy = RTE_DEV_BLOCKED;\n-\tif (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) {\n-\t\tif (devargs->policy == RTE_DEV_ALLOWED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_ALLOWLIST;\n-\t\telse if (devargs->policy == RTE_DEV_BLOCKED)\n-\t\t\tbus->conf.scan_mode = RTE_BUS_SCAN_BLOCKLIST;\n-\t}\n+\n+\tif (devargs->policy == RTE_DEV_ALLOWED)\n+\t\trte_bus_scan_mode_update(RTE_BUS_SCAN_ALLOWLIST);\n+\telse if (devargs->policy == RTE_DEV_BLOCKED)\n+\t\trte_bus_scan_mode_update(RTE_BUS_SCAN_BLOCKLIST);\n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\n \ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex b8a0d20021..ddd6769849 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -452,6 +452,14 @@ int rte_eal_memory_detach(void);\n */\n struct rte_bus *rte_bus_find_by_device_name(const char *str);\n \n+/**\n+ * Update all buses scan mode if not set, used by EAL parameter parsing.\n+ *\n+ * @param mode\n+ * Bus scan mode to be set.\n+ */\n+void rte_bus_scan_mode_update(enum rte_bus_scan_mode mode);\n+\n /**\n * Create the unix channel for primary/secondary communication.\n *\n", "prefixes": [ "v1" ] }