Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90111/?format=api
{ "id": 90111, "url": "http://patchwork.dpdk.org/api/patches/90111/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/33bdcdb912b4a2e3e9cb743dd93385fad78ece86.1617113740.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<33bdcdb912b4a2e3e9cb743dd93385fad78ece86.1617113740.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/33bdcdb912b4a2e3e9cb743dd93385fad78ece86.1617113740.git.anatoly.burakov@intel.com", "date": "2021-03-30T14:15:48", "name": "[3/3] power: do not skip saving original pstate governor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4ca09817dcfa89fe9e917eb4d9ffdcfbbaa8d01b", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/33bdcdb912b4a2e3e9cb743dd93385fad78ece86.1617113740.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 15983, "url": "http://patchwork.dpdk.org/api/series/15983/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15983", "date": "2021-03-30T14:15:46", "name": "[1/3] power: refactor base frequency detection", "version": 1, "mbox": "http://patchwork.dpdk.org/series/15983/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90111/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/90111/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9FF3A034F;\n\tTue, 30 Mar 2021 16:16:00 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A714140E18;\n\tTue, 30 Mar 2021 16:15:58 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 08F7C140E02\n for <dev@dpdk.org>; Tue, 30 Mar 2021 16:15:54 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2021 07:15:53 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.97])\n by orsmga006.jf.intel.com with ESMTP; 30 Mar 2021 07:15:51 -0700" ], "IronPort-SDR": [ "\n OEDsdh67mcVyZZ+UmWoxCJcuKN1b5lV8XcS9AkR2at3iekh6Uh1wjk2doLg9GaehWKJvsPSA9Q\n GsIOlSVi5ECA==", "\n cBbX8t9gv13MKEFojS5oSDbRLhZ39WpArzcdV9rEgrVaAzC06rwPowE+WnJheUYyyHGvs6LaUt\n 8SWqQSwiru4w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9939\"; a=\"191249265\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"191249265\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"378506450\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>", "Date": "Tue, 30 Mar 2021 14:15:48 +0000", "Message-Id": "\n <33bdcdb912b4a2e3e9cb743dd93385fad78ece86.1617113740.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617113740.git.anatoly.burakov@intel.com>", "References": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617113740.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] power: do not skip saving original pstate\n governor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when we set the pstate governor to \"performance\", we check if\nit is already set to this value, and if it is, we skip setting it.\n\nHowever, we never save this value anywhere, so that next time we come\nback and request the governor to be set to its original value, the\noriginal value is empty.\n\nFix it by saving the original pstate governor first. While we're at it,\nreplace `strlcpy` with `strscpy`.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/power_pstate_cpufreq.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 7ea1bf677a..a7a44df23f 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -450,6 +450,9 @@ power_set_governor_performance(struct pstate_power_info *pi)\n \tret = read_core_sysfs_s(f_governor, buf, sizeof(buf));\n \tFOPS_OR_ERR_GOTO(ret, out);\n \n+\t/* Save the original governor */\n+\tstrscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n+\n \t/* Check if current governor is performance */\n \tif (strncmp(buf, POWER_GOVERNOR_PERF,\n \t\t\tsizeof(POWER_GOVERNOR_PERF)) == 0) {\n@@ -458,8 +461,6 @@ power_set_governor_performance(struct pstate_power_info *pi)\n \t\t\t\t\"already performance\\n\", pi->lcore_id);\n \t\tgoto out;\n \t}\n-\t/* Save the original governor */\n-\tstrlcpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n \n \t/* Write 'performance' to the governor */\n \tret = write_core_sysfs_s(f_governor, POWER_GOVERNOR_PERF);\n", "prefixes": [ "3/3" ] }