Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90115/?format=api
{ "id": 90115, "url": "http://patchwork.dpdk.org/api/patches/90115/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/eb2c31acae53d911ca61494cfc124b8bd02d41ed.1617114301.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<eb2c31acae53d911ca61494cfc124b8bd02d41ed.1617114301.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/eb2c31acae53d911ca61494cfc124b8bd02d41ed.1617114301.git.anatoly.burakov@intel.com", "date": "2021-03-30T14:25:11", "name": "[v2,3/3] power: do not skip saving original pstate governor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "865f86eaddf6f7f7ae5b1b9e7e444b64da46fbf6", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/eb2c31acae53d911ca61494cfc124b8bd02d41ed.1617114301.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 15986, "url": "http://patchwork.dpdk.org/api/series/15986/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=15986", "date": "2021-03-30T14:25:11", "name": null, "version": 2, "mbox": "http://patchwork.dpdk.org/series/15986/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90115/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/90115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3B3EA034F;\n\tTue, 30 Mar 2021 16:25:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3CD32140E45;\n\tTue, 30 Mar 2021 16:25:19 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id DE78F140E23\n for <dev@dpdk.org>; Tue, 30 Mar 2021 16:25:16 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2021 07:25:16 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.97])\n by orsmga005.jf.intel.com with ESMTP; 30 Mar 2021 07:25:15 -0700" ], "IronPort-SDR": [ "\n Maz3BEnKHzWVQRRBAZHAahV+17bPTrz7HWLej/qhqxuWS24vwXb3pwfaPzQiD0PU+kayeS+suX\n rXRXnJfHTBQw==", "\n 578YEq+HZpqQvZqquOSF05YvefY4ZP4w5UlbH7dmsOGx9AStOkw1jEWB0cp6JM6ASNRvagIKb0\n ectHi0h+E/ag==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9939\"; a=\"253116353\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"253116353\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"595484297\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>", "Date": "Tue, 30 Mar 2021 14:25:11 +0000", "Message-Id": "\n <eb2c31acae53d911ca61494cfc124b8bd02d41ed.1617114301.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617113740.git.anatoly.burakov@intel.com>", "References": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617113740.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/3] power: do not skip saving original pstate\n governor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when we set the pstate governor to \"performance\", we check if\nit is already set to this value, and if it is, we skip setting it.\n\nHowever, we never save this value anywhere, so that next time we come\nback and request the governor to be set to its original value, the\noriginal value is empty.\n\nFix it by saving the original pstate governor first. While we're at it,\nreplace `strlcpy` with `rte_strscpy`.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/power_pstate_cpufreq.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 7ea1bf677a..db7856dadc 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -450,6 +450,9 @@ power_set_governor_performance(struct pstate_power_info *pi)\n \tret = read_core_sysfs_s(f_governor, buf, sizeof(buf));\n \tFOPS_OR_ERR_GOTO(ret, out);\n \n+\t/* Save the original governor */\n+\trte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n+\n \t/* Check if current governor is performance */\n \tif (strncmp(buf, POWER_GOVERNOR_PERF,\n \t\t\tsizeof(POWER_GOVERNOR_PERF)) == 0) {\n@@ -458,8 +461,6 @@ power_set_governor_performance(struct pstate_power_info *pi)\n \t\t\t\t\"already performance\\n\", pi->lcore_id);\n \t\tgoto out;\n \t}\n-\t/* Save the original governor */\n-\tstrlcpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n \n \t/* Write 'performance' to the governor */\n \tret = write_core_sysfs_s(f_governor, POWER_GOVERNOR_PERF);\n", "prefixes": [ "v2", "3/3" ] }