Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90226/?format=api
{ "id": 90226, "url": "http://patchwork.dpdk.org/api/patches/90226/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1617184904-55349-4-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1617184904-55349-4-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1617184904-55349-4-git-send-email-humin29@huawei.com", "date": "2021-03-31T10:01:37", "name": "[03/10] net/hns3: fix the FLR miss detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4f322a36f70f502b1dc8dd4818fdb6d65a88352", "submitter": { "id": 1944, "url": "http://patchwork.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1617184904-55349-4-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16009, "url": "http://patchwork.dpdk.org/api/series/16009/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16009", "date": "2021-03-31T10:01:38", "name": "some bugfixes for hns3 PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16009/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90226/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/90226/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA4D7A034F;\n\tWed, 31 Mar 2021 12:02:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0714B140EA6;\n\tWed, 31 Mar 2021 12:01:36 +0200 (CEST)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id D13DA140E4A\n for <dev@dpdk.org>; Wed, 31 Mar 2021 12:01:26 +0200 (CEST)", "from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F9MGt2ngFz9v4t\n for <dev@dpdk.org>; Wed, 31 Mar 2021 17:59:18 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 31 Mar 2021 18:01:18 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Wed, 31 Mar 2021 18:01:37 +0800", "Message-ID": "<1617184904-55349-4-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1617184904-55349-1-git-send-email-humin29@huawei.com>", "References": "<1617184904-55349-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 03/10] net/hns3: fix the FLR miss detection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hongbo Zheng <zhenghongbo3@huawei.com>\n\nWhen FLR occurs, the head pointer register of\nthe command queue will be cleared, resulting in\nabnormal detection of the head pointer register\nof the command queue. At present, FLR is detected\nin this way, and the reset recovery process is\nexecuted.\n\nHowever, when FLR occurs, the header pointer\nregister of the command queue is not necessarily\nabnormal. For example, when the driver runs\nnormally, the value of the header pointer register\nof the command queue may also be 0, which will\nlead to the miss detection of FLR.\n\nTherefore, the judgment that whether the base\naddress register of command queue is 0 is added\nto ensure that FLR not miss detection.\n\nFixes: 2790c6464725 (\"net/hns3: support device reset\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_cmd.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c\nindex 03f8048..f0c4a7f 100644\n--- a/drivers/net/hns3/hns3_cmd.c\n+++ b/drivers/net/hns3/hns3_cmd.c\n@@ -195,12 +195,14 @@ hns3_cmd_csq_clean(struct hns3_hw *hw)\n {\n \tstruct hns3_cmq_ring *csq = &hw->cmq.csq;\n \tuint32_t head;\n+\tuint32_t addr;\n \tint clean;\n \n \thead = hns3_read_dev(hw, HNS3_CMDQ_TX_HEAD_REG);\n-\tif (!is_valid_csq_clean_head(csq, head)) {\n-\t\thns3_err(hw, \"wrong cmd head (%u, %u-%u)\", head,\n-\t\t\t csq->next_to_use, csq->next_to_clean);\n+\taddr = hns3_read_dev(hw, HNS3_CMDQ_TX_ADDR_L_REG);\n+\tif (!is_valid_csq_clean_head(csq, head) || addr == 0) {\n+\t\thns3_err(hw, \"wrong cmd addr(%0x) head (%u, %u-%u)\", addr, head,\n+\t\t\t csq->next_to_use, csq->next_to_clean);\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\t\t__atomic_store_n(&hw->reset.disable_cmd, 1,\n \t\t\t\t\t __ATOMIC_RELAXED);\n", "prefixes": [ "03/10" ] }