Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90433/?format=api
{ "id": 90433, "url": "http://patchwork.dpdk.org/api/patches/90433/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210401150614.234257-1-anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210401150614.234257-1-anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210401150614.234257-1-anatoly.burakov@intel.com", "date": "2021-04-01T15:06:13", "name": "[v3,1/2] power: fix pstate base frequency handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b03bf21d1ebc7fb0e2881f4b97dbb76408be63c", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210401150614.234257-1-anatoly.burakov@intel.com/mbox/", "series": [ { "id": 16064, "url": "http://patchwork.dpdk.org/api/series/16064/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16064", "date": "2021-04-01T15:06:13", "name": "[v3,1/2] power: fix pstate base frequency handling", "version": 3, "mbox": "http://patchwork.dpdk.org/series/16064/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90433/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/90433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE87EA0548;\n\tThu, 1 Apr 2021 17:06:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A4BAE14116E;\n\tThu, 1 Apr 2021 17:06:20 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 7D9D7140EE8\n for <dev@dpdk.org>; Thu, 1 Apr 2021 17:06:18 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2021 08:06:16 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.97])\n by fmsmga008.fm.intel.com with ESMTP; 01 Apr 2021 08:06:15 -0700" ], "IronPort-SDR": [ "\n qH5wx64G6VpYujbtUEox2ULnljEYxzgAuZf25m6iMovpe776Bt9q2zlAvDTBFG8v0b8qJ/USoC\n iU3xVeijGSQg==", "\n G16hAkhFLIQk6HjSyb5IfUI8axbLFdk4l0qjOJrpJa4lVUZKp0Hu6zMaqeapg3/Ss4r0Y/rC6L\n 9tov07gmsEfg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9941\"; a=\"256247255\"", "E=Sophos;i=\"5.81,296,1610438400\"; d=\"scan'208\";a=\"256247255\"", "E=Sophos;i=\"5.81,296,1610438400\"; d=\"scan'208\";a=\"412722692\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "anatoly.burakov@intel.com,\n\tdavid.hunt@intel.com", "Date": "Thu, 1 Apr 2021 15:06:13 +0000", "Message-Id": "<20210401150614.234257-1-anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617114301.git.anatoly.burakov@intel.com>", "References": "\n <d0dc49e5dab4d4c730cc137194350a7d0a8baca8.1617114301.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/2] power: fix pstate base frequency handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous fix for base frequency handling in pstate mode introduced a\ncouple of issues:\n\n- When base_frequency file does not exist, it simply bails out because\n of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is\n incorrect, as absence of this file is not fatal and is in fact\n expected on kernel versions earlier than 5.3\n- When base_frequency file does exist, it gets opened, but never gets\n closed, resulting in a resource leak\n\nBoth issues also manifest themselves as Coverity defects (dead code, and\na resource leak), so this fix addresses both.\n\nFixes: 4db9587bbf72 (\"power: check sysfs base frequency\")\nCc: david.hunt@intel.com\n\nCoverity issue: 369693\nCoverity issue: 369694\nBugzilla ID: 668\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/power_pstate_cpufreq.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 8a1fffaed5..af5ad0b506 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -172,7 +172,6 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \t\t\tPOWER_SYSFILE_BASE_MAX_FREQ,\n \t\t\tpi->lcore_id);\n \tf_base_max = fopen(fullpath_base_max, \"r\");\n-\tFOPEN_OR_ERR_RET(f_base_max, -1);\n \tif (f_base_max != NULL) {\n \t\ts_base_max = fgets(buf_base, sizeof(buf_base), f_base_max);\n \t\tFOPS_OR_NULL_GOTO(s_base_max, out);\n@@ -185,6 +184,7 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \t\tbase_max_ratio =\n \t\t\tstrtoul(buf_base, NULL, POWER_CONVERT_TO_DECIMAL)\n \t\t\t\t/ BUS_FREQ;\n+\t\tfclose(f_base_max);\n \t}\n \n \tsnprintf(fullpath_min, sizeof(fullpath_min), POWER_SYSFILE_MIN_FREQ,\n", "prefixes": [ "v3", "1/2" ] }