Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90457/?format=api
{ "id": 90457, "url": "http://patchwork.dpdk.org/api/patches/90457/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210402092645.258257-1-anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210402092645.258257-1-anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210402092645.258257-1-anatoly.burakov@intel.com", "date": "2021-04-02T09:26:44", "name": "[v4,1/2] power: fix pstate base frequency handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e166f00897077f2c0640f87729737d04d90c328a", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210402092645.258257-1-anatoly.burakov@intel.com/mbox/", "series": [ { "id": 16078, "url": "http://patchwork.dpdk.org/api/series/16078/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16078", "date": "2021-04-02T09:26:44", "name": "[v4,1/2] power: fix pstate base frequency handling", "version": 4, "mbox": "http://patchwork.dpdk.org/series/16078/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90457/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/90457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 443CBA0548;\n\tFri, 2 Apr 2021 11:26:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C2652140EB8;\n\tFri, 2 Apr 2021 11:26:50 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 973D540141\n for <dev@dpdk.org>; Fri, 2 Apr 2021 11:26:48 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2021 02:26:47 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.97])\n by orsmga002.jf.intel.com with ESMTP; 02 Apr 2021 02:26:46 -0700" ], "IronPort-SDR": [ "\n 7zlCfJijOljuDHfJh6gRr6gsJ6+UiKhyEJUaWVUk2w8OuIYnuV99nSM+JbvxM9Gt6zcA3hTsjk\n KxMmHdmnVVfA==", "\n XaI4TI7xWGzPJvjbJhzWo2Fttwe4PgA4/ehTz63BbKc+tp9dKFSgi6gK6ocNBO27NlM98Atb3U\n IW6FqftMoUQw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9941\"; a=\"192536541\"", "E=Sophos;i=\"5.81,299,1610438400\"; d=\"scan'208\";a=\"192536541\"", "E=Sophos;i=\"5.81,299,1610438400\"; d=\"scan'208\";a=\"394900911\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com", "Date": "Fri, 2 Apr 2021 09:26:44 +0000", "Message-Id": "<20210402092645.258257-1-anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210401150614.234257-1-anatoly.burakov@intel.com>", "References": "<20210401150614.234257-1-anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous fix for base frequency handling in pstate mode introduced a\ncouple of issues:\n\n- When base_frequency file does not exist, it simply bails out because\n of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is\n incorrect, as absence of this file is not fatal and is in fact\n expected on kernel versions earlier than 5.3\n- When base_frequency file does exist, it gets opened, but never gets\n closed, resulting in a resource leak\n\nBoth issues also manifest themselves as Coverity defects (dead code, and\na resource leak), so this fix addresses both.\n\nFixes: 4db9587bbf72 (\"power: check sysfs base frequency\")\nCc: david.hunt@intel.com\n\nCoverity issue: 369693\nCoverity issue: 369694\nBugzilla ID: 668\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/power_pstate_cpufreq.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 8a1fffaed5..c4639e4b8a 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -206,7 +206,6 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \t\t\tpi->lcore_id);\n \n \tf_base = fopen(fullpath_base, \"r\");\n-\tFOPEN_OR_ERR_RET(f_base, -1);\n \tif (f_base == NULL) {\n \t\t/* No sysfs base_frequency, that's OK, continue without */\n \t\tbase_ratio = 0;\n@@ -221,6 +220,7 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \n \t\tbase_ratio = strtoul(buf_base, NULL, POWER_CONVERT_TO_DECIMAL)\n \t\t\t\t/ BUS_FREQ;\n+\t\tfclose(f_base);\n \t}\n \n \t/* Add MSR read to detect turbo status */\n", "prefixes": [ "v4", "1/2" ] }