Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90819/?format=api
{ "id": 90819, "url": "http://patchwork.dpdk.org/api/patches/90819/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210407155642.435964-1-anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210407155642.435964-1-anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210407155642.435964-1-anatoly.burakov@intel.com", "date": "2021-04-07T15:56:42", "name": "power: fix use-after-free in pstate code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6e931e750386413ce6f518450a7ec8b456537949", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210407155642.435964-1-anatoly.burakov@intel.com/mbox/", "series": [ { "id": 16177, "url": "http://patchwork.dpdk.org/api/series/16177/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16177", "date": "2021-04-07T15:56:42", "name": "power: fix use-after-free in pstate code", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16177/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/90819/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/90819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24585A0A0C;\n\tWed, 7 Apr 2021 17:56:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9150140F69;\n\tWed, 7 Apr 2021 17:56:51 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id DB317140F3C\n for <dev@dpdk.org>; Wed, 7 Apr 2021 17:56:50 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Apr 2021 08:56:49 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.97])\n by orsmga004.jf.intel.com with ESMTP; 07 Apr 2021 08:56:46 -0700" ], "IronPort-SDR": [ "\n k5MnJSl5hhb5UBe6CBH2Cqd5NKtyM6pvRROGKFskpjKxPnYxfZ6T6XvqfO4xXEvRjwFesfOvJN\n Z4c2Hv4eZAOw==", "\n y4H7sN1LRy8zTQZNb3y7M8F/SaCmwyqwrwDLO3TwvusXL15YAlGUm0exp44xCChGXxzwwE6GmK\n DGkDDl8kfKWw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9947\"; a=\"172813461\"", "E=Sophos;i=\"5.82,203,1613462400\"; d=\"scan'208\";a=\"172813461\"", "E=Sophos;i=\"5.82,203,1613462400\"; d=\"scan'208\";a=\"530254117\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com,\n\tthomas@monjalon.net", "Date": "Wed, 7 Apr 2021 15:56:42 +0000", "Message-Id": "<20210407155642.435964-1-anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] power: fix use-after-free in pstate code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous fix has addressed the incorrect handling of `base_frequency`\nfile, but has added a use-after-free error due to the fact that all\nfurther code paths will lead to an `fclose()` call at the end, so the\nadditional `fclose()` call right after processing the file was\nunnecessary.\n\nCoverity issue: 369901\n\nFixes: 8a5febaac4f7 (\"power: fix P-state base frequency handling\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/power_pstate_cpufreq.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 1cb0e4d917..ec745153d3 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -220,7 +220,6 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \n \t\tbase_ratio = strtoul(buf_base, NULL, POWER_CONVERT_TO_DECIMAL)\n \t\t\t\t/ BUS_FREQ;\n-\t\tfclose(f_base);\n \t}\n \n \t/* Add MSR read to detect turbo status */\n", "prefixes": [] }