Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91034/?format=api
{ "id": 91034, "url": "http://patchwork.dpdk.org/api/patches/91034/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1618064637-16413-3-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618064637-16413-3-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618064637-16413-3-git-send-email-xuemingl@nvidia.com", "date": "2021-04-10T14:23:54", "name": "[v4,2/5] devargs: fix memory leak on parsing error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "53d3c7e815b266ca874cf7577d94b7563f8e98dd", "submitter": { "id": 1904, "url": "http://patchwork.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1618064637-16413-3-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 16267, "url": "http://patchwork.dpdk.org/api/series/16267/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16267", "date": "2021-04-10T14:23:52", "name": "eal: enable global device syntax by default", "version": 4, "mbox": "http://patchwork.dpdk.org/series/16267/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/91034/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/91034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3D3DA0546;\n\tSat, 10 Apr 2021 16:24:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1FC171412B2;\n\tSat, 10 Apr 2021 16:24:21 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 444F91412B0\n for <dev@dpdk.org>; Sat, 10 Apr 2021 16:24:19 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 10 Apr 2021 17:24:14 +0300", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 13AEO6E0018265;\n Sat, 10 Apr 2021 17:24:14 +0300" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Gaetan Rivet <gaetanr@nvidia.com>", "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>,\n gaetan.rivet@6wind.com, stable@dpdk.org,\n Shreyansh Jain <shreyansh.jain@nxp.com>", "Date": "Sat, 10 Apr 2021 14:23:54 +0000", "Message-Id": "<1618064637-16413-3-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": [ "<1618064637-16413-1-git-send-email-xuemingl@nvidia.com>", "<1608304614-13908-2-git-send-email-xuemingl@nvidia.com>" ], "References": [ "<1618064637-16413-1-git-send-email-xuemingl@nvidia.com>", "<1608304614-13908-2-git-send-email-xuemingl@nvidia.com>" ], "Subject": "[dpdk-dev] [PATCH v4 2/5] devargs: fix memory leak on parsing error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes memory leak in parsing error handling.\n\nFixes: 338327d731e6 (\"devargs: add function to parse device layers\")\nCc: gaetan.rivet@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nReviewed-by: Gaetan Rivet <grive@u256.net>\n---\n lib/librte_eal/common/eal_common_devargs.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 48f85ee9c0..e40b91ea66 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -60,6 +60,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \tsize_t nblayer;\n \tsize_t i = 0;\n \tint ret = 0;\n+\tbool allocated_data = false;\n \n \t/* Split each sub-lists. */\n \tnblayer = devargs_layer_count(devstr);\n@@ -81,6 +82,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\tret = -ENOMEM;\n \t\t\tgoto get_out;\n \t\t}\n+\t\tallocated_data = true;\n \t\ts = devargs->data;\n \t}\n \n@@ -163,8 +165,14 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tif (layers[i].kvlist)\n \t\t\trte_kvargs_free(layers[i].kvlist);\n \t}\n-\tif (ret != 0)\n+\tif (ret != 0) {\n+\t\tif (allocated_data) {\n+\t\t\t/* Free duplicated data. */\n+\t\t\tfree(devargs->data);\n+\t\t\tdevargs->data = NULL;\n+\t\t}\n \t\trte_errno = -ret;\n+\t}\n \treturn ret;\n }\n \n", "prefixes": [ "v4", "2/5" ] }