Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91244/?format=api
{ "id": 91244, "url": "http://patchwork.dpdk.org/api/patches/91244/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210413122208.101057-1-anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210413122208.101057-1-anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210413122208.101057-1-anatoly.burakov@intel.com", "date": "2021-04-13T12:22:08", "name": "power: fix resource leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d2cfb05d1ea7197bc5024dd88758189fad0f46cc", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210413122208.101057-1-anatoly.burakov@intel.com/mbox/", "series": [ { "id": 16332, "url": "http://patchwork.dpdk.org/api/series/16332/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16332", "date": "2021-04-13T12:22:08", "name": "power: fix resource leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16332/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/91244/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/91244/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8744EA0524;\n\tTue, 13 Apr 2021 14:22:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1D69160EFD;\n\tTue, 13 Apr 2021 14:22:12 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 645DA160EFC\n for <dev@dpdk.org>; Tue, 13 Apr 2021 14:22:11 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2021 05:22:10 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.188])\n by orsmga006.jf.intel.com with ESMTP; 13 Apr 2021 05:22:09 -0700" ], "IronPort-SDR": [ "\n Y17RwewwUOEAFIwyS/yU9aafPbO5Wjbe1SeGoJnZrq9y75GXpm79jZ54Jh3NcrcXrLGYGRO8J+\n nLk2UhPngPBA==", "\n 3Or/8ulYd7Uv3/dm155A6ReG3LVRvezCfYVlVzi4XLEh8vvQhNjApmcrtnIsKWDNHnvLEmyr4B\n YIy1sitzrwfQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9952\"; a=\"174499439\"", "E=Sophos;i=\"5.82,219,1613462400\"; d=\"scan'208\";a=\"174499439\"", "E=Sophos;i=\"5.82,219,1613462400\"; d=\"scan'208\";a=\"383294505\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com,\n\treshma.pattan@intel.com", "Date": "Tue, 13 Apr 2021 12:22:08 +0000", "Message-Id": "<20210413122208.101057-1-anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] power: fix resource leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, we open the system base frequency file, but never close it,\nwhich results in a memory leak.\n\nCoverity issue: 369693\n\nFixes: 8a5febaac4f7 (\"power: fix P-state base frequency handling\")\nCc: david.hunt@intel.com\nCc: reshma.pattan@intel.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n Ideally, the close should be added at the end, but there's a bunch of ERR_RET\n macros before that, so addressing that would put us dangerously close to\n refactoring, which is not what we want to do so close to the release.\n \n This issue was already \"fixed\", but because the variable naming and the flow of\n code is confusing, the fix was addressing a different variable. There is a\n patch for 21.08 that will address the code flow and make it less confusing.\n\n lib/librte_power/power_pstate_cpufreq.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex ec745153d3..1451a024be 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -185,6 +185,9 @@ power_init_for_setting_freq(struct pstate_power_info *pi)\n \t\tbase_max_ratio =\n \t\t\tstrtoul(buf_base, NULL, POWER_CONVERT_TO_DECIMAL)\n \t\t\t\t/ BUS_FREQ;\n+\t\t/* not needed any more */\n+\t\tfclose(f_base_max);\n+\t\tf_base_max = NULL;\n \t}\n \n \tsnprintf(fullpath_min, sizeof(fullpath_min), POWER_SYSFILE_MIN_FREQ,\n", "prefixes": [] }