Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92075/?format=api
{ "id": 92075, "url": "http://patchwork.dpdk.org/api/patches/92075/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/55a50baa4bfbe70c6d71496ceb8ee086bc87906b.1619175709.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<55a50baa4bfbe70c6d71496ceb8ee086bc87906b.1619175709.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/55a50baa4bfbe70c6d71496ceb8ee086bc87906b.1619175709.git.anatoly.burakov@intel.com", "date": "2021-04-23T11:01:56", "name": "[v1,1/1] power: do not skip saving original acpi governor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e241ae303e1047ce5731dc7b02de11ead53f2f91", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/55a50baa4bfbe70c6d71496ceb8ee086bc87906b.1619175709.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 16632, "url": "http://patchwork.dpdk.org/api/series/16632/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16632", "date": "2021-04-23T11:01:56", "name": "[v1,1/1] power: do not skip saving original acpi governor", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16632/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/92075/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/92075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3CBEA0548;\n\tFri, 23 Apr 2021 13:02:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9C700410D8;\n\tFri, 23 Apr 2021 13:02:02 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 97BDE4014F\n for <dev@dpdk.org>; Fri, 23 Apr 2021 13:01:59 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2021 04:01:57 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.216])\n by fmsmga002.fm.intel.com with ESMTP; 23 Apr 2021 04:01:56 -0700" ], "IronPort-SDR": [ "\n eam08TDam2rhIBXOYj1TBTpID34u8bcVjHi18mPfbi9U/TbRJRI5iCgLTTd6Hnc/DaYeFVEnl4\n Vch6DZf9lMUQ==", "\n DTykscPl7DhV9g3q7q1wnbpj/mpDrb2nE/WWUZ8LguvawXUO5ojc4aYjnyuimTIBHbdPMtYwHV\n rOer8Cml/Iyg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9962\"; a=\"260004532\"", "E=Sophos;i=\"5.82,245,1613462400\"; d=\"scan'208\";a=\"260004532\"", "E=Sophos;i=\"5.82,245,1613462400\"; d=\"scan'208\";a=\"456182579\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Richael.Zhuang@arm.com,\n\tdavid.hunt@intel.com", "Date": "Fri, 23 Apr 2021 11:01:56 +0000", "Message-Id": "\n <55a50baa4bfbe70c6d71496ceb8ee086bc87906b.1619175709.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi\n governor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when we set the acpi governor to \"userspace\", we check if\nit is already set to this value, and if it is, we skip setting it.\n\nHowever, we never save this value anywhere, so that next time we come\nback and request the governor to be set to its original value, the\noriginal value is empty.\n\nFix it by saving the original pstate governor first. While we're at it,\nreplace `strlcpy` with `rte_strscpy`.\n\nFixes: 445c6528b55f (\"power: common interface for guest and host\")\nCc: david.hunt@intel.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/power/power_acpi_cpufreq.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c\nindex 84a9d75207..d028a9947f 100644\n--- a/lib/power/power_acpi_cpufreq.c\n+++ b/lib/power/power_acpi_cpufreq.c\n@@ -152,6 +152,9 @@ power_set_governor_userspace(struct rte_power_info *pi)\n \t/* Strip off terminating '\\n' */\n \tstrtok(buf, \"\\n\");\n \n+\t/* Save the original governor */\n+\trte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n+\n \t/* Check if current governor is userspace */\n \tif (strncmp(buf, POWER_GOVERNOR_USERSPACE,\n \t\t\tsizeof(POWER_GOVERNOR_USERSPACE)) == 0) {\n@@ -160,8 +163,6 @@ power_set_governor_userspace(struct rte_power_info *pi)\n \t\t\t\t\"already userspace\\n\", pi->lcore_id);\n \t\tgoto out;\n \t}\n-\t/* Save the original governor */\n-\tstrlcpy(pi->governor_ori, buf, sizeof(pi->governor_ori));\n \n \t/* Write 'userspace' to the governor */\n \tval = fseek(f, 0, SEEK_SET);\n", "prefixes": [ "v1", "1/1" ] }