Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 92257,
    "url": "http://patchwork.dpdk.org/api/patches/92257/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210427135755.927-2-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210427135755.927-2-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210427135755.927-2-olivier.matz@6wind.com",
    "date": "2021-04-27T13:57:52",
    "name": "[1/4] net/tap: fix Rx cksum flags on IP options packets",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5ccd40a584c2f842ec66821b2366e9c2229e733f",
    "submitter": {
        "id": 8,
        "url": "http://patchwork.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": {
        "id": 3961,
        "url": "http://patchwork.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210427135755.927-2-olivier.matz@6wind.com/mbox/",
    "series": [
        {
            "id": 16703,
            "url": "http://patchwork.dpdk.org/api/series/16703/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16703",
            "date": "2021-04-27T13:57:51",
            "name": "net/tap: fix Rx cksum",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/16703/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/92257/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/92257/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3279A0A02;\n\tTue, 27 Apr 2021 15:58:29 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C39D41254;\n\tTue, 27 Apr 2021 15:58:26 +0200 (CEST)",
            "from mail-wr1-f50.google.com (mail-wr1-f50.google.com\n [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id ECB4B406A3\n for <dev@dpdk.org>; Tue, 27 Apr 2021 15:58:23 +0200 (CEST)",
            "by mail-wr1-f50.google.com with SMTP id j5so58621238wrn.4\n for <dev@dpdk.org>; Tue, 27 Apr 2021 06:58:23 -0700 (PDT)",
            "from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id h9sm21072213wmb.35.2021.04.27.06.58.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 27 Apr 2021 06:58:23 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=WdnoC2V6KCWhpBILoO1Y+5wep/dMmiSUiNQ7fW6rD2k=;\n b=hjtcN+WPTQg1brME+hk+RkEpCtZK+bAqd6wpCqWkx0DB7gW25m42+IwuhuzrFNrD+h\n nHRgltUlt0DvbrWcrSME+Gj+Pj1SA9E9MQ//k0W1crKkVHB/jH9eFEzMGxL0mlQgsyFf\n SwsfQhXUTQQfWUf87cXsymWtubvEsZPXA/eO++8aLFY0GehhoPnB5P5ZbOCGizMPEAkB\n 9/F1U1PYvQ5FBGZwDvFlOX5nVGxahVPjeGoXjqfTDKKp64ldMvBgvMghGQjCKNDPeK5d\n SlT+wemq+lypfD8BdGaGPYPlYqFT7g/9Z8R1uijEkUb+3tmwk9Nl1eq25oJyp0Iea61N\n dFVQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=WdnoC2V6KCWhpBILoO1Y+5wep/dMmiSUiNQ7fW6rD2k=;\n b=gXzsPNa9gTqGvMzgyKuiNrkUuKBkARyAKGEqDr2q+y5iLs/4sf/OeCiZGxtmJGyJFn\n s9jRRUP/8/QlpGwJKSV3dv/1kbnTN3jInLKeANimIHs3NyErR4hKOw7lfrjfrwzSeNL3\n B3yOoZas82Yrhbq6p1y6TXf+oH2AB3nznmeLPx4A/WQvoPt3uUjAfbXzgGIXx0jmfzL7\n zjSvjGYZ6dDnZAYAESIN4Gj3d+Nb+e/Viorvk5vA9pkNRmsq2lsx9IY6jpROW9ZfiIiW\n EdJH+d84P9eQD1Envi/+MoWGeosrwKt9DqeZZOnhJYPAX+vKMwofyol5JQLYFi8pD8ds\n PgXg==",
        "X-Gm-Message-State": "AOAM531yiYLW3mvkiSoiCoicLio9ioUCZIXj5ccdnlrUXj2m+cV+5DRy\n 5L1pUxd36diYMRX2uJOiRg1P8IqKWrCoDw==",
        "X-Google-Smtp-Source": "\n ABdhPJyDiNvOSeRQiY3lpA2f5rrPnQ4x8g1GriWgTxIx+ouCRuln7Xy0oU/LGg8p2aSxZnwiPcxXNg==",
        "X-Received": "by 2002:a5d:43c1:: with SMTP id v1mr10974663wrr.248.1619531903771;\n Tue, 27 Apr 2021 06:58:23 -0700 (PDT)",
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Keith Wiles <keith.wiles@intel.com>, Hongzhi Guo <guohongzhi1@huawei.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Thomas Monjalon <thomas@monjalon.net>, stable@dpdk.org",
        "Date": "Tue, 27 Apr 2021 15:57:52 +0200",
        "Message-Id": "<20210427135755.927-2-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.29.2",
        "In-Reply-To": "<20210427135755.927-1-olivier.matz@6wind.com>",
        "References": "<20210427135755.927-1-olivier.matz@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options\n packets",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When packet type is IPV4_EXT, the checksum is always marked as good in\nthe mbuf offload flags.\n\nSince we know the header lengths, we can easily call\nrte_ipv4_udptcp_cksum() in this case too.\n\nFixes: 8ae3023387e9 (\"net/tap: add Rx/Tx checksum offload support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/tap/rte_eth_tap.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 68baa18523..e7b185a4b5 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -350,7 +350,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)\n \t\t/* Don't verify checksum for multi-segment packets. */\n \t\tif (mbuf->nb_segs > 1)\n \t\t\treturn;\n-\t\tif (l3 == RTE_PTYPE_L3_IPV4) {\n+\t\tif (l3 == RTE_PTYPE_L3_IPV4 || l3 == RTE_PTYPE_L3_IPV4_EXT) {\n \t\t\tif (l4 == RTE_PTYPE_L4_UDP) {\n \t\t\t\tudp_hdr = (struct rte_udp_hdr *)l4_hdr;\n \t\t\t\tif (udp_hdr->dgram_cksum == 0) {\n@@ -364,7 +364,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)\n \t\t\t\t}\n \t\t\t}\n \t\t\tcksum = ~rte_ipv4_udptcp_cksum(l3_hdr, l4_hdr);\n-\t\t} else if (l3 == RTE_PTYPE_L3_IPV6) {\n+\t\t} else { /* l3 == RTE_PTYPE_L3_IPV6, checked above */\n \t\t\tcksum = ~rte_ipv6_udptcp_cksum(l3_hdr, l4_hdr);\n \t\t}\n \t\tmbuf->ol_flags |= cksum ?\n",
    "prefixes": [
        "1/4"
    ]
}