Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9232/?format=api
{ "id": 9232, "url": "http://patchwork.dpdk.org/api/patches/9232/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1449028676-19232-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449028676-19232-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449028676-19232-3-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-02T03:57:48", "name": "[dpdk-dev,02/10] mk: move installation procedure in install rule", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3b20ea4bdbd0ed3b9af5f9d0eef7c0da92ae2c58", "submitter": { "id": 1, "url": "http://patchwork.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1449028676-19232-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/9232/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/9232/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 767198DB4;\n\tWed, 2 Dec 2015 04:59:20 +0100 (CET)", "from mail-wm0-f49.google.com (mail-wm0-f49.google.com\n\t[74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 95CB68D99\n\tfor <dev@dpdk.org>; Wed, 2 Dec 2015 04:59:19 +0100 (CET)", "by wmvv187 with SMTP id v187so236238746wmv.1\n\tfor <dev@dpdk.org>; Tue, 01 Dec 2015 19:59:19 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.52.3])\n\tby smtp.gmail.com with ESMTPSA id\n\th5sm783942wjz.21.2015.12.01.19.59.18\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 01 Dec 2015 19:59:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5fNTY/SxipNU+DfdTsLPaw3ddIsXvho7zBK8D60+bE4=;\n\tb=hbpDOxEVh3KAW9Lvq0HqQ/LYRXw/YIJPbND4eWNcO8YWvGsqJ3sIyr/jq3Vm1fApIa\n\t4/2v4mehrvB4DEEGR0Kegt5ivvSOFYUVZA9peqFmll3IhHqHLHNn3PGOL55Ix19oEZDC\n\t1Q7H0mTDJ3FxsV2QyFGu8OLrAyn9HLyOeKoIz02eS4ZzN2aAjE+hlbRN/HNrsOMbIl4j\n\tb1W663l4Udx29mkXlxAWXQkBTaYmQvQciRANR23QSAt0tBB6ttH24Sv5fZpkeUoLbaaa\n\tkwNFXxG/eWITKcJ1e88FMp89V2NxhQbEVkj1XyhcZcyUj5QczUKsljc5yOPavfXNvS0e\n\tGmfw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5fNTY/SxipNU+DfdTsLPaw3ddIsXvho7zBK8D60+bE4=;\n\tb=Y8HqBPsJ3ngtomIVUVClKB9f9VyEV6ehrfTAxrW31VW47AJB8F+qU9azPHAmF+cAQd\n\t0/Tv0UhKNLBQZaEs+yVEbJfep3o2cgojuiFJvBsG0BgxyB4WifFBDdbUuzg1bhAt6iVN\n\tcrXwnF3gByFQEmeqalz/95RWI3EU7ZrPBWHeqfwolUilgqykJK4vIYdV83ipYdVrsj61\n\twlaNJCJXfKC2iVTr2EBRHTNdXIFF3KqYa0inXiqDgj5nMhZ/oopD7h5XzOl/XleyqKfx\n\tfyIqBvyTValffZD7+hREE8Pv3GMnOofbyFHlDQrn1YjllpYDPPtVxPuZHrqkV8ys3t/8\n\tcxUw==", "X-Gm-Message-State": "ALoCoQlwDi3zWB9GMroR9m3iWVFWvRXBOe5Iiwyip2xvbgPu8oWKNfwZEg3B/gX8sFwDoXIUosCh", "X-Received": "by 10.195.11.233 with SMTP id el9mr1449247wjd.145.1449028759464; \n\tTue, 01 Dec 2015 19:59:19 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 2 Dec 2015 04:57:48 +0100", "Message-Id": "<1449028676-19232-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 02/10] mk: move installation procedure in install\n\trule", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The real installation was called \"binary install\" and was done\nafter the build when DESTDIR was specified.\nRemove this limitation and move the code in install rule only.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.sdkbuild.mk | 16 ----------------\n mk/rte.sdkinstall.mk | 21 ++++++++++++++++++---\n 2 files changed, 18 insertions(+), 19 deletions(-)", "diff": "diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk\nindex 38ec7bd..85f603c 100644\n--- a/mk/rte.sdkbuild.mk\n+++ b/mk/rte.sdkbuild.mk\n@@ -29,8 +29,6 @@\n # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n-# If DESTDIR variable is given, install binary dpdk\n-\n #\n # include rte.vars.mk if config file exists\n #\n@@ -61,20 +59,6 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))\n .PHONY: build\n build: $(ROOTDIRS-y)\n \t@echo \"Build complete [$(RTE_TARGET)]\"\n-ifneq ($(DESTDIR),)\n-\t$(Q)mkdir -p $(DESTDIR)\n-\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n-\t --keep-newer-files --warning=no-ignore-newer -f -\n-\t$(Q)mkdir -p $(DESTDIR)/`basename $(RTE_OUTPUT)`\n-\t$(Q)tar -C $(RTE_OUTPUT) -chf - \\\n-\t --exclude app --exclude hostapp --exclude build \\\n-\t --exclude Makefile --exclude .depdirs . | \\\n-\t tar -C $(DESTDIR)/`basename $(RTE_OUTPUT)` -x --keep-newer-files \\\n-\t --warning=no-ignore-newer -f -\n-\t$(Q)install -D $(RTE_OUTPUT)/app/testpmd \\\n-\t $(DESTDIR)/`basename $(RTE_OUTPUT)`/app/testpmd\n-\t@echo Installation in $(DESTDIR) complete\n-endif\n \n .PHONY: clean\n clean: $(CLEANDIRS)\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex e8355eb..ed3ed86 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -37,9 +37,8 @@ O ?= .\n # The build directory is T and may be prepended with O\n BUILD_DIR := $O/$T\n \n-.PHONY: install\n-install:\n-\t@echo ================== Installing $T\n+.PHONY: pre_install\n+pre_install:\n \t$(Q)if [ ! -f $(BUILD_DIR)/.config ]; then \\\n \t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n \telif cmp -s $(BUILD_DIR)/.config.orig $(BUILD_DIR)/.config; then \\\n@@ -56,3 +55,19 @@ install:\n \t\techo \"Using local configuration\"; \\\n \tfi\n \t$(Q)$(MAKE) all O=$(BUILD_DIR)\n+\n+.PHONY: install\n+install: pre_install\n+\t@echo ================== Installing $(DESTDIR)\n+\t$(Q)mkdir -p $(DESTDIR)\n+\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n+\t --keep-newer-files --warning=no-ignore-newer -f -\n+\t$(Q)mkdir -p $(DESTDIR)/$T\n+\t$(Q)tar -C $(BUILD_DIR) -chf - \\\n+\t --exclude app --exclude hostapp --exclude build \\\n+\t --exclude Makefile --exclude .depdirs . | \\\n+\t tar -C $(DESTDIR)/$T -x --keep-newer-files \\\n+\t --warning=no-ignore-newer -f -\n+\t$(Q)install -D $(BUILD_DIR)/app/testpmd \\\n+\t $(DESTDIR)/$T/app/testpmd\n+\t@echo Installation in $(DESTDIR) complete\n", "prefixes": [ "dpdk-dev", "02/10" ] }