Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92983/?format=api
{ "id": 92983, "url": "http://patchwork.dpdk.org/api/patches/92983/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210506034957.46458-3-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506034957.46458-3-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506034957.46458-3-haiyue.wang@intel.com", "date": "2021-05-06T03:49:56", "name": "[v5,2/3] net/iavf: enable PCI bus master after reset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e12cc1c8b46fb6688f8078a9e3a6523176a00ef8", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210506034957.46458-3-haiyue.wang@intel.com/mbox/", "series": [ { "id": 16844, "url": "http://patchwork.dpdk.org/api/series/16844/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16844", "date": "2021-05-06T03:49:54", "name": "fix PF reset causes VF memory request failure", "version": 5, "mbox": "http://patchwork.dpdk.org/series/16844/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/92983/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/92983/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D4EFA0524;\n\tThu, 6 May 2021 06:10:32 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99595410FE;\n\tThu, 6 May 2021 06:10:22 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id DE1C0410F3\n for <dev@dpdk.org>; Thu, 6 May 2021 06:10:20 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 May 2021 21:10:20 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.118.220])\n by orsmga008.jf.intel.com with ESMTP; 05 May 2021 21:10:18 -0700" ], "IronPort-SDR": [ "\n SrHm3pUFa+8Lt+ullg2DbG/4Gj70k02nGz4z9F+doARxbDa0haArHTwuMil38Wig//YIAl/MCD\n xEIAF2zXRsng==", "\n TQ0EbJw8ALwbDmMp50F/b7u4qNgsdmrsm0MmOMNxelFdFd6CHFiUFQReBkgex3RQk22SzXPdYt\n kUvf1bfz5QsA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9975\"; a=\"195251311\"", "E=Sophos;i=\"5.82,276,1613462400\"; d=\"scan'208\";a=\"195251311\"", "E=Sophos;i=\"5.82,276,1613462400\"; d=\"scan'208\";a=\"434147085\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, liang-min.wang@intel.com, david.marchand@redhat.com,\n Haiyue Wang <haiyue.wang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>", "Date": "Thu, 6 May 2021 11:49:56 +0800", "Message-Id": "<20210506034957.46458-3-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210506034957.46458-1-haiyue.wang@intel.com>", "References": "<20210421050243.130585-1-haiyue.wang@intel.com>\n <20210506034957.46458-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 2/3] net/iavf: enable PCI bus master after\n reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VF reset can be triggerred by the PF reset event, in this case, the\nPCI bus master will be cleared, then the VF is not allowed to issue any\nMemory or I/O Requests.\n\nSo after the reset event is detected, always enable the PCI bus master.\nAnd if failed, the device or system may be in an invalid state, so keep\nthe VF reset state to mark it as I/O error.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex c06873d26..0084a083b 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -2356,7 +2356,8 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \trte_free(vf->aq_resp);\n \tvf->aq_resp = NULL;\n \n-\tvf->vf_reset = false;\n+\tif (vf->vf_reset && !rte_pci_set_bus_master(pci_dev, true))\n+\t\tvf->vf_reset = false;\n \n \treturn ret;\n }\n", "prefixes": [ "v5", "2/3" ] }