Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93173/?format=api
{ "id": 93173, "url": "http://patchwork.dpdk.org/api/patches/93173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210512023056.30558-1-cheng1.jiang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210512023056.30558-1-cheng1.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210512023056.30558-1-cheng1.jiang@intel.com", "date": "2021-05-12T02:30:56", "name": "vhost: fix unintended sign extension in async packed ring", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c0c37431c6e4fb3ef080cb35c38348af9923f11e", "submitter": { "id": 1530, "url": "http://patchwork.dpdk.org/api/people/1530/?format=api", "name": "Jiang, Cheng1", "email": "Cheng1.jiang@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210512023056.30558-1-cheng1.jiang@intel.com/mbox/", "series": [ { "id": 16935, "url": "http://patchwork.dpdk.org/api/series/16935/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16935", "date": "2021-05-12T02:30:56", "name": "vhost: fix unintended sign extension in async packed ring", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16935/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93173/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/93173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6751A0A0E;\n\tWed, 12 May 2021 04:44:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 57BD2410DE;\n\tWed, 12 May 2021 04:44:42 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id A359D4003E\n for <dev@dpdk.org>; Wed, 12 May 2021 04:44:40 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 May 2021 19:44:39 -0700", "from dpdk_jiangcheng.sh.intel.com ([10.67.119.112])\n by fmsmga002.fm.intel.com with ESMTP; 11 May 2021 19:44:38 -0700" ], "IronPort-SDR": [ "\n 1nLfMGVdvbjNYpljuggrMmTSRyuASUUvMvBZMrUpdW3LBR4qNVkLsvMMFxuxwCXfqKPNk9xojy\n u8SIPzpqNL5Q==", "\n buWvT2DBlA7/qKMvNiubsKFHZ0HWrqUGTfw57V66Zm1xukijokqtNXZCrEyDXM09X3xwbf8JXY\n I9kwBSXU7/YA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9981\"; a=\"199651756\"", "E=Sophos;i=\"5.82,292,1613462400\"; d=\"scan'208\";a=\"199651756\"", "E=Sophos;i=\"5.82,292,1613462400\"; d=\"scan'208\";a=\"469197638\"" ], "X-ExtLoop1": "1", "From": "Cheng Jiang <cheng1.jiang@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org,\n\tCheng Jiang <cheng1.jiang@intel.com>", "Date": "Wed, 12 May 2021 02:30:56 +0000", "Message-Id": "<20210512023056.30558-1-cheng1.jiang@intel.com>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: fix unintended sign extension in async\n packed ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the variable type in store_dma_desc_info_packed() to fix\nsuspicious implicit sign extension.\n\nCoverity issue: 370608, 370610, 370612\nFixes: 873e8dad6f49 (vhost: support packed ring in async datapath)\n\nSigned-off-by: Cheng Jiang <cheng1.jiang@intel.com>\n---\n lib/vhost/virtio_net.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex 9137a9923b..abfd67d38c 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -1491,7 +1491,7 @@ store_dma_desc_info_packed(struct vring_used_elem_packed *s_ring,\n \t\tstruct vring_used_elem_packed *d_ring,\n \t\tuint16_t ring_size, uint16_t s_idx, uint16_t d_idx, uint16_t count)\n {\n-\tuint16_t elem_size = sizeof(struct vring_used_elem_packed);\n+\tsize_t elem_size = sizeof(struct vring_used_elem_packed);\n \n \tif (d_idx + count <= ring_size) {\n \t\trte_memcpy(d_ring + d_idx, s_ring + s_idx, count * elem_size);\n", "prefixes": [] }