Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93258/?format=api
{ "id": 93258, "url": "http://patchwork.dpdk.org/api/patches/93258/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210513183105.671396-1-matan@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210513183105.671396-1-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210513183105.671396-1-matan@nvidia.com", "date": "2021-05-13T18:31:05", "name": "vdpa/mlx5: fix device unplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9fe994701e8236c1a7aad5955919ffebb5eb81fa", "submitter": { "id": 1911, "url": "http://patchwork.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210513183105.671396-1-matan@nvidia.com/mbox/", "series": [ { "id": 16986, "url": "http://patchwork.dpdk.org/api/series/16986/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16986", "date": "2021-05-13T18:31:05", "name": "vdpa/mlx5: fix device unplug", "version": 1, "mbox": "http://patchwork.dpdk.org/series/16986/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93258/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/93258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C5FBA0A0A;\n\tThu, 13 May 2021 20:31:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C22094067E;\n\tThu, 13 May 2021 20:31:33 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79])\n by mails.dpdk.org (Postfix) with ESMTP id 3172E4003F;\n Thu, 13 May 2021 20:31:32 +0200 (CEST)", "from DM5PR05CA0004.namprd05.prod.outlook.com (2603:10b6:3:d4::14) by\n CH0PR12MB5267.namprd12.prod.outlook.com (2603:10b6:610:d2::18) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4129.26; Thu, 13 May 2021 18:31:31 +0000", "from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com\n (2603:10b6:3:d4:cafe::98) by DM5PR05CA0004.outlook.office365.com\n (2603:10b6:3:d4::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.12 via Frontend\n Transport; Thu, 13 May 2021 18:31:31 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4129.25 via Frontend Transport; Thu, 13 May 2021 18:31:31 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 13 May\n 2021 18:31:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gf+vibyoF6cS/T37/f9640eWldFz9bWk00DLYsGIzMZdMWCqRRagYgQ6bSpO9lCeiDsXpYDX888GfV04XiKeNOp7FXobT4zM2OFhtt34fm8Vf1GDclOaT1jfkVOh5sdrN0ClwfqEn6OTcsKFRrVWQrHHU+o4XTObSkJYaNgYYfmgXROOW32N1GA1PgNT6ExY9l5wx3baFW+Ebe0x8/6LV7SiJDz7FyuSQQHvp8X6wAFglyNP/gFilCD1E1rP5kBDyslnXMf1dxvn2vpH2iCPrlUoa+cMzTPs99Nnyoj08NM5IaTpqez8Tm1yxSDKG9ESpbM0CMPFkNFbYu+OAgiOqQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ho83Htld76Cap+u0/evwi9kxo7OHGM5DElmFWyISEyo=;\n b=ip0JdBwmlau4zPGetyJdDSuhO/GrzNGLGbwUKq1Mmk8tD4bWk39GIu1qFu0gIA1pIGWgRvkzcwWJ1knH2BOqEsbcoUrXLVnzQNVsvaWW9JdDsr2FeAUGMtiujH1aTRkykl54jdWiKzrkvdkTz/w8rYewt5EMST3JP6Ug1jE2XXI2JXbqOGRENYiJ/Iuaut8occTa6VK+cc/7Wrsv5AmBQ1r5vAKEQR1t9Ecn8C+/DDxqg0t/s+XXkekict8HvEnK8vFiJnI80rXBJmUL4zPIYGQ5NpwyAMC9ff5S/YyNFi9FK8ORlhYthIsKLC1oFhok1g/SP9cox2x8uLGm3vYeaw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ho83Htld76Cap+u0/evwi9kxo7OHGM5DElmFWyISEyo=;\n b=bznowz5zAdsiGRcilfW9hJ9xTjGrHR1WqZiyRmpaVnCf+yvQWSa48gkHr202GB3yGMDSWKNmWM5w2ZMeBGz8GjrR+CKSzQQs4f+I3+OcwVafU7DO7Jd2RN70PLQdD4toLUkexP1VtDmI3S6ZFMZ25Wv9uYsgOhURXAKrvhSRt/Ks/y7amH40LXA9IhyZcUxcNbv0wsUc8J6i+HEUUyPPZ644ejnjPG6h5YZ6SQsY5OaZxemG4+7peRBJRZ/kjEqrfeWf8ogxVHaGaTguDAX5Kvn2OTP5RI5kTrIAk5E/AHYxBU7cJ196yHSwKYEenSmOFchvC66wEkUBmHnP3kxL7Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Matan Azrad <matan@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<maxime.coquelin@redhat.com>, <stable@dpdk.org>, Xueming Li\n <xuemingl@nvidia.com>", "Date": "Thu, 13 May 2021 21:31:05 +0300", "Message-ID": "<20210513183105.671396-1-matan@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "7fcba3e4-dac3-4e5d-714b-08d9163d5436", "X-MS-TrafficTypeDiagnostic": "CH0PR12MB5267:", "X-Microsoft-Antispam-PRVS": "\n <CH0PR12MB5267CA801714D674B51D6B6FDF519@CH0PR12MB5267.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2887;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 4Yfr/m1wu0+gk4MJ65wxwGXGGxQI1cCDmk3BW8HY0E9Yp8q76Uu8RURrFDSHzRyzQ+mmrJV4bpSPus3RgM1cepFPOpFhX2Bn1EPH9mcLx09cW4HqOU/sIwcGXNKgDWPaG0o96lYpwD30qE2dECkfU3ZoBvamVjWk9pGRcmLN1/q9wLZbCK3H+rh/CZfZJMYS975QCcgum0MVU7ITPHJOjoso0Fd6TrtI2O73he4zENehj8sWhLM8BdrDEUSUEsDQxL3bidrlbpSpzp6PgMIGCbMB/1wXlQG8U59J6MxLIMYvjQ6sZE8IQuBHeTrV1fSJv4v1rMbB9CIeUoTBbJnPSgi+V1JV04RPmvGMIsz+vFoRbEWLnSFvfohaIgLG1yqhlQIC6USxfWPMgc3qyRnKUbvrtUMEF34dNQHs4YLe3DUtrNb9AB2AjvcidocFJ0g9q3aqXfOb4+/U5skJ8sDA5POq5kqSSlnccpHMlKKk42b4BbBGh/ML9IAr4Vaf092xyaSocQW59CPLM3+AKopUMDOhWRtu+drV6HdI8lpOwxEZFgfmivej2nORZCzmhzzzmsX011t3qTerpY9oHmLvP+owloIo8w+OE2ilpi5iUSW4YnZ2Bbn4E3Pb06ecIUL4C4mOdLGccv+SkJ4jnhv6GA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(46966006)(36840700001)(6916009)(186003)(6666004)(426003)(16526019)(2616005)(336012)(82310400003)(47076005)(7636003)(8676002)(8936002)(7696005)(70586007)(70206006)(316002)(83380400001)(26005)(107886003)(36860700001)(6286002)(55016002)(5660300002)(4326008)(36756003)(1076003)(86362001)(478600001)(356005)(2906002)(36906005)(54906003)(82740400003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 May 2021 18:31:31.0116 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7fcba3e4-dac3-4e5d-714b-08d9163d5436", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT055.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB5267", "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix device unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vDPA PCI device unplug proccess should release all the private\ndevice resources and also to unregister the device.\n\nThe device unregistration was missed what remained the device data\ninvalid in the rte_vhost library.\n\nUnregister the device in unplug proccess via the remove operation.\n\nFixes: 95276abaaf0a (\"vdpa/mlx5: introduce Mellanox vDPA driver\")\nCc: stable@dpdk.org\n\nReported-by: Eli Britstein elibr@nvidia.com\nSigned-off-by: Matan Azrad matan@nvidia.com\nTested-by: Eli Britstein elibr@nvidia.com\nAcked-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 40db28b6db..e5e03e6582 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev)\n \t\t\tmlx5_glue->dv_free_var(priv->var);\n \t\t\tpriv->var = NULL;\n \t\t}\n+\t\tif (priv->vdev)\n+\t\t\trte_vdpa_unregister_device(priv->vdev);\n \t\tmlx5_glue->close_device(priv->ctx);\n \t\tpthread_mutex_destroy(&priv->vq_config_lock);\n \t\trte_free(priv);\n", "prefixes": [] }