Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93376/?format=api
{ "id": 93376, "url": "http://patchwork.dpdk.org/api/patches/93376/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210523114609.448092-3-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210523114609.448092-3-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210523114609.448092-3-haiyue.wang@intel.com", "date": "2021-05-23T11:46:07", "name": "[v6,2/3] net/iavf: enable PCI bus master after reset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "271ddef365a4e162db8837d92c0ac0c0b8cc4889", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210523114609.448092-3-haiyue.wang@intel.com/mbox/", "series": [ { "id": 17078, "url": "http://patchwork.dpdk.org/api/series/17078/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17078", "date": "2021-05-23T11:46:05", "name": "fix PF reset causes VF memory request failure", "version": 6, "mbox": "http://patchwork.dpdk.org/series/17078/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93376/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/93376/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADA37A0547;\n\tSun, 23 May 2021 14:07:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02B8641109;\n\tSun, 23 May 2021 14:07:03 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 7AF314003C\n for <dev@dpdk.org>; Sun, 23 May 2021 14:06:59 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 May 2021 05:06:58 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.118.220])\n by orsmga001.jf.intel.com with ESMTP; 23 May 2021 05:06:56 -0700" ], "IronPort-SDR": [ "\n kDWEk7pNtmQ4n377enhcFCjfME6/sz79PT+/wiVKkNUkBU1j6D5+aTz7SOcyShGWCMADWKXsjZ\n us9P9wEkII3w==", "\n JytySES1of7HErY11qSa26dKF3wVyeHSwNkvLVsM6ABDpwnrJPJWQUlMio7i4XYdV9I//qFhj2\n wcQJNaDfF81Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9992\"; a=\"199847493\"", "E=Sophos;i=\"5.82,319,1613462400\"; d=\"scan'208\";a=\"199847493\"", "E=Sophos;i=\"5.82,319,1613462400\"; d=\"scan'208\";a=\"475390084\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, liang-min.wang@intel.com, david.marchand@redhat.com,\n Haiyue Wang <haiyue.wang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>", "Date": "Sun, 23 May 2021 19:46:07 +0800", "Message-Id": "<20210523114609.448092-3-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210523114609.448092-1-haiyue.wang@intel.com>", "References": "<20210421050243.130585-1-haiyue.wang@intel.com>\n <20210523114609.448092-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 2/3] net/iavf: enable PCI bus master after\n reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VF reset can be triggerred by the PF reset event, in this case, the\nPCI bus master will be cleared, then the VF is not allowed to issue any\nMemory or I/O Requests.\n\nSo after the reset event is detected, always enable the PCI bus master.\nAnd if failed, the device or system may be in an invalid state, so keep\nthe VF reset state to mark it as I/O error.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex d688c31cfb..a7ef7a6d4d 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -2356,7 +2356,15 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \trte_free(vf->aq_resp);\n \tvf->aq_resp = NULL;\n \n-\tvf->vf_reset = false;\n+\t/*\n+\t * If the VF is reset via VFLR, the device will be knocked out of bus\n+\t * master mode, and the driver will fail to recover from the reset. Fix\n+\t * this by enabling bus mastering after every reset. In a non-VFLR case,\n+\t * the bus master bit will not be disabled, and this call will have no\n+\t * effect.\n+\t */\n+\tif (vf->vf_reset && !rte_pci_set_bus_master(pci_dev, true))\n+\t\tvf->vf_reset = false;\n \n \treturn ret;\n }\n", "prefixes": [ "v6", "2/3" ] }