Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93666/?format=api
{ "id": 93666, "url": "http://patchwork.dpdk.org/api/patches/93666/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210531214142.30167-29-tduszynski@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210531214142.30167-29-tduszynski@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210531214142.30167-29-tduszynski@marvell.com", "date": "2021-05-31T21:41:42", "name": "[28/28] raw/cnxk_bphy: add support for selftest", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c46ad66178b9e948804a36ff0d3db43ba9e5d63f", "submitter": { "id": 2215, "url": "http://patchwork.dpdk.org/api/people/2215/?format=api", "name": "Tomasz Duszynski", "email": "tduszynski@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210531214142.30167-29-tduszynski@marvell.com/mbox/", "series": [ { "id": 17173, "url": "http://patchwork.dpdk.org/api/series/17173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17173", "date": "2021-05-31T21:41:14", "name": "add support for baseband phy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93666/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/93666/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 269B1A0524;\n\tMon, 31 May 2021 23:44:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 84F0341103;\n\tMon, 31 May 2021 23:43:00 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id DF48941103\n for <dev@dpdk.org>; Mon, 31 May 2021 23:42:58 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 14VLeT3d002864 for <dev@dpdk.org>; Mon, 31 May 2021 14:42:58 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 38vtnja14n-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 31 May 2021 14:42:58 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 31 May 2021 14:42:56 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 31 May 2021 14:42:56 -0700", "from EH-LT0048.marvell.com (unknown [10.193.32.52])\n by maili.marvell.com (Postfix) with ESMTP id 4A2353F703F;\n Mon, 31 May 2021 14:42:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=3Bk5A2NuCglqZEoSqWYN7upLaeb1rxanG8zMphyLR9k=;\n b=Q/acMSx1sYprnjUMuvuNr4LEpxT7avSbVfIaE1bQSa4KLhFUe0Her8JrwrxjaeUYquqZ\n ex3qhg70+cYdvzQnw3CoXymTTrPAAmYY7DG8FjKT2CLe3n4Hjyy1fMYngBKygl8adedn\n 9YhOZ9Kthc+AFUL+UWrzAyZydltAWknrJ1PVcU6YcXKs92RKvTCPy25UAbWKUNdPjtMy\n o+jlD4wUy6QtyYy4bd1Ggx+ztsfZE9JrI825jMwZo61+fuumdTanktz1WUQJ4XbcAY5Y\n 5+MpJaxbKWpao6J4x6KLn2urtcGOE/IzKB1WO/M9V5MezkaRBbk785YO2JzmTW2L1egV 2w==", "From": "Tomasz Duszynski <tduszynski@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jpalider@marvell.com>, <jerinj@marvell.com>, Tomasz Duszynski\n <tduszynski@marvell.com>", "Date": "Mon, 31 May 2021 23:41:42 +0200", "Message-ID": "<20210531214142.30167-29-tduszynski@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210531214142.30167-1-tduszynski@marvell.com>", "References": "<20210531214142.30167-1-tduszynski@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "09aqPZ6kJcR9D4mKM6-NWi-_JMUkFOPB", "X-Proofpoint-ORIG-GUID": "09aqPZ6kJcR9D4mKM6-NWi-_JMUkFOPB", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761\n definitions=2021-05-31_15:2021-05-31,\n 2021-05-31 signatures=0", "Subject": "[dpdk-dev] [PATCH 28/28] raw/cnxk_bphy: add support for selftest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for performing selftest.\n\nSigned-off-by: Jakub Palider <jpalider@marvell.com>\nSigned-off-by: Tomasz Duszynski <tduszynski@marvell.com>\n---\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 104 ++++++++++++++++++++++++++++++\n 1 file changed, 104 insertions(+)", "diff": "diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex a6bbdd986..640405242 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -11,6 +11,7 @@\n #include <rte_rawdev_pmd.h>\n \n #include <roc_api.h>\n+#include <roc_bphy_irq.h>\n \n #include \"cnxk_bphy_irq.h\"\n #include \"rte_pmd_bphy.h\"\n@@ -22,6 +23,25 @@ static const struct rte_pci_id pci_bphy_map[] = {\n \t},\n };\n \n+struct bphy_test {\n+\tint irq_num;\n+\tcnxk_bphy_intr_handler_t handler;\n+\tvoid *data;\n+\tint cpu;\n+\tbool handled_intr;\n+\tint handled_data;\n+\tint test_data;\n+};\n+\n+static struct bphy_test *test;\n+\n+static void\n+bphy_test_handler_fn(int irq_num, void *isr_data)\n+{\n+\ttest[irq_num].handled_intr = true;\n+\ttest[irq_num].handled_data = *((int *)isr_data);\n+}\n+\n int\n rte_pmd_bphy_intr_init(uint16_t dev_id)\n {\n@@ -54,7 +74,91 @@ rte_pmd_bphy_intr_unregister(uint16_t dev_id, int irq_num)\n \tcnxk_bphy_intr_unregister(dev_id, irq_num);\n }\n \n+static int\n+bphy_rawdev_selftest(uint16_t dev_id)\n+{\n+\tunsigned int i;\n+\tuint64_t max_irq;\n+\tint ret = 0;\n+\n+\tret = rte_pmd_bphy_intr_init(dev_id);\n+\tif (ret) {\n+\t\tplt_err(\"intr init failed\");\n+\t\treturn ret;\n+\t}\n+\n+\tmax_irq = cnxk_bphy_irq_max_get(dev_id);\n+\n+\ttest = rte_zmalloc(\"BPHY\", max_irq * sizeof(*test), 0);\n+\tif (test == NULL) {\n+\t\tplt_err(\"intr alloc failed\");\n+\t\tgoto err_alloc;\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\ttest[i].test_data = i;\n+\t\ttest[i].irq_num = i;\n+\t\ttest[i].handler = bphy_test_handler_fn;\n+\t\ttest[i].data = &test[i].test_data;\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\tret = rte_pmd_bphy_intr_register(dev_id, test[i].irq_num,\n+\t\t\t\t\t\t test[i].handler, test[i].data,\n+\t\t\t\t\t\t 0);\n+\t\tif (ret == -ENOTSUP) {\n+\t\t\t/* In the test we iterate over all irq numbers\n+\t\t\t * so if some of them are not supported by given\n+\t\t\t * platform we treat respective results as valid\n+\t\t\t * ones. This way they have no impact on overall\n+\t\t\t * test results.\n+\t\t\t */\n+\t\t\ttest[i].handled_intr = true;\n+\t\t\ttest[i].handled_data = test[i].test_data;\n+\t\t\tret = 0;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (ret) {\n+\t\t\tplt_err(\"intr register failed at irq %d\", i);\n+\t\t\tgoto err_register;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < max_irq; i++)\n+\t\troc_bphy_intr_handler(i);\n+\n+\tfor (i = 0; i < max_irq; i++) {\n+\t\tif (!test[i].handled_intr) {\n+\t\t\tplt_err(\"intr %u not handled\", i);\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t\tif (test[i].handled_data != test[i].test_data) {\n+\t\t\tplt_err(\"intr %u has wrong handler\", i);\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+err_register:\n+\t/*\n+\t * In case of registration failure the loop goes over all\n+\t * interrupts which is safe due to internal guards in\n+\t * rte_pmd_bphy_intr_unregister().\n+\t */\n+\tfor (i = 0; i < max_irq; i++)\n+\t\trte_pmd_bphy_intr_unregister(dev_id, i);\n+\n+\trte_free(test);\n+err_alloc:\n+\trte_pmd_bphy_intr_fini(dev_id);\n+\n+\treturn ret;\n+}\n+\n static const struct rte_rawdev_ops bphy_rawdev_ops = {\n+\t.dev_selftest = bphy_rawdev_selftest,\n };\n \n static void\n", "prefixes": [ "28/28" ] }