Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 93685,
    "url": "http://patchwork.dpdk.org/api/patches/93685/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210601054247.1540154-1-christian.ehrhardt@canonical.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210601054247.1540154-1-christian.ehrhardt@canonical.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210601054247.1540154-1-christian.ehrhardt@canonical.com",
    "date": "2021-06-01T05:42:47",
    "name": "vfio: fix stdbool usage without include",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5ee75849e131af022b794e04cbe824b685266d6c",
    "submitter": {
        "id": 382,
        "url": "http://patchwork.dpdk.org/api/people/382/?format=api",
        "name": "Christian Ehrhardt",
        "email": "christian.ehrhardt@canonical.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210601054247.1540154-1-christian.ehrhardt@canonical.com/mbox/",
    "series": [
        {
            "id": 17178,
            "url": "http://patchwork.dpdk.org/api/series/17178/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17178",
            "date": "2021-06-01T05:42:47",
            "name": "vfio: fix stdbool usage without include",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/17178/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/93685/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/93685/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8622A0524;\n\tTue,  1 Jun 2021 07:42:54 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5972D40041;\n\tTue,  1 Jun 2021 07:42:54 +0200 (CEST)",
            "from youngberry.canonical.com (youngberry.canonical.com\n [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 547BB40040\n for <dev@dpdk.org>; Tue,  1 Jun 2021 07:42:53 +0200 (CEST)",
            "from 2.general.paelzer.uk.vpn ([10.172.196.173]\n helo=localhost.localdomain)\n by youngberry.canonical.com with esmtpsa (TLS1.2) tls\n TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)\n (envelope-from <christian.ehrhardt@canonical.com>)\n id 1lnxAy-0002A1-Ck; Tue, 01 Jun 2021 05:42:52 +0000"
        ],
        "From": "Christian Ehrhardt <christian.ehrhardt@canonical.com>",
        "To": "dev <dev@dpdk.org>",
        "Cc": "Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Christian Ehrhardt <christian.ehrhardt@canonical.com>",
        "Date": "Tue,  1 Jun 2021 07:42:47 +0200",
        "Message-Id": "<20210601054247.1540154-1-christian.ehrhardt@canonical.com>",
        "X-Mailer": "git-send-email 2.31.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] vfio: fix stdbool usage without include",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This became visible by backporting the following for the 19.11 stable tree:\n c13ca4e8 \"vfio: fix DMA mapping granularity for IOVA as VA\"\n\nThe usage of type bool in the vfio code would require \"#include\n<stdbool.h>\", but rte_vfio.h has no direct paths to stdbool.h.\nIt happens that in eal_vfio_mp_sync.c it comes after \"#include\n<rte_log.h>\".\n\nAnd rte_log.h since 20.05 includes stdbool since this change:\n 241e67bfe \"log: add API to check if a logtype can log in a given level\"\nand thereby masks the issue in >20.05.\n\nIt should be safe to include stdbool.h from rte_vfio.h itself\nto have bool present exactly when needed for the struct it defines\nusing that type.\n\nSigned-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>\n---\n lib/eal/include/rte_vfio.h | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h\nindex e7a87454bea..2d90b364801 100644\n--- a/lib/eal/include/rte_vfio.h\n+++ b/lib/eal/include/rte_vfio.h\n@@ -14,6 +14,7 @@\n extern \"C\" {\n #endif\n \n+#include <stdbool.h>\n #include <stdint.h>\n \n /*\n",
    "prefixes": []
}