Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9373/?format=api
{ "id": 9373, "url": "http://patchwork.dpdk.org/api/patches/9373/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-06T18:46:05", "name": "[dpdk-dev,v2,1/2] mk: prepare dependencies in shared libraries not combined", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "01888681f5c042a8115dc73a0649108be6cfe239", "submitter": { "id": 1, "url": "http://patchwork.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/9373/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/9373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9530C9267;\n\tSun, 6 Dec 2015 19:47:30 +0100 (CET)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id A1D029255\n\tfor <dev@dpdk.org>; Sun, 6 Dec 2015 19:47:29 +0100 (CET)", "by wmec201 with SMTP id c201so137415459wme.0\n\tfor <dev@dpdk.org>; Sun, 06 Dec 2015 10:47:29 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tvr10sm21850853wjc.38.2015.12.06.10.47.28\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tSun, 06 Dec 2015 10:47:28 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=tuT23t5jPvJf4o6T57qyxukQioq1Pa9kVJ/GRTdxKEQ=;\n\tb=Mbs6dStcjdbXC/6nnm/0duEJuhzGbcts6e7xbqHzPk5/vk1WC1hs5ZDyOQM+7R72te\n\ty8eqyYu8haYnztDIukWmMQhlR95KQeNakhhqmjSKgKzrHgQ0+HzcxHTq+mIpyQCUJE7V\n\tfONfT/miwgud1TChepRXPJr814m9ITAHpi6MOgh7DCZDuOPbmz7pEFaR1Gc44UnNAJ8u\n\tBrL8ljdBoK2r+OtHjFAGVNvrTUyay1PybTDHEHX4n19skr8p8RKS526vBrHeL7y2v3Wk\n\tw4U3vq+VopIzsE4EtFSm0N56d6r2l8tV37isj6u70Oknb4AlIbmnT5/3MqQv8zUFSqtN\n\t5M+w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=tuT23t5jPvJf4o6T57qyxukQioq1Pa9kVJ/GRTdxKEQ=;\n\tb=Bgg2wX+DkETCdkqStt0+MdDHxi9wGAEYMHQFK8uuiHyOYKjkbZpog9Zp2XraCUJGg5\n\twvStzrPNky9bFoKeynIGHKQPw7OHJpw+wbGwacGNyitpXsN/GS5eIpJDeWgrdB6BLQG/\n\tU3mAtAVdypBDQNqzM3Rewf4P/2z/mcNESXK3S+TE6zFO1Lj5lgJmj7dXnjiKgIKEvLYD\n\t/iyN05KRu3TUtJUUoeYAUv+b3eBIgTITDLohwYxTOw1GvGcHRNgEeJAiKOiEtB6F56JT\n\tY9WoQb+H8f2mpWOYeF7Tqm+rdoCR636yG4K/MjIzeWbxzjkdJrOJmLndUoC6bAYoM44/\n\t9pig==", "X-Gm-Message-State": "ALoCoQnQSu69d2eWG/OEBGyrYgzwxZx7nDWLmvcP+uZFeYb0CKlyA+LQ8mHP9kvW+rJSwrFrFpxY", "X-Received": "by 10.194.118.74 with SMTP id kk10mr28364284wjb.5.1449427649467; \n\tSun, 06 Dec 2015 10:47:29 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Panu Matilainen <pmatilai@redhat.com>", "Date": "Sun, 6 Dec 2015 19:46:05 +0100", "Message-Id": "<1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<ee5b1caf719262b06bbf0b8b134b250abd0865d3.1445437070.git.pmatilai@redhat.com>", "References": "<ee5b1caf719262b06bbf0b8b134b250abd0865d3.1445437070.git.pmatilai@redhat.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v2 1/2] mk: prepare dependencies in shared\n\tlibraries not combined", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some DPDK libraries have a dependency.\nThe Mellanox drivers embed this declaration in shared library case.\nSo the application do not need to know the dependency when linking.\nBut it cannot work with static libraries or the combined one.\nNote that Mellanox drivers are currently not supported in a shared\ncombined library case.\n\nMost of the DPDK libraries declare their dependencies to be linked\nwith the application in every cases, even when using drivers as\nshared library plugins.\nThis patch improves the condition used for Mellanox drivers, so that\nit can be applied to other drivers without breaking the shared\ncombined library case.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.app.mk | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex d7e2964..3f56852 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -102,13 +102,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse\n endif\n \n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n+# The static libraries do not know their dependencies.\n+# The combined library fails also to store this information.\n+# So linking with static or combined library requires explicit dependencies.\n+ifneq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(CONFIG_RTE_BUILD_SHARED_LIB),ny)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs\n-endif # ! CONFIG_RTE_BUILD_SHARED_LIBS\n-\n-ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -libverbs\n-endif # ! CONFIG_RTE_BUILD_SHARED_LIBS\n+endif # CONFIG_RTE_BUILD_COMBINE_LIBS or not CONFIG_RTE_BUILD_SHARED_LIBS\n \n _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz\n \n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }