Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93904/?format=api
{ "id": 93904, "url": "http://patchwork.dpdk.org/api/patches/93904/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210604144225.287678-5-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210604144225.287678-5-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210604144225.287678-5-andrew.rybchenko@oktetlabs.ru", "date": "2021-06-04T14:42:18", "name": "[04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6251b6d3097af72123282199517ff8bcfd39a97e", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210604144225.287678-5-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17239, "url": "http://patchwork.dpdk.org/api/series/17239/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17239", "date": "2021-06-04T14:42:14", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17239/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93904/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/93904/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60B20A0A0F;\n\tFri, 4 Jun 2021 16:43:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 737F4410FC;\n\tFri, 4 Jun 2021 16:42:59 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 14C9D40698;\n Fri, 4 Jun 2021 16:42:58 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id D026F7F57E; Fri, 4 Jun 2021 17:42:57 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 71BBE7F57F;\n Fri, 4 Jun 2021 17:42:35 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 71BBE7F57F", "Authentication-Results": "shelob.oktetlabs.ru/71BBE7F57F; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>, Kuba Kozak <kubax.kozak@intel.com>", "Date": "Fri, 4 Jun 2021 17:42:18 +0300", "Message-Id": "<20210604144225.287678-5-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 04/11] ethdev: fix docs of drivers callbacks\n getting xstats by IDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nUpdate xstats by IDs callbacks documentation in accordance with\nethdev usage of these callbacks. Document valid combinations of\ninput arguments to make driver implementation simpler.\n\nFixes: 79c913a42f0 (\"ethdev: retrieve xstats by ID\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n lib/ethdev/ethdev_driver.h | 43 ++++++++++++++++++++++++++++++++++++--\n 1 file changed, 41 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex 40e474aa7e..fd5b7ca550 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -187,11 +187,28 @@ typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat *stats, unsigned int n);\n /**< @internal Get extended stats of an Ethernet device. */\n \n+/**\n+ * @internal\n+ * Get extended stats of an Ethernet device.\n+ *\n+ * @param dev\n+ * ethdev handle of port.\n+ * @param ids\n+ * IDs array to retrieve specific statistics. Must not be NULL.\n+ * @param values\n+ * A pointer to a table to be filled with device statistics values.\n+ * Must not be NULL.\n+ * @param n\n+ * Element count in @p ids and @p values\n+ *\n+ * @return\n+ * - A number of filled in stats.\n+ * - A negative value on error.\n+ */\n typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev,\n \t\t\t\t const uint64_t *ids,\n \t\t\t\t uint64_t *values,\n \t\t\t\t unsigned int n);\n-/**< @internal Get extended stats of an Ethernet device. */\n \n /**\n * @internal\n@@ -218,10 +235,32 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, unsigned int size);\n /**< @internal Get names of extended stats of an Ethernet device. */\n \n+/**\n+ * @internal\n+ * Get names of extended stats of an Ethernet device.\n+ * For name count, set @p xstats_names and @p ids to NULL.\n+ *\n+ * @param dev\n+ * ethdev handle of port.\n+ * @param xstats_names\n+ * An rte_eth_xstat_name array of at least *size* elements to\n+ * be filled. Can be NULL together with @p ids to retrieve number of\n+ * available statistics.\n+ * @param ids\n+ * IDs array to retrieve specific statistics. Can be NULL together\n+ * with @p xstats_names to retrieve number of available statistics.\n+ * @param size\n+ * Size of ids and xstats_names arrays.\n+ * Element count in @p ids and @p xstats_names\n+ *\n+ * @return\n+ * - A number of filled in stats if both xstats_names and ids are not NULL.\n+ * - A number of available stats if both xstats_names and ids are NULL.\n+ * - A negative value on error.\n+ */\n typedef int (*eth_xstats_get_names_by_id_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n \tunsigned int size);\n-/**< @internal Get names of extended stats of an Ethernet device. */\n \n typedef int (*eth_queue_stats_mapping_set_t)(struct rte_eth_dev *dev,\n \t\t\t\t\t uint16_t queue_id,\n", "prefixes": [ "04/11" ] }