Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93905/?format=api
{ "id": 93905, "url": "http://patchwork.dpdk.org/api/patches/93905/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210604144225.287678-6-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210604144225.287678-6-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210604144225.287678-6-andrew.rybchenko@oktetlabs.ru", "date": "2021-06-04T14:42:19", "name": "[05/11] net/sfc: fix xstats by ID callbacks according to ethdev", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "33bd82d7056351233b391017e763997ab5b55ae7", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210604144225.287678-6-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17239, "url": "http://patchwork.dpdk.org/api/series/17239/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17239", "date": "2021-06-04T14:42:14", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17239/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93905/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/93905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4081EA0A0F;\n\tFri, 4 Jun 2021 16:43:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D2D78410F8;\n\tFri, 4 Jun 2021 16:43:11 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 8E33E40698;\n Fri, 4 Jun 2021 16:43:09 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 6445D7F663; Fri, 4 Jun 2021 17:43:09 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id A4B3E7F663;\n Fri, 4 Jun 2021 17:42:35 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A4B3E7F663", "Authentication-Results": "shelob.oktetlabs.ru/A4B3E7F663; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>, Remy Horton <remy.horton@intel.com>,\n Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Fri, 4 Jun 2021 17:42:19 +0300", "Message-Id": "<20210604144225.287678-6-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/11] net/sfc: fix xstats by ID callbacks\n according to ethdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nFix xstats by ID callbacks according to ethdev usage.\nHandle combinations of input arguments that are required by ethdev\nand sanity check and reject other combinations on callback entry.\n\nFixes: 73280c1e4ff (\"net/sfc: support xstats retrieval by ID\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex d5417e5e65..fca3f524a1 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -794,13 +794,10 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \tint ret;\n \tint rc;\n \n-\tsfc_adapter_lock(sa);\n+\tif (unlikely(ids == NULL || values == NULL))\n+\t\treturn -EINVAL;\n \n-\tif (unlikely(values == NULL) ||\n-\t unlikely(ids == NULL && n < port->mac_stats_nb_supported)) {\n-\t\tret = port->mac_stats_nb_supported;\n-\t\tgoto unlock;\n-\t}\n+\tsfc_adapter_lock(sa);\n \n \trc = sfc_port_update_mac_stats(sa);\n \tif (rc != 0) {\n@@ -815,7 +812,7 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \t\tif (!EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i))\n \t\t\tcontinue;\n \n-\t\tif ((ids == NULL) || (ids[nb_written] == nb_supported))\n+\t\tif (ids[nb_written] == nb_supported)\n \t\t\tvalues[nb_written++] = mac_stats[i];\n \n \t\t++nb_supported;\n@@ -840,10 +837,13 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \tunsigned int nb_written = 0;\n \tunsigned int i;\n \n+\tif (unlikely(xstats_names == NULL && ids != NULL) ||\n+\t unlikely(xstats_names != NULL && ids == NULL))\n+\t\treturn -EINVAL;\n+\n \tsfc_adapter_lock(sa);\n \n-\tif (unlikely(xstats_names == NULL) ||\n-\t unlikely((ids == NULL) && (size < port->mac_stats_nb_supported))) {\n+\tif (unlikely(xstats_names == NULL && ids == NULL)) {\n \t\tnb_supported = port->mac_stats_nb_supported;\n \t\tsfc_adapter_unlock(sa);\n \t\treturn nb_supported;\n@@ -853,7 +853,7 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \t\tif (!EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i))\n \t\t\tcontinue;\n \n-\t\tif ((ids == NULL) || (ids[nb_written] == nb_supported)) {\n+\t\tif (ids[nb_written] == nb_supported) {\n \t\t\tchar *name = xstats_names[nb_written++].name;\n \n \t\t\tstrlcpy(name, efx_mac_stat_name(sa->nic, i),\n", "prefixes": [ "05/11" ] }