Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 94906,
    "url": "http://patchwork.dpdk.org/api/patches/94906/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/514d89a9555ff38ea953662d3c8eb262bce7560f.1624895595.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<514d89a9555ff38ea953662d3c8eb262bce7560f.1624895595.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/514d89a9555ff38ea953662d3c8eb262bce7560f.1624895595.git.anatoly.burakov@intel.com",
    "date": "2021-06-28T15:54:14",
    "name": "[v4,7/7] l3fwd-power: support multiqueue in PMD pmgmt modes",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "890a4e40d9baee2801496d4b58a2d0d025e737f2",
    "submitter": {
        "id": 4,
        "url": "http://patchwork.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/514d89a9555ff38ea953662d3c8eb262bce7560f.1624895595.git.anatoly.burakov@intel.com/mbox/",
    "series": [
        {
            "id": 17504,
            "url": "http://patchwork.dpdk.org/api/series/17504/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17504",
            "date": "2021-06-28T15:54:07",
            "name": "Enhancements for PMD power management",
            "version": 4,
            "mbox": "http://patchwork.dpdk.org/series/17504/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/94906/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/94906/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BDD0AA0A0C;\n\tMon, 28 Jun 2021 17:55:10 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BCCA741172;\n\tMon, 28 Jun 2021 17:54:44 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id C6B1141163\n for <dev@dpdk.org>; Mon, 28 Jun 2021 17:54:33 +0200 (CEST)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jun 2021 08:54:33 -0700",
            "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.53])\n by orsmga005.jf.intel.com with ESMTP; 28 Jun 2021 08:54:32 -0700"
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10029\"; a=\"204975524\"",
            "E=Sophos;i=\"5.83,306,1616482800\"; d=\"scan'208\";a=\"204975524\"",
            "E=Sophos;i=\"5.83,306,1616482800\"; d=\"scan'208\";a=\"625296713\""
        ],
        "X-ExtLoop1": "1",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org,\n\tDavid Hunt <david.hunt@intel.com>",
        "Cc": "konstantin.ananyev@intel.com,\n\tciara.loftus@intel.com",
        "Date": "Mon, 28 Jun 2021 15:54:14 +0000",
        "Message-Id": "\n <514d89a9555ff38ea953662d3c8eb262bce7560f.1624895595.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1624895595.git.anatoly.burakov@intel.com>",
        "References": "<cover.1624884053.git.anatoly.burakov@intel.com>\n <cover.1624895595.git.anatoly.burakov@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v4 7/7] l3fwd-power: support multiqueue in PMD\n pmgmt modes",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Currently, l3fwd-power enforces the limitation of having one queue per\nlcore. This is no longer necessary, so remove the limitation, and always\nmark the last queue in qconf as the power save queue.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n examples/l3fwd-power/main.c | 39 +++++++++++++++++++++++--------------\n 1 file changed, 24 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex f8dfed1634..3057c06936 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -2498,6 +2498,27 @@ mode_to_str(enum appmode mode)\n \t}\n }\n \n+static void\n+pmd_pmgmt_set_up(unsigned int lcore, uint16_t portid, uint16_t qid, bool last)\n+{\n+\tint ret;\n+\n+\tret = rte_power_ethdev_pmgmt_queue_enable(lcore, portid,\n+\t\t\tqid, pmgmt_type);\n+\tif (ret < 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"rte_power_ethdev_pmgmt_queue_enable: err=%d, port=%d\\n\",\n+\t\t\tret, portid);\n+\n+\tif (!last)\n+\t\treturn;\n+\tret = rte_power_ethdev_pmgmt_queue_set_power_save(lcore, portid, qid);\n+\tif (ret < 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"rte_power_ethdev_pmgmt_queue_set_power_save: err=%d, port=%d\\n\",\n+\t\t\tret, portid);\n+}\n+\n int\n main(int argc, char **argv)\n {\n@@ -2723,12 +2744,6 @@ main(int argc, char **argv)\n \t\tprintf(\"\\nInitializing rx queues on lcore %u ... \", lcore_id );\n \t\tfflush(stdout);\n \n-\t\t/* PMD power management mode can only do 1 queue per core */\n-\t\tif (app_mode == APP_MODE_PMD_MGMT && qconf->n_rx_queue > 1) {\n-\t\t\trte_exit(EXIT_FAILURE,\n-\t\t\t\t\"In PMD power management mode, only one queue per lcore is allowed\\n\");\n-\t\t}\n-\n \t\t/* init RX queues */\n \t\tfor(queue = 0; queue < qconf->n_rx_queue; ++queue) {\n \t\t\tstruct rte_eth_rxconf rxq_conf;\n@@ -2767,15 +2782,9 @@ main(int argc, char **argv)\n \t\t\t\t\t\t \"Fail to add ptype cb\\n\");\n \t\t\t}\n \n-\t\t\tif (app_mode == APP_MODE_PMD_MGMT) {\n-\t\t\t\tret = rte_power_ethdev_pmgmt_queue_enable(\n-\t\t\t\t\t\tlcore_id, portid, queueid,\n-\t\t\t\t\t\tpmgmt_type);\n-\t\t\t\tif (ret < 0)\n-\t\t\t\t\trte_exit(EXIT_FAILURE,\n-\t\t\t\t\t\t\"rte_power_ethdev_pmgmt_queue_enable: err=%d, port=%d\\n\",\n-\t\t\t\t\t\t\tret, portid);\n-\t\t\t}\n+\t\t\tif (app_mode == APP_MODE_PMD_MGMT)\n+\t\t\t\tpmd_pmgmt_set_up(lcore_id, portid, queueid,\n+\t\t\t\t\tqueue == (qconf->n_rx_queue - 1));\n \t\t}\n \t}\n \n",
    "prefixes": [
        "v4",
        "7/7"
    ]
}