Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94977/?format=api
{ "id": 94977, "url": "http://patchwork.dpdk.org/api/patches/94977/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210629133332.226897-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210629133332.226897-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210629133332.226897-1-haiyue.wang@intel.com", "date": "2021-06-29T13:33:32", "name": "[v1] net/ice: enable to set HW debug mask", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2cfd267a91e1c790fbc7e37c5d82bc44acb60705", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210629133332.226897-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 17523, "url": "http://patchwork.dpdk.org/api/series/17523/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17523", "date": "2021-06-29T13:33:32", "name": "[v1] net/ice: enable to set HW debug mask", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17523/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/94977/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/94977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79671A0A0C;\n\tTue, 29 Jun 2021 15:55:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F3DD0411C5;\n\tTue, 29 Jun 2021 15:55:41 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id E2A3240E01\n for <dev@dpdk.org>; Tue, 29 Jun 2021 15:55:38 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Jun 2021 06:55:38 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.118.197])\n by orsmga007.jf.intel.com with ESMTP; 29 Jun 2021 06:55:36 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10029\"; a=\"207969158\"", "E=Sophos;i=\"5.83,309,1616482800\"; d=\"scan'208\";a=\"207969158\"", "E=Sophos;i=\"5.83,309,1616482800\"; d=\"scan'208\";a=\"447045499\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Haiyue Wang <haiyue.wang@intel.com>,\n Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Tue, 29 Jun 2021 21:33:32 +0800", "Message-Id": "<20210629133332.226897-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice: enable to set HW debug mask", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The HW debug mask is always zero, so user can't enable the related debug\nfunction like ICE_DBG_XXX etc.\n\nAdd the devarg 'hw_debug_mask' to set the function like for ICE_DBG_NVM:\n -a 0000:88:00.0,hw_debug_mask=0x80 --log-level=pmd.net.ice.driver:8\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 09e38590e5..5a18663430 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -26,11 +26,13 @@\n #define ICE_SAFE_MODE_SUPPORT_ARG \"safe-mode-support\"\n #define ICE_PIPELINE_MODE_SUPPORT_ARG \"pipeline-mode-support\"\n #define ICE_PROTO_XTR_ARG \"proto_xtr\"\n+#define ICE_HW_DEBUG_MASK_ARG \"hw_debug_mask\"\n \n static const char * const ice_valid_args[] = {\n \tICE_SAFE_MODE_SUPPORT_ARG,\n \tICE_PIPELINE_MODE_SUPPORT_ARG,\n \tICE_PROTO_XTR_ARG,\n+\tICE_HW_DEBUG_MASK_ARG,\n \tNULL\n };\n \n@@ -1836,6 +1838,25 @@ parse_bool(const char *key, const char *value, void *args)\n \treturn 0;\n }\n \n+static int\n+parse_u64(const char *key, const char *value, void *args)\n+{\n+\tu64 *num = (u64 *)args;\n+\tu64 tmp;\n+\n+\terrno = 0;\n+\ttmp = strtoull(value, NULL, 16);\n+\tif (errno) {\n+\t\tPMD_DRV_LOG(WARNING, \"%s: \\\"%s\\\" is not a valid u64\",\n+\t\t\t key, value);\n+\t\treturn -1;\n+\t}\n+\n+\t*num = tmp;\n+\n+\treturn 0;\n+}\n+\n static int ice_parse_devargs(struct rte_eth_dev *dev)\n {\n \tstruct ice_adapter *ad =\n@@ -1872,6 +1893,11 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)\n \tif (ret)\n \t\tgoto bail;\n \n+\tret = rte_kvargs_process(kvlist, ICE_HW_DEBUG_MASK_ARG,\n+\t\t\t\t &parse_u64, &ad->hw.debug_mask);\n+\tif (ret)\n+\t\tgoto bail;\n+\n bail:\n \trte_kvargs_free(kvlist);\n \treturn ret;\n@@ -5306,6 +5332,7 @@ RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_ice, \"* igb_uio | uio_pci_generic | vfio-pci\");\n RTE_PMD_REGISTER_PARAM_STRING(net_ice,\n+\t\t\t ICE_HW_DEBUG_MASK_ARG \"=0xXXX\"\n \t\t\t ICE_PROTO_XTR_ARG \"=[queue:]<vlan|ipv4|ipv6|ipv6_flow|tcp|ip_offset>\"\n \t\t\t ICE_SAFE_MODE_SUPPORT_ARG \"=<0|1>\"\n \t\t\t ICE_PIPELINE_MODE_SUPPORT_ARG \"=<0|1>\");\n", "prefixes": [ "v1" ] }